Fix issues with npm security #793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomas-Boi
added
devops
Panquesito7
approved these changes
Aug 10, 2021
Member
Panquesito7
left a comment
Panquesito7
left a comment
There was a problem hiding this comment.
I don't know too much about this (better let @amacado review this), but it LGTM. 👍
amacado
approved these changes
Aug 10, 2021
Member
|
Thanks for the update @Thomas-Boi! Very good pull request description! 👍🏻 |
Merged
GCHQDeveloper926
pushed a commit
to GCHQDeveloper926/devicon
that referenced
this pull request
Dec 20, 2024
* Fix issues with npm security (devicons#793) * Updated gulp * Update sass in gulpfile * Add gulp-footer * Change gulp-footer to devDepend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
yargsandglob-parent) are used bygulp's latest version and there's nothing I can do to upgrade them. Luckily, since the scripts don't accept user inputs, we should never run into any issues as listed bynpm auditgulp-footer, which will be used by my upcomingseleniumUpgrade. There's no usage of it yet, I just added the package to see if I need to address any securityTest
Here's the latest script testing the
sassmodules.Notes
This took a while because it requires the
socketiofix and theopen-glfix.Also, when you accept this PR, rename the commit to "Close #763: Update NPM packages". I want to see if this closes the listed commit automatically when we merge it into
master.