Skip to content

Conversation

@MichielPater
Copy link
Contributor

This PR adds/fixes

  • msdos icon: removed plain version from font for now as discussed in previous PR.

@Thomas-Boi
Copy link
Member

Hey @MichielPater,

I'm guessing that the plain version doesn't fit your standards?
image

I think it doesn't look as good as the line version either. Perhaps let's remove the plain file as well along with your current change?

@MichielPater
Copy link
Contributor Author

Oh I thought the SVG looked good on the website, just the font looked different!

@Thomas-Boi Thomas-Boi changed the title Update msdos update icon: msdos (original, plain, line) Aug 30, 2021
@Thomas-Boi Thomas-Boi added the feature:icon PR when a new icon is ready to be added to the collection label Aug 30, 2021
Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you mean. In that case, I'll just update your PR so our bot can remove the plain version in the next build.

@Thomas-Boi Thomas-Boi merged commit 1a14488 into devicons:develop Aug 30, 2021
This was referenced Sep 7, 2021
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
* Revert

* Updated icon: msdos (removed plain version from font)

Co-authored-by: David Leal <[email protected]>
Co-authored-by: Thomas Bui <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants