opts: remove deprecated types and functions #6293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This type is no longer used, and was deprecated in 187a942 Signed-off-by: Sebastiaan van Stijn <[email protected]>
This function is no longer used, and was deprecated in d0ac0ac. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
impact/deprecation
status/2-code-review
kind/refactor
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
It's no longer used and replaced by `ListOpts.GetSlice`. It was deprecated in 5215b1e Signed-off-by: Sebastiaan van Stijn <[email protected]>
These were deprecated in 6f0c66c and are no longer used. This removes the deprecated: - `NewNamedListOptsRef` - `NewNamedMapOpts` - `NamedListOpts` - `NamedMapOpts` - `NamedOption` Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
remove_deprecated_opts
branch
from
3297dd0 to
5934553
Compare
Benehiko
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to:
opts: remove deprecated QuotedString
This type is no longer used, and was deprecated in 187a942
opts: remove deprecated ValidateHost
This function is no longer used, and was deprecated in
d0ac0ac.
opts: remove deprecated ListOpts.GetAll
It's no longer used and replaced by
ListOpts.GetSlice. It was deprecatedin 5215b1e
opts: remove deprecated NewNamedListOptsRef, NewNamedMapOpts
These were deprecated in 6f0c66c and are
no longer used.
This removes the deprecated:
NewNamedListOptsRefNewNamedMapOptsNamedListOptsNamedMapOptsNamedOption- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)