Skip to content

Conversation

@norberttech
Copy link
Member

Change Log

Added

Fixed

  • Any comparison function will now return false when comparing non null value wth nulls

Changed

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev         |
+-----------------------+-------------------+------+-----+------------------+------------------+----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 3.914mb +0.01%   | 510.009ms +0.60% | ±0.38% -46.40% |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 3.947mb +0.01%   | 1.064s -0.05%    | ±0.33% +36.98% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 135.388mb +0.00% | 745.966ms -0.29% | ±0.29% -65.09% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 3.674mb +0.01%   | 33.711ms -0.09%  | ±1.27% -38.80% |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 3.621mb +0.01%   | 428.078ms -1.46% | ±1.51% +28.89% |
+-----------------------+-------------------+------+-----+------------------+------------------+----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 115.966mb +0.00% | 58.503ms -3.10% | ±0.14% -89.57% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+-----------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode            | rstdev          |
+--------------------+----------------+------+-----+------------------+-----------------+-----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.069mb +0.00%  | 86.218ms +1.39% | ±1.67% +6.97%   |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 106.502mb +0.00% | 52.391ms +1.47% | ±0.54% +491.82% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 225.838mb +0.00% | 1.499s -0.67%   | ±0.32% -14.00%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 16.863mb +0.00%  | 44.671ms -0.11% | ±0.11% -71.60%  |
+--------------------+----------------+------+-----+------------------+-----------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev           |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 116.517mb +0.00% | 494.679ms -0.25% | ±1.77% -47.76%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 59.995mb +0.00%  | 248.232ms +0.58% | ±1.30% +38.11%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.928mb +0.00%  | 55.553ms +2.41%  | ±2.14% +87.92%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.695mb +0.00%  | 436.750ms +1.07% | ±2.91% +879.78%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.234mb +0.00%  | 91.394ms +4.07%  | ±3.03% -13.33%   |
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 86.786mb +0.00%  | 3.707ms +6.78%   | ±1.46% +292.95%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 102.385mb +0.00% | 190.055ms +0.95% | ±0.62% -48.70%   |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 85.105mb +0.00%  | 18.768ms -0.58%  | ±0.94% +318.02%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 88.026mb +0.00%  | 1.964ms +4.45%   | ±0.89% -61.84%   |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 88.026mb +0.00%  | 1.930ms +5.55%   | ±0.40% -83.59%   |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 85.139mb +0.00%  | 3.090ms +8.23%   | ±2.91% -12.84%   |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 85.667mb +0.00%  | 15.455ms +3.09%  | ±1.23% +325.17%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 85.667mb +0.00%  | 15.435ms +2.45%  | ±0.45% -44.57%   |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 83.572mb +0.00%  | 1.894μs +11.41%  | ±2.53% +0.00%    |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 83.572mb +0.00%  | 0.300μs -25.00%  | ±0.00% -100.00%  |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 92.922mb +0.00%  | 12.729ms +4.41%  | ±2.58% +368.08%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 122.292mb +0.00% | 62.179ms -0.15%  | ±0.75% +115.93%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 86.187mb +0.00%  | 1.625ms +5.96%   | ±0.87% -72.86%   |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 89.534mb +0.00%  | 65.987ms +2.18%  | ±0.72% -33.82%   |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 88.289mb +0.00%  | 4.252ms +2.68%   | ±3.02% +321.53%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 83.715mb +0.00%  | 39.670ms +2.48%  | ±2.58% +1541.28% |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 83.716mb +0.00%  | 41.926ms +7.38%  | ±1.74% +132.96%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 83.715mb +0.00%  | 40.551ms +0.19%  | ±1.50% -39.65%   |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 86.013mb +0.00%  | 7.553ms +1.82%   | ±1.15% +97.93%   |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 83.572mb +0.00%  | 29.986ms +4.74%  | ±2.88% +103.96%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 83.572mb +0.00%  | 13.988μs +1.27%  | ±0.68% -0.48%    |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 83.572mb +0.00%  | 16.912μs +3.65%  | ±1.57% +17.39%   |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 102.386mb +0.00% | 190.876ms +0.02% | ±2.19% +184.37%  |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+

@norberttech norberttech merged commit de1d7d3 into flow-php:1.x Jul 5, 2024
@norberttech norberttech deleted the feature/unify-comparisons-between-values-and-nulls branch December 5, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant