Skip to content

Conversation

@norberttech
Copy link
Member

Change Log

Added

Fixed

  • Fixed Flow to Parquet Schema converter not respecting deprecated parquet converted types

Changed

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev         |
+-----------------------+-------------------+------+-----+------------------+------------------+----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 3.914mb +0.01%   | 524.411ms +2.35% | ±3.38% +67.79% |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 3.947mb +0.01%   | 1.058s -0.65%    | ±0.40% -62.35% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 135.388mb -0.00% | 764.509ms +2.80% | ±1.70% +29.04% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 3.674mb +0.01%   | 33.920ms +0.45%  | ±0.55% -77.91% |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 3.621mb +0.01%   | 438.393ms +0.35% | ±0.55% +35.36% |
+-----------------------+-------------------+------+-----+------------------+------------------+----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev          |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 115.966mb +0.00% | 60.838ms +1.83% | ±1.29% +314.03% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
Loaders
+--------------------+----------------+------+-----+------------------+-----------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode            | rstdev         |
+--------------------+----------------+------+-----+------------------+-----------------+----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.069mb +0.00%  | 86.797ms +3.28% | ±0.22% -53.80% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 106.502mb +0.00% | 52.167ms +0.94% | ±0.27% -24.05% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 225.838mb -0.00% | 1.515s +0.45%   | ±0.64% +33.22% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 16.863mb +0.00%  | 44.734ms +0.47% | ±0.39% -45.01% |
+--------------------+----------------+------+-----+------------------+-----------------+----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 116.517mb +0.00% | 497.483ms +1.17% | ±0.56% -14.23%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 59.995mb +0.00%  | 271.878ms +8.07% | ±0.58% -81.53%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.928mb +0.00%  | 56.270ms +6.15%  | ±1.17% +202.63% |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.695mb +0.00%  | 436.261ms +0.61% | ±0.37% -38.55%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.234mb +0.00%  | 92.056ms +8.31%  | ±0.89% -6.15%   |
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 86.786mb +0.00%  | 3.467ms +6.46%   | ±3.09% +24.58%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 102.385mb +0.00% | 186.840ms -5.08% | ±1.23% -5.80%   |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 85.105mb +0.00%  | 19.351ms -0.83%  | ±1.23% +19.23%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 88.026mb +0.00%  | 2.135ms +6.82%   | ±3.02% +25.16%  |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 88.026mb +0.00%  | 2.188ms +6.95%   | ±2.31% -15.84%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 85.139mb +0.00%  | 2.984ms +8.28%   | ±3.58% +140.41% |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 85.667mb +0.00%  | 16.622ms +9.74%  | ±1.33% +35.68%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 85.667mb +0.00%  | 17.049ms +13.86% | ±0.64% -0.39%   |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 83.572mb +0.00%  | 1.794μs 0.00%    | ±2.67% 0.00%    |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 83.572mb +0.00%  | 0.400μs +33.33%  | ±0.00% +0.00%   |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 92.922mb +0.00%  | 12.884ms +3.81%  | ±2.39% +10.71%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 122.292mb +0.00% | 62.852ms +2.47%  | ±0.38% -14.60%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 86.187mb +0.00%  | 1.560ms +6.07%   | ±3.56% +7.03%   |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 89.534mb +0.00%  | 66.947ms +0.59%  | ±0.46% -30.93%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 88.289mb +0.00%  | 4.277ms +8.00%   | ±2.88% +262.78% |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 83.715mb +0.00%  | 39.205ms -0.04%  | ±1.03% -30.58%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 83.716mb +0.00%  | 39.202ms -1.99%  | ±0.78% +321.15% |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 83.715mb +0.00%  | 42.683ms +5.30%  | ±2.50% +19.66%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 86.013mb +0.00%  | 7.497ms +1.09%   | ±1.53% +188.72% |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 83.572mb +0.00%  | 29.131ms +2.33%  | ±1.79% +17.66%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 83.572mb +0.00%  | 13.824μs +3.01%  | ±1.35% +45.04%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 83.572mb +0.00%  | 16.166μs +3.35%  | ±1.27% -39.26%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 102.386mb +0.00% | 192.089ms -1.99% | ±1.29% +20.81%  |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@norberttech norberttech merged commit d00b217 into flow-php:1.x Jul 5, 2024
@norberttech norberttech deleted the bug/parquet-adapter-respect-converted-types branch December 5, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant