Add array_to_row helper function
#1149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norberttech
reviewed
Jul 28, 2024
| [ | ||
| ['id' => 1234, 'deleted' => false, 'phase' => null], | ||
| ['id' => 4321, 'deleted' => true, 'phase' => 'launch'], | ||
| ] |
Member
There was a problem hiding this comment.
hmm I'm honestly not sure how this edge case should be handled, because technically speaking this is a use case for array_to_rows() and the output that returns only one row when input defines two of them is a bit hard to predict.
I'm tempted to say that in this case array_to_row should throw an exception.
The validation could simply check if all array keys are strings (since only strings can become a entry names)
norberttech
reviewed
Jul 28, 2024
stloyd
force-pushed
the
feature/array-to-row
branch
from
81bd0d3 to
59967e5
Compare
stloyd
force-pushed
the
feature/array-to-row
branch
from
59967e5 to
e1f1589
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security
Description