Skip to content

Conversation

@norberttech
Copy link
Member

Change Log

Added

  • XMLParserExtractor implementation of XMLExtractor

Fixed

Changed

  • XMLReaderExtractor is now deprecated as it can't read from remote files

Removed

Deprecated

Security


Description

I'm not sure what to do with XMLReaderExtractor, for now I'm gonna leave it deprecated but I think it should be removed since it brings zero added value compared to XMLParserExtractor.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2024

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+-----------------+--------------------+----------------+
| benchmark             | subject           | revs | its | mem_peak        | mode               | rstdev         |
+-----------------------+-------------------+------+-----+-----------------+--------------------+----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.130mb +0.02%  | 511.210ms +0.50%   | ±0.70% -44.40% |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.263mb +0.02%  | 1.068s -0.09%      | ±0.87% -4.22%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 28.725mb +0.00% | 432.356ms +0.47%   | ±0.71% -7.90%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 3.890mb +0.02%  | 33.578ms -3.20%    | ±1.97% +28.89% |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 3.845mb +0.91%  | 770.096ms +147.65% | ±1.22% -57.91% |
+-----------------------+-------------------+------+-----+-----------------+--------------------+----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+---------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev        |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+---------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 116.231mb +0.00% | 59.074ms +1.19% | ±0.81% -3.34% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+---------------+
Loaders
+--------------------+----------------+------+-----+------------------+-----------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode            | rstdev          |
+--------------------+----------------+------+-----+------------------+-----------------+-----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.352mb +0.00%  | 85.295ms -0.06% | ±0.28% -66.04%  |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 102.674mb +0.00% | 53.026ms +2.00% | ±0.58% +176.95% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 124.004mb +0.00% | 1.229s -0.35%   | ±0.63% +0.56%   |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.146mb +0.00%  | 44.175ms +2.41% | ±0.21% -48.75%  |
+--------------------+----------------+------+-----+------------------+-----------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 52.812mb +0.00%  | 387.803ms -5.66% | ±0.34% -86.94%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 13.078mb +0.01%  | 78.335ms -0.01%  | ±1.66% +116.38% |
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 86.988mb +0.00%  | 3.356ms +5.37%   | ±1.07% +19.68%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 102.591mb +0.00% | 188.263ms +0.11% | ±0.98% +209.67% |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 85.311mb +0.00%  | 18.717ms -0.95%  | ±0.95% +121.89% |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 88.228mb +0.00%  | 1.969ms +23.55%  | ±0.37% +5.35%   |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 88.228mb +0.00%  | 1.764ms +18.29%  | ±3.15% -3.53%   |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 85.340mb +0.00%  | 2.639ms -3.46%   | ±3.62% +236.65% |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 85.869mb +0.00%  | 15.976ms +3.48%  | ±0.82% +16.34%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 85.869mb +0.00%  | 16.218ms +4.01%  | ±0.52% -47.53%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 83.772mb +0.00%  | 1.694μs 0.00%    | ±2.83% 0.00%    |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 83.772mb +0.00%  | 0.400μs +33.33%  | ±0.00% +0.00%   |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 93.123mb +0.00%  | 12.443ms +1.69%  | ±1.31% +171.98% |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 122.493mb +0.00% | 61.544ms +2.67%  | ±0.65% -18.58%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 86.388mb +0.00%  | 1.366ms +15.56%  | ±2.87% +6.29%   |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 89.740mb +0.00%  | 59.028ms +2.01%  | ±0.95% -6.65%   |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 88.490mb +0.00%  | 3.939ms +4.53%   | ±1.54% +627.22% |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 83.922mb +0.00%  | 38.682ms -0.12%  | ±1.13% +124.56% |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 83.922mb +0.00%  | 39.411ms +1.27%  | ±1.58% +50.04%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 83.922mb +0.00%  | 39.386ms +1.66%  | ±0.20% -68.75%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 86.214mb +0.00%  | 7.403ms +1.86%   | ±0.85% +54.13%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 83.772mb +0.00%  | 28.748ms -0.07%  | ±0.72% +85.94%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 83.772mb +0.00%  | 13.430μs +0.84%  | ±1.74% +64.62%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 83.772mb +0.00%  | 16.598μs +6.11%  | ±3.93% +88.81%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 102.592mb +0.00% | 194.822ms +1.46% | ±0.41% -20.54%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 107.004mb +0.00% | 474.755ms +1.58% | ±0.89% +32.15%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 55.363mb +0.00%  | 237.194ms +1.55% | ±1.27% +233.77% |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.201mb +0.01%  | 50.522ms -0.19%  | ±1.49% +161.46% |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@norberttech norberttech merged commit 99a1990 into flow-php:1.x Aug 5, 2024
@norberttech norberttech deleted the feature/xml-parser-extractor branch December 5, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant