Skip to content

Conversation

@szepeviktor
Copy link
Contributor

Change Log

Added

Fixed

  • Fix docblock tag in FlowVersion

Changed

Removed

Deprecated

Security


Description

Fix docblock tag in FlowVersion.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak        | mode             | rstdev          |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.131mb +0.00%  | 508.942ms -0.02% | ±0.18% -82.90%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.263mb +0.00%  | 1.082s +0.55%    | ±1.17% +254.86% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 28.725mb +0.00% | 430.683ms -1.32% | ±0.60% -40.82%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 3.890mb +0.00%  | 33.761ms -3.22%  | ±1.54% -0.33%   |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 3.880mb +0.00%  | 751.656ms -0.33% | ±1.65% -13.12%  |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 116.232mb +0.00% | 58.359ms -1.33% | ±0.40% -71.17% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+-----------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode            | rstdev         |
+--------------------+----------------+------+-----+------------------+-----------------+----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.353mb +0.00%  | 84.246ms -0.30% | ±0.69% -76.93% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 102.675mb +0.00% | 52.380ms -2.16% | ±1.43% +23.82% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 124.005mb +0.00% | 1.237s -0.51%   | ±0.17% -36.76% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.147mb +0.00%  | 43.874ms -2.14% | ±0.22% -33.57% |
+--------------------+----------------+------+-----+------------------+-----------------+----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev           |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 52.812mb +0.00%  | 419.405ms +8.27% | ±0.28% -92.16%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 13.078mb +0.00%  | 79.120ms +1.62%  | ±0.78% +36.65%   |
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 86.988mb +0.00%  | 3.233ms -4.64%   | ±1.00% -34.93%   |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 102.592mb +0.00% | 185.022ms -1.37% | ±0.47% -62.36%   |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 85.312mb +0.00%  | 18.703ms -0.59%  | ±0.38% +13.58%   |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 88.228mb +0.00%  | 1.730ms +0.24%   | ±1.30% +33.07%   |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 88.228mb +0.00%  | 1.678ms -7.21%   | ±0.13% -91.90%   |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 85.340mb +0.00%  | 2.563ms -5.90%   | ±0.86% -41.39%   |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 85.869mb +0.00%  | 16.206ms -0.25%  | ±1.07% +71.50%   |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 85.869mb +0.00%  | 16.593ms +2.85%  | ±1.43% +27.07%   |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 83.773mb +0.00%  | 1.600μs -0.38%   | ±0.00% -100.00%  |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 83.773mb +0.00%  | 0.400μs 0.00%    | ±0.00% 0.00%     |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 93.123mb +0.00%  | 12.056ms -3.29%  | ±0.98% +48.45%   |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 122.494mb +0.00% | 61.415ms -0.21%  | ±2.65% +8179.33% |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 86.389mb +0.00%  | 1.356ms -3.59%   | ±1.86% -16.05%   |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 89.740mb +0.00%  | 60.003ms +0.19%  | ±0.71% -62.47%   |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 88.490mb +0.00%  | 3.890ms -2.53%   | ±3.50% +90.74%   |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 83.922mb +0.00%  | 39.323ms -3.40%  | ±0.90% -71.25%   |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 83.923mb +0.00%  | 39.380ms -3.21%  | ±1.92% -7.62%    |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 83.922mb +0.00%  | 39.349ms -2.12%  | ±0.83% -44.21%   |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 86.214mb +0.00%  | 7.303ms -2.66%   | ±1.13% +246.89%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 83.773mb +0.00%  | 28.521ms -2.58%  | ±0.44% -58.87%   |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 83.773mb +0.00%  | 13.300μs -5.41%  | ±0.00% -100.00%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 83.773mb +0.00%  | 16.300μs -2.64%  | ±0.50% -66.60%   |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 102.593mb +0.00% | 192.988ms -1.38% | ±0.86% +21.45%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 107.005mb +0.00% | 467.948ms -0.26% | ±3.32% +1267.46% |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 55.363mb +0.00%  | 237.146ms +0.15% | ±0.17% -90.16%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.201mb +0.00%  | 51.235ms -0.21%  | ±1.31% +68.94%   |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+

@norberttech norberttech merged commit 56213d7 into flow-php:1.x Aug 6, 2024
@szepeviktor
Copy link
Contributor Author

Glad to contribute.

@szepeviktor szepeviktor deleted the patch-1 branch August 6, 2024 20:04
@szepeviktor szepeviktor changed the title Fix a typos in FlowVersion Fix a typo in FlowVersion Aug 6, 2024
@norberttech
Copy link
Member

Glad to contribute.

Thank you! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants