Skip to content

Conversation

@norberttech
Copy link
Member

Change Log

Added

Fixed

Changed

  • Moved flow phar to dedicated cli repository

Removed

Deprecated

Security


Description

This should also significantly reduce phar size, since before it was loading literally all dependencies, now it only load dependencies of src/cli package.

@github-actions
Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak        | mode             | rstdev          |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.599mb +0.01%  | 518.571ms -1.32% | ±3.12% +15.10%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.687mb +0.01%  | 1.092s +0.12%    | ±0.46% +67.15%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 29.142mb +0.00% | 445.431ms +1.43% | ±0.71% -21.10%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.327mb +0.02%  | 33.182ms -2.54%  | ±2.20% +101.84% |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.309mb +0.02%  | 651.274ms -1.16% | ±0.44% -80.74%  |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 116.603mb +0.00% | 60.983ms -0.07% | ±0.93% -20.23% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+-------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode              | rstdev          |
+--------------------+----------------+------+-----+------------------+-------------------+-----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.796mb +0.00%  | 142.134ms +15.89% | ±1.62% +91.87%  |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 90.380mb +0.00%  | 117.982ms +17.27% | ±0.95% +46.00%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 124.433mb +0.00% | 1.250s -0.24%     | ±0.49% +154.94% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.518mb +0.00%  | 43.813ms +46.82%  | ±1.25% +515.16% |
+--------------------+----------------+------+-----+------------------+-------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev           |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 87.353mb +0.00%  | 3.431ms -8.72%   | ±1.15% -32.78%   |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 102.957mb +0.00% | 191.514ms -0.05% | ±0.93% +581.18%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 85.677mb +0.00%  | 19.345ms +0.82%  | ±0.94% +1219.43% |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 88.593mb +0.00%  | 1.759ms -4.30%   | ±1.66% -19.32%   |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 88.593mb +0.00%  | 1.825ms +0.81%   | ±2.24% -13.60%   |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 85.705mb +0.00%  | 2.877ms -1.45%   | ±1.95% +56.65%   |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 86.234mb +0.00%  | 16.876ms +1.04%  | ±0.28% -76.90%   |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 86.234mb +0.00%  | 16.695ms -2.12%  | ±0.78% -72.31%   |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 84.138mb +0.00%  | 1.806μs 0.00%    | ±2.57% 0.00%     |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 84.138mb +0.00%  | 0.400μs 0.00%    | ±0.00% 0.00%     |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 93.488mb +0.00%  | 13.061ms +1.84%  | ±1.40% -39.03%   |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 122.859mb +0.00% | 62.720ms -1.62%  | ±0.99% +122.39%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 86.754mb +0.00%  | 1.718ms +2.64%   | ±0.32% -85.80%   |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 90.105mb +0.00%  | 66.291ms +8.73%  | ±1.00% +77.10%   |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 88.855mb +0.00%  | 4.605ms +6.02%   | ±1.79% +99.14%   |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 84.287mb +0.00%  | 41.548ms +0.78%  | ±0.79% +120.57%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 84.288mb +0.00%  | 41.269ms -0.79%  | ±0.97% -57.68%   |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 84.287mb +0.00%  | 41.834ms +1.61%  | ±1.11% -63.30%   |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 86.579mb +0.00%  | 7.436ms -0.46%   | ±1.82% +27.59%   |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 84.138mb +0.00%  | 29.342ms -0.89%  | ±0.25% -72.08%   |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 84.138mb +0.00%  | 13.243μs -3.91%  | ±2.47% +139.15%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 84.138mb +0.00%  | 15.906μs -2.66%  | ±0.30% -80.75%   |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 102.958mb +0.00% | 194.596ms +0.05% | ±0.98% -12.59%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 53.179mb +0.00%  | 399.670ms -1.15% | ±0.32% -38.53%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 13.445mb +0.01%  | 80.373ms -2.22%  | ±0.38% -65.16%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 107.441mb +0.00% | 481.500ms -0.61% | ±2.35% +236.45%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 55.800mb +0.00%  | 246.934ms +0.41% | ±0.47% -77.89%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.638mb +0.00%  | 52.342ms -1.19%  | ±2.11% +22.19%   |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+

@norberttech norberttech merged commit ea59a4b into flow-php:1.x Oct 10, 2024
@norberttech norberttech deleted the feature/flow-cli branch December 5, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant