Skip to content

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented Nov 17, 2024

Change Log

Added

Fixed

  • Fixed main branch static analyse issues

Changed

  • Upgrade PHPStan to 2.0
  • Adjust codebase to cover newly detected issues

Removed

Deprecated

Security


Description

@stloyd stloyd force-pushed the chore/phpstan-two-zero branch 2 times, most recently from b6fa3e1 to 39ff61a Compare November 17, 2024 16:56
@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2024

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak        | mode             | rstdev          |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.619mb +0.01%  | 517.859ms +0.21% | ±0.39% -32.32%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.708mb +0.01%  | 1.101s +1.57%    | ±0.56% -41.15%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 29.315mb +0.00% | 451.596ms +1.67% | ±1.02% -49.47%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.348mb +0.01%  | 34.045ms +1.18%  | ±1.86% +271.47% |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.330mb +0.01%  | 657.017ms +0.54% | ±1.61% +67.28%  |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 116.624mb -0.00% | 61.151ms +2.05% | ±0.10% -77.69% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev         |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.817mb +0.00%  | 138.778ms -0.91% | ±0.13% -72.45% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 90.401mb +0.00%  | 116.179ms -0.72% | ±0.49% -43.23% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 124.671mb +0.00% | 1.250s +0.13%    | ±0.35% -39.27% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.539mb +0.00%  | 43.761ms -1.44%  | ±0.29% -69.45% |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev           |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 87.372mb +0.00%  | 3.357ms -0.49%   | ±0.62% +46.43%   |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 102.975mb +0.00% | 186.359ms -0.39% | ±0.34% -23.69%   |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 85.695mb +0.00%  | 19.176ms +2.27%  | ±1.10% +565.12%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 88.612mb +0.00%  | 1.727ms -5.59%   | ±1.12% -56.84%   |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 88.612mb +0.00%  | 1.816ms +1.88%   | ±1.25% +94.31%   |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 85.724mb +0.00%  | 3.100ms +9.86%   | ±3.26% +154.78%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 86.253mb +0.00%  | 16.881ms +6.41%  | ±0.59% -71.93%   |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 86.253mb +0.00%  | 17.313ms +10.35% | ±1.38% -15.44%   |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 84.156mb +0.00%  | 1.694μs -10.56%  | ±2.83% +12.00%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 84.156mb +0.00%  | 0.400μs 0.00%    | ±0.00% 0.00%     |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 93.507mb +0.00%  | 13.488ms +5.72%  | ±2.99% +130.23%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 122.878mb +0.00% | 63.108ms +1.81%  | ±1.33% +56.67%   |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 86.772mb +0.00%  | 1.639ms +14.71%  | ±1.69% +226.06%  |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 90.124mb +0.00%  | 64.577ms +0.83%  | ±1.30% +17.61%   |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 88.874mb +0.00%  | 4.617ms +10.21%  | ±1.46% +1238.92% |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 84.306mb +0.00%  | 40.985ms +1.19%  | ±1.00% +179.52%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 84.307mb +0.00%  | 40.241ms -2.31%  | ±1.23% -0.16%    |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 84.306mb +0.00%  | 40.718ms -1.10%  | ±0.53% -39.98%   |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 86.598mb +0.00%  | 7.322ms -0.30%   | ±0.44% +164.71%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 84.156mb +0.00%  | 28.852ms -3.52%  | ±0.51% -27.54%   |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 84.156mb +0.00%  | 13.834μs +3.97%  | ±1.49% +322.17%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 84.156mb +0.00%  | 16.544μs +4.17%  | ±2.24% +149.80%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 102.976mb +0.00% | 192.301ms +0.74% | ±0.97% -68.28%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 53.198mb +0.00%  | 401.461ms +0.76% | ±0.62% -59.11%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 13.464mb +0.00%  | 80.008ms +0.07%  | ±0.88% +1731.81% |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 107.460mb +0.00% | 485.781ms -1.35% | ±0.45% -29.63%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 55.818mb +0.00%  | 249.485ms +0.95% | ±1.30% -1.07%    |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.656mb +0.00%  | 52.749ms -1.51%  | ±0.97% +219.33%  |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+

@stloyd stloyd force-pushed the chore/phpstan-two-zero branch from 39ff61a to 7ba0bc1 Compare November 17, 2024 17:02
@stloyd stloyd requested a review from norberttech November 17, 2024 17:02
@norberttech norberttech merged commit 6fd17cc into flow-php:1.x Nov 17, 2024
26 checks passed
@norberttech
Copy link
Member

sweet <3

@stloyd stloyd deleted the chore/phpstan-two-zero branch November 18, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants