Skip to content

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented Dec 27, 2024

Change Log

Added

Fixed

Changed

Removed

  • Drop support for PHP 8.1

Deprecated

Security


Description

Fixes #1283

@norberttech
Copy link
Member

This should be merged after #1287 it also means that local development and the code needs to be written in 8.2

@github-actions
Copy link
Contributor

github-actions bot commented Dec 27, 2024

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+-------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak          | mode             | rstdev          |
+-----------------------+-------------------+------+-----+-------------------+------------------+-----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.707mb -1.58%    | 515.578ms +0.52% | ±0.54% +7.61%   |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.810mb -1.52%    | 1.112s +0.70%    | ±2.47% +200.67% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 102.528mb -15.75% | 907.006ms -3.19% | ±0.30% -71.83%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.435mb -1.58%    | 33.311ms +0.05%  | ±0.87% -25.14%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.413mb -1.60%    | 664.459ms +0.18% | ±0.26% -58.61%  |
+-----------------------+-------------------+------+-----+-------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+---------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev        |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+---------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 117.578mb -2.73% | 60.865ms +0.38% | ±1.41% +2.41% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+---------------+
Loaders
+--------------------+----------------+------+-----+-------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak          | mode             | rstdev          |
+--------------------+----------------+------+-----+-------------------+------------------+-----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 55.703mb -1.07%   | 111.791ms -0.02% | ±0.97% +136.73% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 90.910mb -5.94%   | 102.127ms -3.06% | ±1.16% +239.57% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 255.717mb -34.55% | 19.320s -10.43%  | ±0.34% +70.60%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.784mb -3.34%   | 44.138ms +0.01%  | ±0.77% -61.75%  |
+--------------------+----------------+------+-----+-------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 88.404mb -3.37%  | 3.082ms -10.70%  | ±0.58% -57.69%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 103.942mb -1.20% | 188.573ms -1.91% | ±0.73% +74.61%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 86.662mb -1.44%  | 18.829ms -1.58%  | ±3.20% +298.49% |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 89.644mb -3.73%  | 1.409ms -22.69%  | ±2.29% +276.41% |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 89.644mb -3.73%  | 1.404ms -23.68%  | ±0.49% -71.47%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 86.756mb -2.65%  | 2.272ms -16.69%  | ±0.59% -71.42%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 87.285mb -2.63%  | 17.460ms +17.59% | ±0.27% -70.26%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 87.285mb -2.63%  | 17.720ms +19.40% | ±1.04% +156.82% |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 85.190mb -1.77%  | 1.800μs -4.96%   | ±0.00% -100.00% |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 85.190mb -1.77%  | 0.400μs 0.00%    | ±0.00% 0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 94.700mb -2.58%  | 13.038ms +1.66%  | ±0.62% -68.33%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 123.910mb -2.70% | 61.431ms +0.77%  | ±0.58% -58.38%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 87.805mb -2.62%  | 1.305ms -10.08%  | ±2.77% +676.57% |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 91.095mb -2.52%  | 60.589ms +0.02%  | ±1.41% +95.97%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 89.906mb -3.72%  | 3.558ms -14.53%  | ±3.09% +70.91%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 85.273mb -1.55%  | 41.121ms -0.89%  | ±1.13% +3.33%   |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 85.274mb -1.55%  | 40.829ms -16.78% | ±0.17% -94.87%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 85.273mb -1.55%  | 43.029ms -2.44%  | ±0.97% -13.13%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 87.631mb -1.72%  | 7.666ms +3.58%   | ±0.10% -84.07%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 85.190mb -1.55%  | 29.591ms +2.01%  | ±0.73% +246.97% |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 85.190mb -1.77%  | 12.642μs -6.12%  | ±2.57% +69.35%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 85.190mb -1.77%  | 15.300μs -4.38%  | ±0.53% -47.71%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 103.943mb -1.20% | 192.421ms -1.59% | ±0.20% -77.30%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 53.308mb -5.12%  | 402.387ms +1.17% | ±0.84% +30.50%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 13.574mb -4.27%  | 80.633ms +1.75%  | ±0.17% -76.21%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 108.029mb -2.03% | 483.335ms +0.96% | ±0.83% -52.17%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 56.147mb -2.00%  | 246.773ms +2.54% | ±0.50% -72.43%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.794mb -1.66%  | 52.995ms -2.10%  | ±1.06% -49.02%  |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@stloyd stloyd requested a review from norberttech December 27, 2024 16:46
@norberttech norberttech merged commit 3c67121 into flow-php:1.x Dec 27, 2024
21 checks passed
@stloyd stloyd deleted the feature/1283 branch December 27, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop PHP 8.1 support

2 participants