Skip to content

Conversation

@norberttech
Copy link
Member

@norberttech norberttech commented Jan 4, 2025

Change Log

Added

  • template to Types that defines underlying data type

Fixed

Changed

  • Made return types of casting handlers more strict

Removed

Deprecated

Security


Description

Resolves: #1323

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2025

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+-----------------+------------------+----------------+
| benchmark             | subject           | revs | its | mem_peak        | mode             | rstdev         |
+-----------------------+-------------------+------+-----+-----------------+------------------+----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.747mb +0.16%  | 515.295ms +0.77% | ±0.59% +48.86% |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.852mb +0.16%  | 1.081s -0.65%    | ±0.80% +13.50% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 86.491mb +0.01% | 898.739ms -0.20% | ±0.16% -34.44% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.480mb +0.17%  | 32.044ms +1.13%  | ±0.61% +51.55% |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.456mb +0.17%  | 667.682ms -0.42% | ±0.77% +19.04% |
+-----------------------+-------------------+------+-----+-----------------+------------------+----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 108.476mb +0.01% | 57.185ms -1.59% | ±1.00% +87.01% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.021mb +0.01%  | 114.166ms -4.13% | ±2.21% +106.60% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 82.564mb +0.01%  | 105.093ms -3.94% | ±0.44% -46.60%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 166.987mb +0.01% | 20.185s +3.65%   | ±0.70% +96.89%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.065mb +0.04%  | 43.800ms -3.51%  | ±2.04% +461.62% |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 80.252mb +0.01%  | 3.327ms +1.82%   | ±2.32% +194.45% |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 97.525mb +0.01%  | 184.261ms -1.76% | ±0.25% -81.67%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 80.245mb +0.01%  | 18.515ms -2.01%  | ±1.27% +456.20% |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 81.126mb +0.01%  | 1.734ms +4.06%   | ±2.63% -22.31%  |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 81.126mb +0.01%  | 1.642ms +0.25%   | ±2.51% +90.63%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 79.287mb +0.01%  | 3.564ms +2.31%   | ±0.82% -71.80%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 79.816mb +0.01%  | 15.073ms -5.23%  | ±1.07% +111.49% |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 79.816mb +0.01%  | 15.447ms -0.23%  | ±0.91% -6.02%   |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 78.507mb +0.01%  | 1.894μs -0.64%   | ±2.53% +3.57%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 78.507mb +0.01%  | 0.400μs 0.00%    | ±0.00% 0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 86.845mb +0.01%  | 12.389ms -1.15%  | ±0.54% -29.98%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 114.192mb +0.01% | 58.491ms +0.19%  | ±1.19% +144.40% |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 80.336mb +0.01%  | 1.496ms -4.98%   | ±1.96% -37.80%  |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 83.625mb +0.01%  | 59.719ms -2.32%  | ±0.37% -69.08%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 81.389mb +0.01%  | 4.314ms +12.65%  | ±0.60% -58.01%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 78.787mb +0.01%  | 40.716ms -1.41%  | ±0.96% +385.56% |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 78.787mb +0.01%  | 40.986ms -2.74%  | ±1.02% +4.42%   |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 78.787mb +0.01%  | 43.348ms +3.40%  | ±1.00% -23.79%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 80.948mb +0.01%  | 7.828ms -0.53%   | ±1.06% +149.43% |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 78.698mb +0.01%  | 30.072ms +2.67%  | ±2.18% +160.81% |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 78.507mb +0.01%  | 13.559μs -1.45%  | ±1.83% -13.82%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 78.507mb +0.01%  | 15.467μs +2.40%  | ±3.29% +25.21%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 97.526mb +0.01%  | 185.118ms -1.50% | ±0.23% +59.73%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 49.241mb +0.00%  | 385.300ms +0.86% | ±1.10% +354.32% |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 12.808mb +0.01%  | 77.333ms -0.52%  | ±0.36% -70.16%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 103.307mb +0.01% | 459.808ms +0.35% | ±0.47% -52.92%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 53.817mb +0.01%  | 233.273ms +0.60% | ±0.36% -51.85%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.395mb +0.05%  | 51.493ms +2.22%  | ±1.27% +18.68%  |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@codecov
Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.46%. Comparing base (91215c0) to head (7662106).
Report is 2 commits behind head on 1.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              1.x    #1326   +/-   ##
=======================================
  Coverage   82.45%   82.46%           
=======================================
  Files         644      644           
  Lines       17431    17431           
=======================================
+ Hits        14373    14374    +1     
+ Misses       3058     3057    -1     
Components Coverage Δ
etl 85.61% <100.00%> (ø)
cli 85.17% <ø> (ø)
lib-array-dot 94.53% <ø> (ø)
lib-azure-sdk 62.60% <ø> (ø)
lib-doctrine-dbal-bulk 97.36% <ø> (ø)
lib-filesystem 76.24% <ø> (ø)
lib-parquet 84.16% <ø> (ø)
lib-parquet-viewer 82.02% <ø> (ø)
lib-rdsl 87.09% <ø> (ø)
lib-snappy 91.24% <ø> (+0.46%) ⬆️
bridge-filesystem-async-aws 90.60% <ø> (ø)
bridge-filesystem-azure 89.92% <ø> (ø)
bridge-monolog-http 96.38% <ø> (ø)
symfony-http-foundation 77.10% <ø> (ø)
adapter-chartjs 86.45% <ø> (ø)
adapter-csv 89.57% <ø> (ø)
adapter-doctrine 90.14% <ø> (ø)
adapter-elasticsearch 97.19% <ø> (ø)
adapter-google-sheet 78.04% <ø> (ø)
adapter-http 59.15% <ø> (ø)
adapter-json 92.85% <ø> (ø)
adapter-logger 53.84% <ø> (ø)
adapter-meilisearch 97.80% <ø> (ø)
adapter-parquet 60.57% <ø> (ø)
adapter-text 84.44% <ø> (ø)
adapter-xml 83.15% <ø> (ø)

@norberttech norberttech merged commit 257e7f4 into flow-php:1.x Jan 4, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Define templates for Flow\ETL\PHP\Type\Type

1 participant