Simplify concat functions internals #1393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
stloyd
force-pushed
the
chore/simplify-concat
branch
from
8dee77f to
b946408
Compare
Contributor
Flow PHP - BenchmarksResults of the benchmarks from this PR are compared with the results from 1.x branch. Extractors+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| benchmark | subject | revs | its | mem_peak | mode | rstdev |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| CSVExtractorBench | bench_extract_10k | 1 | 3 | 4.766mb +0.00% | 544.652ms +0.92% | ±0.52% -65.93% |
| JsonExtractorBench | bench_extract_10k | 1 | 3 | 4.833mb +0.00% | 1.059s +0.30% | ±0.86% -11.91% |
| ParquetExtractorBench | bench_extract_10k | 1 | 3 | 86.491mb +0.00% | 901.812ms +1.09% | ±0.39% -15.27% |
| TextExtractorBench | bench_extract_10k | 1 | 3 | 4.499mb +0.01% | 33.695ms +0.40% | ±0.41% -56.64% |
| XmlExtractorBench | bench_extract_10k | 1 | 3 | 4.476mb +0.01% | 601.749ms +0.54% | ±1.39% +280.61% |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
Transformers+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark | subject | revs | its | mem_peak | mode | rstdev |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1 | 3 | 108.494mb +0.00% | 58.694ms -1.68% | ±0.70% -28.23% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark | subject | revs | its | mem_peak | mode | rstdev |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| CSVLoaderBench | bench_load_10k | 1 | 3 | 54.041mb +0.00% | 101.691ms +1.16% | ±1.07% +156.65% |
| JsonLoaderBench | bench_load_10k | 1 | 3 | 76.802mb +0.00% | 92.968ms -0.87% | ±0.30% -52.66% |
| ParquetLoaderBench | bench_load_10k | 1 | 3 | 166.989mb +0.00% | 20.682s +0.03% | ±0.18% -44.83% |
| TextLoaderBench | bench_load_10k | 1 | 3 | 17.085mb +0.00% | 31.177ms +2.01% | ±0.88% +402.17% |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| benchmark | subject | revs | its | mem_peak | mode | rstdev |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| RowsBench | bench_chunk_10_on_10k | 2 | 3 | 80.259mb +0.00% | 3.262ms +0.81% | ±1.43% +53.42% |
| RowsBench | bench_diff_left_1k_on_10k | 2 | 3 | 97.541mb +0.00% | 187.503ms -2.33% | ±0.80% -4.33% |
| RowsBench | bench_diff_right_1k_on_10k | 2 | 3 | 80.261mb +0.00% | 18.929ms -1.21% | ±0.58% -17.77% |
| RowsBench | bench_drop_1k_on_10k | 2 | 3 | 81.133mb +0.00% | 1.633ms +11.71% | ±3.21% +287.59% |
| RowsBench | bench_drop_right_1k_on_10k | 2 | 3 | 81.133mb +0.00% | 1.539ms +3.91% | ±2.03% +240.11% |
| RowsBench | bench_entries_on_10k | 2 | 3 | 79.294mb +0.00% | 3.629ms +0.98% | ±0.59% -57.18% |
| RowsBench | bench_filter_on_10k | 2 | 3 | 79.823mb +0.00% | 14.849ms -3.41% | ±1.59% +70.12% |
| RowsBench | bench_find_on_10k | 2 | 3 | 79.823mb +0.00% | 15.055ms -1.73% | ±0.77% +155.62% |
| RowsBench | bench_find_one_on_10k | 10 | 3 | 78.514mb +0.00% | 1.894μs 0.00% | ±2.53% 0.00% |
| RowsBench | bench_first_on_10k | 10 | 3 | 78.514mb +0.00% | 0.400μs 0.00% | ±0.00% 0.00% |
| RowsBench | bench_flat_map_on_1k | 2 | 3 | 86.852mb +0.00% | 12.642ms +0.65% | ±0.66% +338.82% |
| RowsBench | bench_map_on_10k | 2 | 3 | 114.199mb +0.00% | 59.048ms -2.50% | ±1.04% -28.59% |
| RowsBench | bench_merge_1k_on_10k | 2 | 3 | 80.343mb +0.00% | 1.411ms +7.23% | ±0.23% -61.81% |
| RowsBench | bench_partition_by_on_10k | 2 | 3 | 83.640mb +0.00% | 61.381ms +0.03% | ±0.39% +1042.26% |
| RowsBench | bench_remove_on_10k | 2 | 3 | 81.396mb +0.00% | 4.131ms +12.44% | ±1.43% +12.35% |
| RowsBench | bench_sort_asc_on_1k | 2 | 3 | 78.802mb +0.00% | 41.846ms -2.03% | ±0.38% -23.33% |
| RowsBench | bench_sort_by_on_1k | 2 | 3 | 78.803mb +0.00% | 42.027ms -1.43% | ±1.16% +39.54% |
| RowsBench | bench_sort_desc_on_1k | 2 | 3 | 78.802mb +0.00% | 42.487ms -2.00% | ±0.64% +91.99% |
| RowsBench | bench_sort_entries_on_1k | 2 | 3 | 80.955mb +0.00% | 8.260ms +0.68% | ±0.94% +47.81% |
| RowsBench | bench_sort_on_1k | 2 | 3 | 78.705mb +0.00% | 29.273ms +0.07% | ±0.57% -62.40% |
| RowsBench | bench_take_1k_on_10k | 10 | 3 | 78.514mb +0.00% | 13.638μs -6.19% | ±2.71% +0.72% |
| RowsBench | bench_take_right_1k_on_10k | 10 | 3 | 78.514mb +0.00% | 16.442μs +7.06% | ±1.81% -4.91% |
| RowsBench | bench_unique_on_1k | 2 | 3 | 97.542mb +0.00% | 194.525ms -0.36% | ±0.57% +19.21% |
| NativeEntryFactoryBench | bench_entry_factory | 1 | 3 | 98.650mb +0.00% | 444.356ms +0.16% | ±0.29% -45.92% |
| NativeEntryFactoryBench | bench_entry_factory | 1 | 3 | 51.480mb +0.00% | 225.193ms +0.00% | ±0.57% +61.57% |
| NativeEntryFactoryBench | bench_entry_factory | 1 | 3 | 13.652mb +0.00% | 48.183ms -3.04% | ±0.66% -58.12% |
| TypeDetectorBench | bench_type_detector | 1 | 3 | 43.784mb +0.00% | 362.907ms -0.20% | ±0.30% +11.13% |
| TypeDetectorBench | bench_type_detector | 1 | 3 | 11.594mb +0.00% | 72.599ms -0.61% | ±0.14% -75.79% |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 1.x #1393 +/- ##
==========================================
+ Coverage 82.52% 82.56% +0.03%
==========================================
Files 650 654 +4
Lines 17434 17468 +34
==========================================
+ Hits 14388 14422 +34
Misses 3046 3046
|
norberttech
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security
Description