Remove usage of References::init in Row class

[stloyd]

Change Log

Added

Fixed

Changed

• Remove usage of `References::init` in `Row` class

Removed

Deprecated

Security

---

Description

Lower code works with both string & Reference so there is no point to enforce Reference class from string values.

[github-actions]

Flow PHP - Benchmarks

^{_{Results of the benchmarks from this PR are compared with the results from 1.x branch.}}

Extractors

+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak        | mode             | rstdev          |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.773mb -0.01%  | 557.011ms -0.13% | ±0.36% -48.44%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.842mb -0.01%  | 1.064s +0.36%    | ±0.73% -31.73%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 86.490mb +0.00% | 906.981ms +0.73% | ±0.10% -90.29%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.503mb -0.01%  | 35.981ms +0.55%  | ±0.25% -62.10%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.480mb -0.01%  | 605.391ms +0.10% | ±1.66% +137.81% |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+

Transformers

+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 127.302mb -0.00% | 70.682ms +1.09% | ±1.14% +84.16% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+

Loaders

+--------------------+----------------+------+-----+------------------+------------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev         |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 63.905mb -0.00%  | 104.758ms +2.19% | ±0.75% +15.83% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 84.313mb -0.00%  | 97.575ms -1.16%  | ±0.59% -53.99% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 161.207mb +0.00% | 20.587s +0.39%   | ±0.27% +70.53% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.969mb -0.00%  | 30.886ms -0.51%  | ±0.92% -16.97% |
+--------------------+----------------+------+-----+------------------+------------------+----------------+

Building Blocks

+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark         | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 105.939mb -0.00% | 456.187ms -0.02% | ±1.47% -27.81%  |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 55.130mb -0.00%  | 230.821ms -1.41% | ±0.49% -62.03%  |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.652mb -0.00%  | 50.429ms +0.66%  | ±0.65% -46.41%  |
| RowsBench         | bench_chunk_10_on_10k      | 2    | 3   | 96.988mb -0.00%  | 3.465ms +10.75%  | ±2.55% -12.91%  |
| RowsBench         | bench_diff_left_1k_on_10k  | 2    | 3   | 114.270mb -0.00% | 189.476ms +0.19% | ±0.55% -13.48%  |
| RowsBench         | bench_diff_right_1k_on_10k | 2    | 3   | 96.990mb -0.00%  | 19.364ms +0.23%  | ±2.98% +266.45% |
| RowsBench         | bench_drop_1k_on_10k       | 2    | 3   | 97.863mb -0.00%  | 1.569ms +11.29%  | ±1.34% -43.29%  |
| RowsBench         | bench_drop_right_1k_on_10k | 2    | 3   | 97.863mb -0.00%  | 1.689ms +17.06%  | ±3.42% +309.14% |
| RowsBench         | bench_entries_on_10k       | 2    | 3   | 96.023mb -0.00%  | 4.792ms +6.69%   | ±0.62% -69.01%  |
| RowsBench         | bench_filter_on_10k        | 2    | 3   | 96.552mb -0.00%  | 16.573ms +1.13%  | ±0.20% -69.36%  |
| RowsBench         | bench_find_on_10k          | 2    | 3   | 96.552mb -0.00%  | 16.604ms +1.32%  | ±1.62% +259.08% |
| RowsBench         | bench_find_one_on_10k      | 10   | 3   | 95.244mb -0.00%  | 1.994μs +5.28%   | ±2.40% -5.08%   |
| RowsBench         | bench_first_on_10k         | 10   | 3   | 95.244mb -0.00%  | 0.400μs 0.00%    | ±0.00% 0.00%    |
| RowsBench         | bench_flat_map_on_1k       | 2    | 3   | 104.462mb -0.00% | 14.544ms +0.16%  | ±0.68% -44.32%  |
| RowsBench         | bench_map_on_10k           | 2    | 3   | 134.529mb -0.00% | 74.532ms +4.92%  | ±1.18% +244.32% |
| RowsBench         | bench_merge_1k_on_10k      | 2    | 3   | 97.072mb -0.00%  | 1.426ms +12.55%  | ±3.26% +495.14% |
| RowsBench         | bench_partition_by_on_10k  | 2    | 3   | 100.369mb -0.00% | 64.563ms +1.80%  | ±0.60% +196.51% |
| RowsBench         | bench_remove_on_10k        | 2    | 3   | 98.125mb -0.00%  | 3.912ms +4.52%   | ±3.33% +46.06%  |
| RowsBench         | bench_sort_asc_on_1k       | 2    | 3   | 95.532mb -0.00%  | 42.868ms +2.27%  | ±1.63% +924.11% |
| RowsBench         | bench_sort_by_on_1k        | 2    | 3   | 95.532mb -0.00%  | 41.711ms +0.23%  | ±0.84% +140.04% |
| RowsBench         | bench_sort_desc_on_1k      | 2    | 3   | 95.532mb -0.00%  | 41.901ms +0.43%  | ±0.62% -56.74%  |
| RowsBench         | bench_sort_entries_on_1k   | 2    | 3   | 97.684mb -0.00%  | 8.296ms -0.18%   | ±0.51% -45.51%  |
| RowsBench         | bench_sort_on_1k           | 2    | 3   | 95.434mb -0.00%  | 29.026ms -0.47%  | ±0.68% -42.13%  |
| RowsBench         | bench_take_1k_on_10k       | 10   | 3   | 95.244mb -0.00%  | 14.317μs +11.74% | ±1.52% +107.61% |
| RowsBench         | bench_take_right_1k_on_10k | 10   | 3   | 95.244mb -0.00%  | 15.312μs +0.02%  | ±0.61% -78.76%  |
| RowsBench         | bench_unique_on_1k         | 2    | 3   | 114.271mb -0.00% | 191.642ms -0.77% | ±0.04% -91.74%  |
| TypeDetectorBench | bench_type_detector        | 1    | 3   | 43.777mb +0.00%  | 369.681ms +3.21% | ±1.25% +286.64% |
| TypeDetectorBench | bench_type_detector        | 1    | 3   | 11.587mb +0.00%  | 71.987ms -0.72%  | ±1.24% -6.91%   |
+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.54%. Comparing base (10a0c52) to head (23a7e23).
Report is 2 commits behind head on 1.x.

Additional details and impacted files

@@           Coverage Diff           @@
##              1.x    #1407   +/-   ##
=======================================
  Coverage   82.54%   82.54%           
=======================================
  Files         654      654           
  Lines       17564    17564           
=======================================
  Hits        14498    14498           
  Misses       3066     3066           

Components	Coverage Δ
etl	85.81% <100.00%> (ø)
cli	85.17% <ø> (ø)
lib-array-dot	94.53% <ø> (ø)
lib-azure-sdk	62.56% <ø> (ø)
lib-doctrine-dbal-bulk	97.36% <ø> (ø)
lib-filesystem	76.23% <ø> (ø)
lib-parquet	84.57% <ø> (ø)
lib-parquet-viewer	82.02% <ø> (ø)
lib-rdsl	87.09% <ø> (ø)
lib-snappy	91.16% <ø> (ø)
bridge-filesystem-async-aws	90.38% <ø> (ø)
bridge-filesystem-azure	89.92% <ø> (ø)
bridge-monolog-http	96.38% <ø> (ø)
symfony-http-foundation	77.10% <ø> (ø)
adapter-chartjs	86.45% <ø> (ø)
adapter-csv	89.49% <ø> (ø)
adapter-doctrine	90.14% <ø> (ø)
adapter-elasticsearch	97.19% <ø> (ø)
adapter-google-sheet	78.04% <ø> (ø)
adapter-http	59.15% <ø> (ø)
adapter-json	92.85% <ø> (ø)
adapter-logger	53.84% <ø> (ø)
adapter-meilisearch	97.75% <ø> (ø)
adapter-parquet	59.88% <ø> (ø)
adapter-text	84.44% <ø> (ø)
adapter-xml	83.15% <ø> (ø)

[norberttech]

Makes sense!