Flow to Dbal schema converter #1429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Flow PHP - BenchmarksResults of the benchmarks from this PR are compared with the results from 1.x branch. Extractors+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| benchmark | subject | revs | its | mem_peak | mode | rstdev |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| CSVExtractorBench | bench_extract_10k | 1 | 3 | 4.783mb +0.07% | 555.854ms +0.38% | ±0.59% +32.12% |
| JsonExtractorBench | bench_extract_10k | 1 | 3 | 4.857mb +0.07% | 1.062s +0.70% | ±0.27% -57.53% |
| ParquetExtractorBench | bench_extract_10k | 1 | 3 | 86.298mb +0.00% | 927.067ms +4.15% | ±1.30% +375.48% |
| TextExtractorBench | bench_extract_10k | 1 | 3 | 4.514mb +0.07% | 35.439ms -0.66% | ±0.42% -39.23% |
| XmlExtractorBench | bench_extract_10k | 1 | 3 | 4.488mb +0.07% | 598.516ms +0.00% | ±0.60% +39.78% |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
Transformers+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark | subject | revs | its | mem_peak | mode | rstdev |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1 | 3 | 127.310mb +0.00% | 71.842ms +0.91% | ±0.50% -38.17% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark | subject | revs | its | mem_peak | mode | rstdev |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| CSVLoaderBench | bench_load_10k | 1 | 3 | 63.981mb +0.01% | 101.828ms +0.09% | ±1.12% +15.91% |
| JsonLoaderBench | bench_load_10k | 1 | 3 | 84.328mb +0.00% | 96.849ms -0.12% | ±1.15% +410.58% |
| ParquetLoaderBench | bench_load_10k | 1 | 3 | 161.169mb +0.00% | 20.871s +1.08% | ±0.32% +82.21% |
| TextLoaderBench | bench_load_10k | 1 | 3 | 17.980mb +0.02% | 31.308ms +1.36% | ±1.03% +30.28% |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks+-------------------+----------------------------+------+-----+------------------+------------------+------------------+
| benchmark | subject | revs | its | mem_peak | mode | rstdev |
+-------------------+----------------------------+------+-----+------------------+------------------+------------------+
| EntryFactoryBench | bench_entry_factory | 1 | 3 | 105.953mb +0.00% | 463.719ms +3.89% | ±1.53% +50.04% |
| EntryFactoryBench | bench_entry_factory | 1 | 3 | 55.143mb +0.01% | 234.243ms +2.71% | ±1.48% +54.82% |
| EntryFactoryBench | bench_entry_factory | 1 | 3 | 14.665mb +0.02% | 51.414ms +1.50% | ±0.85% +3771.38% |
| RowsBench | bench_chunk_10_on_10k | 2 | 3 | 96.996mb +0.00% | 4.119ms +29.27% | ±3.62% +113.64% |
| RowsBench | bench_diff_left_1k_on_10k | 2 | 3 | 114.278mb +0.00% | 184.743ms -2.79% | ±1.22% -47.94% |
| RowsBench | bench_diff_right_1k_on_10k | 2 | 3 | 96.998mb +0.00% | 18.913ms -1.26% | ±0.75% +372.01% |
| RowsBench | bench_drop_1k_on_10k | 2 | 3 | 97.871mb +0.00% | 2.006ms +41.69% | ±2.51% -15.84% |
| RowsBench | bench_drop_right_1k_on_10k | 2 | 3 | 97.871mb +0.00% | 2.012ms +36.17% | ±1.49% -46.92% |
| RowsBench | bench_entries_on_10k | 2 | 3 | 96.032mb +0.00% | 5.242ms +17.04% | ±1.56% -51.21% |
| RowsBench | bench_filter_on_10k | 2 | 3 | 96.561mb +0.00% | 16.976ms +2.70% | ±1.46% -35.27% |
| RowsBench | bench_find_on_10k | 2 | 3 | 96.561mb +0.00% | 16.920ms +4.76% | ±0.40% -58.32% |
| RowsBench | bench_find_one_on_10k | 10 | 3 | 95.252mb +0.00% | 2.000μs +10.74% | ±0.00% -100.00% |
| RowsBench | bench_first_on_10k | 10 | 3 | 95.252mb +0.00% | 0.400μs 0.00% | ±0.00% 0.00% |
| RowsBench | bench_flat_map_on_1k | 2 | 3 | 104.470mb +0.00% | 15.549ms +6.46% | ±1.43% +126.13% |
| RowsBench | bench_map_on_10k | 2 | 3 | 134.537mb +0.00% | 72.539ms +2.30% | ±0.62% -71.73% |
| RowsBench | bench_merge_1k_on_10k | 2 | 3 | 97.080mb +0.00% | 1.954ms +52.50% | ±2.35% -9.72% |
| RowsBench | bench_partition_by_on_10k | 2 | 3 | 100.378mb +0.00% | 65.439ms +3.94% | ±0.21% -53.65% |
| RowsBench | bench_remove_on_10k | 2 | 3 | 98.133mb +0.00% | 4.473ms +23.26% | ±1.81% -0.73% |
| RowsBench | bench_sort_asc_on_1k | 2 | 3 | 95.540mb +0.00% | 44.945ms +5.35% | ±1.16% +687.92% |
| RowsBench | bench_sort_by_on_1k | 2 | 3 | 95.540mb +0.00% | 44.960ms +5.12% | ±1.50% +9.10% |
| RowsBench | bench_sort_desc_on_1k | 2 | 3 | 95.540mb +0.00% | 46.485ms +10.06% | ±3.05% +219.24% |
| RowsBench | bench_sort_entries_on_1k | 2 | 3 | 97.692mb +0.00% | 8.614ms +2.76% | ±2.52% +253.71% |
| RowsBench | bench_sort_on_1k | 2 | 3 | 95.442mb +0.00% | 31.187ms +5.89% | ±1.39% +183.20% |
| RowsBench | bench_take_1k_on_10k | 10 | 3 | 95.252mb +0.00% | 14.582μs +10.95% | ±0.98% -60.79% |
| RowsBench | bench_take_right_1k_on_10k | 10 | 3 | 95.252mb +0.00% | 17.333μs +8.17% | ±2.35% -29.48% |
| RowsBench | bench_unique_on_1k | 2 | 3 | 114.279mb +0.00% | 190.043ms -0.85% | ±2.56% +58.55% |
| TypeDetectorBench | bench_type_detector | 1 | 3 | 43.788mb +0.01% | 358.782ms +0.02% | ±0.08% -75.28% |
| TypeDetectorBench | bench_type_detector | 1 | 3 | 11.598mb +0.03% | 73.060ms +0.89% | ±0.92% +21.67% |
+-------------------+----------------------------+------+-----+------------------+------------------+------------------+
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 1.x #1429 +/- ##
==========================================
+ Coverage 82.88% 82.91% +0.02%
==========================================
Files 655 657 +2
Lines 17521 17629 +108
==========================================
+ Hits 14523 14617 +94
- Misses 2998 3012 +14
|
stloyd
approved these changes
Jan 30, 2025
| # Upgrade Guide | ||
|
|
||
| This document provides guidelines for upgrading between versions of Flow PHP. | ||
| This document provides guidelines for upgrading between versions of Flow PHP. |
Member
There was a problem hiding this comment.
I would leave that file main folder and link in it to that new docs page, so if anyone looks at repo first, he will not be lost.
Member
Author
There was a problem hiding this comment.
I'm actually slowly trying to move away everything to website and turn it into main documentation source, thats why I'm fixing links.
Ideally I would like to keep just very minimalistic README.md on the root and put links from it to all important places like UPGRADING or CONTRIBUTING
My goal is to make the docs more interactive, with some cross referencing and mentions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security
Description
Resolves: #1428