Read scale from float type in Dbal Schema Converter

[norberttech]

Change Log

Added

Fixed

• Read scale from float type in Dbal Schema Converter

Changed

• Indexes and primary key are added to directly the table instead of being returned

Removed

Deprecated

Security

---

Description

Reference #1428

[github-actions]

Flow PHP - Benchmarks

^{_{Results of the benchmarks from this PR are compared with the results from 1.x branch.}}

Extractors

+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak        | mode             | rstdev          |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.786mb +0.01%  | 558.819ms +0.45% | ±0.56% +247.44% |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.860mb +0.01%  | 1.068s +0.26%    | ±0.64% +141.29% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 86.300mb +0.00% | 923.475ms +2.65% | ±0.28% +19.41%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.517mb +0.01%  | 36.462ms +2.40%  | ±0.80% -3.57%   |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.491mb +0.01%  | 607.155ms +0.15% | ±0.07% -91.22%  |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+

Transformers

+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev          |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 127.313mb +0.00% | 74.646ms +2.63% | ±1.98% +149.78% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+

Loaders

+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 63.984mb +0.00%  | 107.837ms +4.70% | ±2.23% +183.11% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 84.331mb +0.00%  | 102.873ms +5.56% | ±1.60% -47.82%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 161.172mb +0.00% | 20.896s +1.52%   | ±0.28% -78.57%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.983mb +0.00%  | 31.937ms +3.75%  | ±0.31% -73.91%  |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+

Building Blocks

+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark         | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 105.956mb +0.00% | 461.728ms +2.29% | ±0.51% -12.65%  |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 55.146mb +0.00%  | 233.737ms +0.92% | ±1.07% +123.52% |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.668mb +0.00%  | 52.256ms +4.24%  | ±0.67% -55.37%  |
| RowsBench         | bench_chunk_10_on_10k      | 2    | 3   | 96.999mb +0.00%  | 4.332ms +38.49%  | ±0.27% -82.67%  |
| RowsBench         | bench_diff_left_1k_on_10k  | 2    | 3   | 114.281mb +0.00% | 186.383ms +0.80% | ±0.57% +78.85%  |
| RowsBench         | bench_diff_right_1k_on_10k | 2    | 3   | 97.001mb +0.00%  | 19.032ms +0.87%  | ±1.32% +83.80%  |
| RowsBench         | bench_drop_1k_on_10k       | 2    | 3   | 97.874mb +0.00%  | 2.046ms +39.92%  | ±1.84% -26.48%  |
| RowsBench         | bench_drop_right_1k_on_10k | 2    | 3   | 97.874mb +0.00%  | 2.090ms +38.31%  | ±1.10% +45.58%  |
| RowsBench         | bench_entries_on_10k       | 2    | 3   | 96.035mb +0.00%  | 5.965ms +26.41%  | ±1.27% -54.75%  |
| RowsBench         | bench_filter_on_10k        | 2    | 3   | 96.564mb +0.00%  | 17.112ms +3.87%  | ±0.84% -68.79%  |
| RowsBench         | bench_find_on_10k          | 2    | 3   | 96.564mb +0.00%  | 17.130ms +2.10%  | ±2.01% +71.16%  |
| RowsBench         | bench_find_one_on_10k      | 10   | 3   | 95.255mb +0.00%  | 2.300μs +28.21%  | ±0.00% -100.00% |
| RowsBench         | bench_first_on_10k         | 10   | 3   | 95.255mb +0.00%  | 0.500μs +25.00%  | ±0.00% -100.00% |
| RowsBench         | bench_flat_map_on_1k       | 2    | 3   | 104.473mb +0.00% | 15.635ms +7.61%  | ±1.43% +138.54% |
| RowsBench         | bench_map_on_10k           | 2    | 3   | 134.540mb +0.00% | 78.927ms +9.44%  | ±3.32% +64.49%  |
| RowsBench         | bench_merge_1k_on_10k      | 2    | 3   | 97.083mb +0.00%  | 2.499ms +61.96%  | ±1.70% -14.21%  |
| RowsBench         | bench_partition_by_on_10k  | 2    | 3   | 100.381mb +0.00% | 72.632ms +10.47% | ±0.56% -22.65%  |
| RowsBench         | bench_remove_on_10k        | 2    | 3   | 98.136mb +0.00%  | 5.254ms +39.80%  | ±3.51% +558.83% |
| RowsBench         | bench_sort_asc_on_1k       | 2    | 3   | 95.543mb +0.00%  | 48.725ms +12.46% | ±0.40% -69.19%  |
| RowsBench         | bench_sort_by_on_1k        | 2    | 3   | 95.543mb +0.00%  | 48.214ms +9.36%  | ±1.47% +50.25%  |
| RowsBench         | bench_sort_desc_on_1k      | 2    | 3   | 95.543mb +0.00%  | 46.708ms +5.86%  | ±1.87% +406.41% |
| RowsBench         | bench_sort_entries_on_1k   | 2    | 3   | 97.695mb +0.00%  | 9.796ms +17.58%  | ±3.05% +152.00% |
| RowsBench         | bench_sort_on_1k           | 2    | 3   | 95.445mb +0.00%  | 30.317ms +3.57%  | ±0.96% -57.38%  |
| RowsBench         | bench_take_1k_on_10k       | 10   | 3   | 95.255mb +0.00%  | 18.381μs +28.16% | ±3.06% +47.43%  |
| RowsBench         | bench_take_right_1k_on_10k | 10   | 3   | 95.255mb +0.00%  | 20.333μs +28.69% | ±2.01% -2.86%   |
| RowsBench         | bench_unique_on_1k         | 2    | 3   | 114.282mb +0.00% | 190.267ms +1.49% | ±0.87% +102.26% |
| TypeDetectorBench | bench_type_detector        | 1    | 3   | 43.791mb +0.00%  | 362.465ms -0.61% | ±0.81% +370.01% |
| TypeDetectorBench | bench_type_detector        | 1    | 3   | 11.601mb +0.00%  | 73.434ms +0.55%  | ±2.12% +252.64% |
+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.91%. Comparing base (03468f9) to head (35f8b62).
Report is 2 commits behind head on 1.x.

Additional details and impacted files

@@           Coverage Diff           @@
##              1.x    #1435   +/-   ##
=======================================
  Coverage   82.90%   82.91%           
=======================================
  Files         657      657           
  Lines       17629    17631    +2     
=======================================
+ Hits        14616    14618    +2     
  Misses       3013     3013           

Components	Coverage Δ
etl	85.75% <ø> (ø)
cli	85.17% <ø> (ø)
lib-array-dot	94.53% <ø> (ø)
lib-azure-sdk	62.56% <ø> (ø)
lib-doctrine-dbal-bulk	97.36% <ø> (ø)
lib-filesystem	76.23% <ø> (ø)
lib-parquet	84.33% <ø> (ø)
lib-parquet-viewer	82.02% <ø> (ø)
lib-rdsl	87.09% <ø> (ø)
lib-snappy	90.69% <ø> (ø)
bridge-filesystem-async-aws	90.38% <ø> (ø)
bridge-filesystem-azure	89.92% <ø> (ø)
bridge-monolog-http	96.38% <ø> (ø)
symfony-http-foundation	77.10% <ø> (ø)
adapter-chartjs	86.45% <ø> (ø)
adapter-csv	89.49% <ø> (ø)
adapter-doctrine	88.54% <100.00%> (+0.07%)	⬆️
adapter-elasticsearch	97.19% <ø> (ø)
adapter-google-sheet	78.04% <ø> (ø)
adapter-http	59.15% <ø> (ø)
adapter-json	92.85% <ø> (ø)
adapter-logger	53.84% <ø> (ø)
adapter-meilisearch	97.75% <ø> (ø)
adapter-parquet	80.85% <ø> (ø)
adapter-text	84.44% <ø> (ø)
adapter-xml	83.15% <ø> (ø)