Skip to content

Conversation

@f-lapinski
Copy link
Contributor

@f-lapinski f-lapinski commented Feb 5, 2025

Change Log

Added

  • string folded function

Fixed

Changed

Removed

Deprecated

Security


Description

Ref: #1316

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak        | mode             | rstdev          |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.797mb +0.01%  | 554.579ms +0.48% | ±0.71% +147.72% |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.870mb +0.01%  | 1.058s -0.52%    | ±0.19% -52.64%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 86.311mb +0.00% | 895.974ms +1.47% | ±0.41% +217.38% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.528mb +0.02%  | 35.526ms -1.05%  | ±0.09% -83.86%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.502mb +0.02%  | 601.439ms -1.16% | ±0.20% -3.09%   |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 127.324mb +0.00% | 71.546ms +1.22% | ±0.93% +52.04% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev         |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 63.995mb +0.00%  | 102.295ms -0.37% | ±1.15% +38.31% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 84.342mb +0.00%  | 99.521ms +1.21%  | ±0.85% -36.49% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 161.182mb +0.00% | 20.633s +0.53%   | ±0.56% -26.12% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.994mb +0.00%  | 30.634ms +0.99%  | ±0.77% +19.17% |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
Building Blocks
+-------------------+----------------------------+------+-----+------------------+------------------+------------------+
| benchmark         | subject                    | revs | its | mem_peak         | mode             | rstdev           |
+-------------------+----------------------------+------+-----+------------------+------------------+------------------+
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 105.967mb +0.00% | 469.174ms +1.24% | ±2.56% +41.36%   |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 55.157mb +0.00%  | 230.069ms -0.31% | ±1.10% +181.32%  |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.679mb +0.00%  | 50.236ms -0.10%  | ±1.61% +38.66%   |
| RowsBench         | bench_chunk_10_on_10k      | 2    | 3   | 97.010mb +0.00%  | 3.126ms +0.95%   | ±0.29% -89.20%   |
| RowsBench         | bench_diff_left_1k_on_10k  | 2    | 3   | 114.292mb +0.00% | 187.667ms +2.25% | ±0.35% -49.97%   |
| RowsBench         | bench_diff_right_1k_on_10k | 2    | 3   | 97.012mb +0.00%  | 18.723ms +1.01%  | ±0.14% -61.21%   |
| RowsBench         | bench_drop_1k_on_10k       | 2    | 3   | 97.885mb +0.00%  | 1.444ms -0.83%   | ±2.88% +1981.17% |
| RowsBench         | bench_drop_right_1k_on_10k | 2    | 3   | 97.885mb +0.00%  | 1.462ms +0.97%   | ±1.43% +36.23%   |
| RowsBench         | bench_entries_on_10k       | 2    | 3   | 96.046mb +0.00%  | 4.425ms -7.80%   | ±2.47% +9.11%    |
| RowsBench         | bench_filter_on_10k        | 2    | 3   | 96.575mb +0.00%  | 16.530ms +0.42%  | ±2.84% +98.83%   |
| RowsBench         | bench_find_on_10k          | 2    | 3   | 96.575mb +0.00%  | 16.458ms +0.83%  | ±1.11% +9.67%    |
| RowsBench         | bench_find_one_on_10k      | 10   | 3   | 95.266mb +0.00%  | 1.806μs 0.00%    | ±2.57% 0.00%     |
| RowsBench         | bench_first_on_10k         | 10   | 3   | 95.266mb +0.00%  | 0.400μs +100.00% | ±0.00% 0.00%     |
| RowsBench         | bench_flat_map_on_1k       | 2    | 3   | 104.484mb +0.00% | 14.634ms -2.44%  | ±1.29% -38.99%   |
| RowsBench         | bench_map_on_10k           | 2    | 3   | 134.551mb +0.00% | 69.711ms -2.60%  | ±1.67% +99.04%   |
| RowsBench         | bench_merge_1k_on_10k      | 2    | 3   | 97.094mb +0.00%  | 1.293ms +2.13%   | ±1.93% -35.24%   |
| RowsBench         | bench_partition_by_on_10k  | 2    | 3   | 100.392mb +0.00% | 64.526ms +2.29%  | ±1.73% +6.35%    |
| RowsBench         | bench_remove_on_10k        | 2    | 3   | 98.147mb +0.00%  | 3.933ms +5.50%   | ±0.83% -60.55%   |
| RowsBench         | bench_sort_asc_on_1k       | 2    | 3   | 95.554mb +0.00%  | 42.495ms +1.15%  | ±0.33% -9.60%    |
| RowsBench         | bench_sort_by_on_1k        | 2    | 3   | 95.554mb +0.00%  | 42.494ms +1.14%  | ±0.95% -28.43%   |
| RowsBench         | bench_sort_desc_on_1k      | 2    | 3   | 95.554mb +0.00%  | 41.627ms -1.01%  | ±1.08% -26.46%   |
| RowsBench         | bench_sort_entries_on_1k   | 2    | 3   | 97.706mb +0.00%  | 8.164ms -1.57%   | ±2.61% +598.01%  |
| RowsBench         | bench_sort_on_1k           | 2    | 3   | 95.456mb +0.00%  | 29.598ms -0.31%  | ±0.18% -85.72%   |
| RowsBench         | bench_take_1k_on_10k       | 10   | 3   | 95.266mb +0.00%  | 13.066μs +1.45%  | ±1.56% +19.36%   |
| RowsBench         | bench_take_right_1k_on_10k | 10   | 3   | 95.266mb +0.00%  | 15.112μs -2.22%  | ±0.62% -77.00%   |
| RowsBench         | bench_unique_on_1k         | 2    | 3   | 114.293mb +0.00% | 190.742ms +1.13% | ±0.67% +105.70%  |
| TypeDetectorBench | bench_type_detector        | 1    | 3   | 43.802mb +0.00%  | 362.380ms +0.69% | ±0.54% +31.63%   |
| TypeDetectorBench | bench_type_detector        | 1    | 3   | 11.612mb +0.01%  | 72.535ms -0.60%  | ±0.33% +20.97%   |
+-------------------+----------------------------+------+-----+------------------+------------------+------------------+

@codecov
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.02%. Comparing base (d823813) to head (8e5227f).
Report is 2 commits behind head on 1.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              1.x    #1449   +/-   ##
=======================================
  Coverage   83.02%   83.02%           
=======================================
  Files         661      662    +1     
  Lines       17805    17816   +11     
=======================================
+ Hits        14782    14792   +10     
- Misses       3023     3024    +1     
Components Coverage Δ
etl 85.73% <72.72%> (-0.02%) ⬇️
cli 86.73% <ø> (ø)
lib-array-dot 94.53% <ø> (ø)
lib-azure-sdk 62.56% <ø> (ø)
lib-doctrine-dbal-bulk 97.36% <ø> (ø)
lib-filesystem 76.75% <ø> (ø)
lib-parquet 84.33% <ø> (ø)
lib-parquet-viewer 82.02% <ø> (ø)
lib-rdsl 87.09% <ø> (ø)
lib-snappy 91.62% <ø> (+0.93%) ⬆️
bridge-filesystem-async-aws 90.38% <ø> (ø)
bridge-filesystem-azure 89.92% <ø> (ø)
bridge-monolog-http 96.38% <ø> (ø)
symfony-http-foundation 77.10% <ø> (ø)
adapter-chartjs 86.45% <ø> (ø)
adapter-csv 89.49% <ø> (ø)
adapter-doctrine 88.54% <ø> (ø)
adapter-elasticsearch 97.19% <ø> (ø)
adapter-google-sheet 78.04% <ø> (ø)
adapter-http 59.15% <ø> (ø)
adapter-json 90.81% <ø> (ø)
adapter-logger 53.84% <ø> (ø)
adapter-meilisearch 97.75% <ø> (ø)
adapter-parquet 80.85% <ø> (ø)
adapter-text 84.44% <ø> (ø)
adapter-xml 83.15% <ø> (ø)

@norberttech norberttech merged commit 75fbfea into flow-php:1.x Feb 6, 2025
21 of 22 checks passed
@norberttech
Copy link
Member

@f-lapinski congratz on your first contribution 🥳

@f-lapinski f-lapinski deleted the integration/symfony-string-folded branch February 7, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants