Skip to content

Conversation

@norberttech
Copy link
Member

@norberttech norberttech commented Feb 13, 2025

Change Log

Added

Fixed

Changed

  • Allow to pass single type to is_type() method
  • Allow using concat ws on collections

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak        | mode             | rstdev          |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.800mb +0.01%  | 550.410ms -0.56% | ±0.43% -81.07%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.873mb +0.00%  | 1.060s -0.75%    | ±1.55% +149.49% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 86.318mb +0.00% | 885.328ms -0.36% | ±0.48% +12.04%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.530mb +0.01%  | 35.382ms +0.10%  | ±0.09% -84.50%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.505mb +0.01%  | 609.080ms +0.08% | ±2.89% +75.23%  |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev          |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 127.327mb +0.00% | 68.359ms -2.84% | ±1.26% +113.44% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev         |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 64.000mb +0.00%  | 101.488ms -3.19% | ±0.37% -25.68% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 84.346mb +0.00%  | 97.366ms -4.41%  | ±0.76% -18.43% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 161.189mb +0.00% | 20.457s -0.98%   | ±0.25% -21.34% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.997mb +0.00%  | 29.140ms -5.89%  | ±0.70% +85.38% |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
Building Blocks
+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark         | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 105.970mb +0.00% | 460.149ms +2.22% | ±0.81% +33.30%  |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 55.160mb +0.00%  | 227.720ms -2.09% | ±0.36% -66.92%  |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.682mb +0.00%  | 49.983ms -1.87%  | ±0.86% -39.18%  |
| TypeDetectorBench | bench_type_detector        | 1    | 3   | 43.804mb +0.00%  | 364.389ms +1.12% | ±0.82% -29.40%  |
| TypeDetectorBench | bench_type_detector        | 1    | 3   | 11.614mb +0.00%  | 72.718ms -0.10%  | ±0.49% -30.69%  |
| RowsBench         | bench_chunk_10_on_10k      | 2    | 3   | 97.013mb +0.00%  | 3.095ms -1.70%   | ±0.61% -73.82%  |
| RowsBench         | bench_diff_left_1k_on_10k  | 2    | 3   | 114.298mb +0.00% | 189.034ms +2.00% | ±0.39% -6.93%   |
| RowsBench         | bench_diff_right_1k_on_10k | 2    | 3   | 97.018mb +0.00%  | 19.003ms +0.06%  | ±0.83% +33.15%  |
| RowsBench         | bench_drop_1k_on_10k       | 2    | 3   | 97.888mb +0.00%  | 1.391ms -7.51%   | ±1.57% +201.37% |
| RowsBench         | bench_drop_right_1k_on_10k | 2    | 3   | 97.888mb +0.00%  | 1.404ms -7.02%   | ±0.59% -77.66%  |
| RowsBench         | bench_entries_on_10k       | 2    | 3   | 96.049mb +0.00%  | 3.956ms -8.88%   | ±0.71% -18.93%  |
| RowsBench         | bench_filter_on_10k        | 2    | 3   | 96.578mb +0.00%  | 16.391ms -3.58%  | ±1.13% -43.10%  |
| RowsBench         | bench_find_on_10k          | 2    | 3   | 96.578mb +0.00%  | 16.189ms -2.36%  | ±1.27% +32.27%  |
| RowsBench         | bench_find_one_on_10k      | 10   | 3   | 95.269mb +0.00%  | 1.700μs -10.81%  | ±0.00% -100.00% |
| RowsBench         | bench_first_on_10k         | 10   | 3   | 95.269mb +0.00%  | 0.400μs 0.00%    | ±0.00% 0.00%    |
| RowsBench         | bench_flat_map_on_1k       | 2    | 3   | 104.487mb +0.00% | 14.246ms -0.99%  | ±1.10% +113.24% |
| RowsBench         | bench_map_on_10k           | 2    | 3   | 134.554mb +0.00% | 69.273ms -5.69%  | ±0.95% +13.23%  |
| RowsBench         | bench_merge_1k_on_10k      | 2    | 3   | 97.097mb +0.00%  | 1.229ms -30.68%  | ±0.40% -82.24%  |
| RowsBench         | bench_partition_by_on_10k  | 2    | 3   | 100.397mb +0.00% | 62.519ms -4.15%  | ±0.48% -48.57%  |
| RowsBench         | bench_remove_on_10k        | 2    | 3   | 98.150mb +0.00%  | 3.666ms -13.69%  | ±0.39% -85.40%  |
| RowsBench         | bench_sort_asc_on_1k       | 2    | 3   | 95.560mb +0.00%  | 44.654ms +4.04%  | ±1.85% -19.12%  |
| RowsBench         | bench_sort_by_on_1k        | 2    | 3   | 95.560mb +0.00%  | 43.835ms +1.14%  | ±0.32% -81.20%  |
| RowsBench         | bench_sort_desc_on_1k      | 2    | 3   | 95.560mb +0.00%  | 42.703ms -0.06%  | ±0.41% -76.29%  |
| RowsBench         | bench_sort_entries_on_1k   | 2    | 3   | 97.709mb +0.00%  | 8.217ms -2.63%   | ±0.80% -38.63%  |
| RowsBench         | bench_sort_on_1k           | 2    | 3   | 95.459mb +0.00%  | 29.429ms -2.13%  | ±0.63% -48.20%  |
| RowsBench         | bench_take_1k_on_10k       | 10   | 3   | 95.269mb +0.00%  | 12.966μs -9.40%  | ±3.27% +76.67%  |
| RowsBench         | bench_take_right_1k_on_10k | 10   | 3   | 95.269mb +0.00%  | 15.320μs -3.40%  | ±1.12% -47.37%  |
| RowsBench         | bench_unique_on_1k         | 2    | 3   | 114.299mb +0.00% | 190.420ms -0.08% | ±0.44% +393.66% |
+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@codecov
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.08%. Comparing base (53d7c61) to head (9574436).
Report is 2 commits behind head on 1.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              1.x    #1476      +/-   ##
==========================================
+ Coverage   83.06%   83.08%   +0.01%     
==========================================
  Files         665      665              
  Lines       17884    17887       +3     
==========================================
+ Hits        14856    14861       +5     
+ Misses       3028     3026       -2     
Components Coverage Δ
etl 85.83% <100.00%> (+0.03%) ⬆️
cli 86.73% <ø> (ø)
lib-array-dot 94.53% <ø> (ø)
lib-azure-sdk 62.56% <ø> (ø)
lib-doctrine-dbal-bulk 97.43% <ø> (ø)
lib-filesystem 76.75% <ø> (ø)
lib-parquet 84.33% <ø> (ø)
lib-parquet-viewer 82.02% <ø> (ø)
lib-rdsl 87.09% <ø> (ø)
lib-snappy 91.16% <ø> (ø)
bridge-filesystem-async-aws 90.38% <ø> (ø)
bridge-filesystem-azure 89.92% <ø> (ø)
bridge-monolog-http 96.38% <ø> (ø)
symfony-http-foundation 77.10% <ø> (ø)
adapter-chartjs 86.45% <ø> (ø)
adapter-csv 89.57% <ø> (ø)
adapter-doctrine 88.68% <ø> (ø)
adapter-elasticsearch 97.19% <ø> (ø)
adapter-google-sheet 78.04% <ø> (ø)
adapter-http 59.15% <ø> (ø)
adapter-json 90.62% <ø> (ø)
adapter-logger 53.84% <ø> (ø)
adapter-meilisearch 97.75% <ø> (ø)
adapter-parquet 80.85% <ø> (ø)
adapter-text 84.44% <ø> (ø)
adapter-xml 83.15% <ø> (ø)

@norberttech norberttech merged commit d14101d into flow-php:1.x Feb 13, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant