Skip to content

Conversation

@norberttech
Copy link
Member

Change Log

Added

Fixed

Changed

  • type_uuid no longer recognize symfony/ramsey objects as uuid
  • EntryFactory decorates casting exception with entry name
  • EntryFactory::create is now reusing more logic from EntryFactory::createAt
  • Updated version of elasticsearch in tests

Removed

Deprecated

Security


Description

Resolves: #1532

@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2025

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+-----------------+-------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak        | mode              | rstdev          |
+-----------------------+-------------------+------+-----+-----------------+-------------------+-----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.870mb -0.02%  | 615.174ms +10.32% | ±0.41% -61.37%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.947mb -0.09%  | 1.128s +4.68%     | ±0.95% -5.53%   |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 86.465mb -0.01% | 894.168ms -1.97%  | ±0.56% -40.14%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.600mb -0.10%  | 38.484ms +3.83%   | ±1.03% +4.23%   |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.574mb -0.10%  | 606.294ms +0.51%  | ±2.34% +103.02% |
+-----------------------+-------------------+------+-----+-----------------+-------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 127.396mb -0.00% | 69.621ms -5.84% | ±0.29% -70.78% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+-----------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode            | rstdev          |
+--------------------+----------------+------+-----+------------------+-----------------+-----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 64.069mb -0.05%  | 99.867ms -4.10% | ±2.02% +134.13% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 84.420mb -0.01%  | 93.412ms -3.06% | ±1.00% +91.67%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 161.271mb -0.00% | 20.668s -0.83%  | ±0.68% +293.66% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 18.132mb -0.03%  | 30.192ms -3.60% | ±1.77% +753.56% |
+--------------------+----------------+------+-----+------------------+-----------------+-----------------+
Building Blocks
+-------------------+----------------------------+------+-----+------------------+-------------------+------------------+
| benchmark         | subject                    | revs | its | mem_peak         | mode              | rstdev           |
+-------------------+----------------------------+------+-----+------------------+-------------------+------------------+
| TypeDetectorBench | bench_type_detector        | 1    | 3   | 43.912mb +0.00%  | 368.408ms -0.23%  | ±1.21% +1103.12% |
| TypeDetectorBench | bench_type_detector        | 1    | 3   | 11.722mb +0.00%  | 74.870ms +1.77%   | ±1.94% +166.69%  |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 106.018mb -0.00% | 520.226ms +12.19% | ±0.82% +40.41%   |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 55.209mb -0.00%  | 265.475ms +13.18% | ±0.10% -42.18%   |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.731mb -0.01%  | 56.634ms +9.89%   | ±0.67% -41.14%   |
| RowsBench         | bench_chunk_10_on_10k      | 2    | 3   | 97.059mb -0.00%  | 3.108ms -20.16%   | ±0.31% -86.37%   |
| RowsBench         | bench_diff_left_1k_on_10k  | 2    | 3   | 114.349mb -0.00% | 184.052ms -2.02%  | ±0.65% +109.91%  |
| RowsBench         | bench_diff_right_1k_on_10k | 2    | 3   | 97.069mb -0.00%  | 18.442ms -0.83%   | ±0.75% +473.86%  |
| RowsBench         | bench_drop_1k_on_10k       | 2    | 3   | 97.933mb -0.00%  | 1.415ms -30.30%   | ±1.37% -28.19%   |
| RowsBench         | bench_drop_right_1k_on_10k | 2    | 3   | 97.933mb -0.00%  | 1.435ms -24.00%   | ±1.09% -61.02%   |
| RowsBench         | bench_entries_on_10k       | 2    | 3   | 96.094mb -0.00%  | 4.040ms -18.16%   | ±0.99% -53.29%   |
| RowsBench         | bench_filter_on_10k        | 2    | 3   | 96.623mb -0.00%  | 15.971ms -5.40%   | ±0.32% -70.03%   |
| RowsBench         | bench_find_on_10k          | 2    | 3   | 96.623mb -0.00%  | 15.947ms -7.59%   | ±0.64% -61.72%   |
| RowsBench         | bench_find_one_on_10k      | 10   | 3   | 95.314mb -0.00%  | 1.700μs -18.81%   | ±0.00% -100.00%  |
| RowsBench         | bench_first_on_10k         | 10   | 3   | 95.314mb -0.00%  | 0.400μs 0.00%     | ±0.00% 0.00%     |
| RowsBench         | bench_flat_map_on_1k       | 2    | 3   | 104.533mb -0.00% | 14.685ms -4.97%   | ±1.20% -35.44%   |
| RowsBench         | bench_map_on_10k           | 2    | 3   | 134.600mb -0.00% | 71.213ms -7.73%   | ±1.36% -48.66%   |
| RowsBench         | bench_merge_1k_on_10k      | 2    | 3   | 97.143mb -0.00%  | 1.233ms -32.05%   | ±1.74% -24.71%   |
| RowsBench         | bench_partition_by_on_10k  | 2    | 3   | 100.513mb -0.00% | 62.218ms -5.01%   | ±0.89% +85.89%   |
| RowsBench         | bench_remove_on_10k        | 2    | 3   | 98.196mb -0.00%  | 3.596ms -18.79%   | ±0.46% -19.89%   |
| RowsBench         | bench_sort_asc_on_1k       | 2    | 3   | 95.610mb -0.00%  | 42.432ms -4.15%   | ±1.19% +71.34%   |
| RowsBench         | bench_sort_by_on_1k        | 2    | 3   | 95.611mb -0.00%  | 41.299ms -3.65%   | ±1.33% +228.70%  |
| RowsBench         | bench_sort_desc_on_1k      | 2    | 3   | 95.610mb -0.00%  | 41.750ms -3.68%   | ±0.05% -93.66%   |
| RowsBench         | bench_sort_entries_on_1k   | 2    | 3   | 97.755mb -0.00%  | 8.175ms -1.32%    | ±0.64% -36.11%   |
| RowsBench         | bench_sort_on_1k           | 2    | 3   | 95.505mb -0.00%  | 29.477ms -0.25%   | ±0.66% +60.52%   |
| RowsBench         | bench_take_1k_on_10k       | 10   | 3   | 95.314mb -0.00%  | 12.806μs -9.45%   | ±0.37% -84.12%   |
| RowsBench         | bench_take_right_1k_on_10k | 10   | 3   | 95.314mb -0.00%  | 15.288μs -2.13%   | ±0.62% -22.75%   |
| RowsBench         | bench_unique_on_1k         | 2    | 3   | 114.350mb +0.05% | 183.822ms -1.43%  | ±0.50% -30.81%   |
+-------------------+----------------------------+------+-----+------------------+-------------------+------------------+

@codecov
Copy link

codecov bot commented Mar 15, 2025

Codecov Report

Attention: Patch coverage is 69.23077% with 8 lines in your changes missing coverage. Please review.

Project coverage is 83.01%. Comparing base (a07b98e) to head (40e1ab9).
Report is 2 commits behind head on 1.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              1.x    #1533   +/-   ##
=======================================
  Coverage   83.01%   83.01%           
=======================================
  Files         687      687           
  Lines       18744    18715   -29     
=======================================
- Hits        15560    15537   -23     
+ Misses       3184     3178    -6     
Components Coverage Δ
etl 86.03% <69.23%> (+0.03%) ⬆️
cli 84.35% <ø> (ø)
lib-array-dot 94.53% <ø> (ø)
lib-azure-sdk 62.56% <ø> (ø)
lib-doctrine-dbal-bulk 90.11% <ø> (ø)
lib-filesystem 78.02% <ø> (ø)
lib-parquet 84.33% <ø> (ø)
lib-parquet-viewer 82.02% <ø> (ø)
lib-snappy 90.69% <ø> (-0.47%) ⬇️
bridge-filesystem-async-aws 90.38% <ø> (ø)
bridge-filesystem-azure 89.92% <ø> (ø)
bridge-monolog-http 96.38% <ø> (ø)
symfony-http-foundation 74.41% <ø> (ø)
adapter-chartjs 86.45% <ø> (ø)
adapter-csv 89.57% <ø> (ø)
adapter-doctrine 89.14% <ø> (ø)
adapter-elasticsearch 97.19% <ø> (ø)
adapter-google-sheet 78.04% <ø> (ø)
adapter-http 59.15% <ø> (ø)
adapter-json 90.62% <ø> (ø)
adapter-logger 53.84% <ø> (ø)
adapter-meilisearch 97.75% <ø> (ø)
adapter-parquet 80.85% <ø> (ø)
adapter-text 84.44% <ø> (ø)
adapter-xml 83.15% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@norberttech norberttech merged commit 0fcb1d6 into flow-php:1.x Mar 15, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Readability of Casting Exception

1 participant