Skip to content

Conversation

@norberttech
Copy link
Member

Change Log

Added

  • spaze/phpstan-disallowed-calls

Fixed

Changed

  • Replaced BCmath calculator with brick/math library
  • Divide on floats will expect to provide scale & rounding

Removed

  • FloatType::toString will no longer print precision
  • bcmath polyfill dependency

Deprecated

Security


Description

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak        | mode             | rstdev          |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.955mb -1.55%  | 619.210ms +1.00% | ±0.52% -48.29%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 5.030mb +6.82%  | 1.346s +18.55%   | ±1.23% +20.34%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 86.489mb -0.02% | 940.415ms +5.50% | ±0.62% +51.41%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.613mb -0.22%  | 38.973ms +2.22%  | ±0.47% -49.58%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.587mb -0.23%  | 615.179ms +1.82% | ±2.44% +390.39% |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev          |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 127.410mb -0.01% | 69.229ms -0.13% | ±0.68% +923.06% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev         |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 64.056mb -0.02%  | 103.170ms -2.32% | ±0.72% -50.94% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 84.603mb -0.62%  | 96.713ms -2.02%  | ±0.90% -53.61% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 161.304mb +3.26% | 20.993s +0.99%   | ±0.10% -89.59% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 18.145mb -0.06%  | 31.544ms +1.41%  | ±0.57% -20.73% |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
Building Blocks
+-------------------+----------------------------+------+-----+------------------+-------------------+-----------------+
| benchmark         | subject                    | revs | its | mem_peak         | mode              | rstdev          |
+-------------------+----------------------------+------+-----+------------------+-------------------+-----------------+
| TypeDetectorBench | bench_type_detector        | 1    | 3   | 43.927mb +0.27%  | 466.413ms +24.64% | ±1.20% +285.63% |
| TypeDetectorBench | bench_type_detector        | 1    | 3   | 11.737mb +0.99%  | 93.608ms +24.41%  | ±0.97% -34.95%  |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 106.040mb -0.50% | 725.884ms +37.71% | ±0.25% -73.40%  |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 55.231mb -0.38%  | 363.456ms +35.20% | ±0.94% +21.69%  |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.753mb +0.30%  | 80.009ms +35.59%  | ±1.54% +35.78%  |
| RowsBench         | bench_chunk_10_on_10k      | 2    | 3   | 97.073mb -0.01%  | 3.776ms +18.51%   | ±1.91% +301.51% |
| RowsBench         | bench_diff_left_1k_on_10k  | 2    | 3   | 114.434mb -0.01% | 181.234ms -1.82%  | ±1.42% +125.19% |
| RowsBench         | bench_diff_right_1k_on_10k | 2    | 3   | 97.154mb -0.02%  | 18.199ms -5.39%   | ±0.39% -62.37%  |
| RowsBench         | bench_drop_1k_on_10k       | 2    | 3   | 97.948mb -0.01%  | 1.952ms +25.95%   | ±2.31% -22.72%  |
| RowsBench         | bench_drop_right_1k_on_10k | 2    | 3   | 97.948mb -0.01%  | 2.008ms +33.25%   | ±1.96% -24.79%  |
| RowsBench         | bench_entries_on_10k       | 2    | 3   | 96.108mb -0.01%  | 5.133ms +18.56%   | ±3.47% -2.12%   |
| RowsBench         | bench_filter_on_10k        | 2    | 3   | 96.637mb -0.01%  | 18.118ms +13.90%  | ±0.94% -69.11%  |
| RowsBench         | bench_find_on_10k          | 2    | 3   | 96.637mb -0.01%  | 19.138ms +21.14%  | ±3.27% +182.58% |
| RowsBench         | bench_find_one_on_10k      | 10   | 3   | 95.329mb -0.01%  | 1.894μs +11.01%   | ±2.53% -7.14%   |
| RowsBench         | bench_first_on_10k         | 10   | 3   | 95.329mb -0.01%  | 0.400μs 0.00%     | ±0.00% 0.00%    |
| RowsBench         | bench_flat_map_on_1k       | 2    | 3   | 104.547mb -0.01% | 16.061ms -0.46%   | ±0.18% -85.82%  |
| RowsBench         | bench_map_on_10k           | 2    | 3   | 134.614mb -0.01% | 72.590ms -0.12%   | ±1.05% -8.12%   |
| RowsBench         | bench_merge_1k_on_10k      | 2    | 3   | 97.157mb -0.01%  | 1.811ms +31.11%   | ±1.32% -36.20%  |
| RowsBench         | bench_partition_by_on_10k  | 2    | 3   | 100.533mb -0.02% | 63.719ms +2.53%   | ±0.58% -49.39%  |
| RowsBench         | bench_remove_on_10k        | 2    | 3   | 98.210mb -0.01%  | 4.434ms +14.69%   | ±2.99% +131.10% |
| RowsBench         | bench_sort_asc_on_1k       | 2    | 3   | 95.696mb -0.02%  | 39.917ms -2.46%   | ±3.58% +65.05%  |
| RowsBench         | bench_sort_by_on_1k        | 2    | 3   | 95.696mb -0.02%  | 41.318ms +0.72%   | ±2.56% +78.53%  |
| RowsBench         | bench_sort_desc_on_1k      | 2    | 3   | 95.696mb -0.02%  | 42.151ms +1.88%   | ±2.65% +132.27% |
| RowsBench         | bench_sort_entries_on_1k   | 2    | 3   | 97.769mb -0.01%  | 8.552ms +1.63%    | ±0.93% -61.76%  |
| RowsBench         | bench_sort_on_1k           | 2    | 3   | 95.519mb -0.01%  | 30.242ms +2.08%   | ±0.80% -42.03%  |
| RowsBench         | bench_take_1k_on_10k       | 10   | 3   | 95.329mb -0.01%  | 16.018μs +20.22%  | ±0.88% -37.42%  |
| RowsBench         | bench_take_right_1k_on_10k | 10   | 3   | 95.329mb -0.01%  | 16.700μs +4.65%   | ±0.98% -37.02%  |
| RowsBench         | bench_unique_on_1k         | 2    | 3   | 114.435mb -0.01% | 184.121ms -1.25%  | ±0.26% -56.86%  |
+-------------------+----------------------------+------+-----+------------------+-------------------+-----------------+

@codecov
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 91.22807% with 15 lines in your changes missing coverage. Please review.

Project coverage is 83.14%. Comparing base (3ff63c1) to head (c2b9855).
Report is 4 commits behind head on 1.x.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##              1.x    #1584      +/-   ##
==========================================
- Coverage   83.25%   83.14%   -0.11%     
==========================================
  Files         702      702              
  Lines       19015    18976      -39     
==========================================
- Hits        15831    15778      -53     
- Misses       3184     3198      +14     
Components Coverage Δ
etl 86.19% <91.22%> (-0.25%) ⬇️
cli 84.59% <ø> (ø)
lib-array-dot 94.53% <ø> (ø)
lib-azure-sdk 62.56% <ø> (ø)
lib-doctrine-dbal-bulk 90.11% <ø> (ø)
lib-filesystem 78.02% <ø> (ø)
lib-parquet 84.36% <ø> (ø)
lib-parquet-viewer 82.02% <ø> (ø)
lib-snappy 91.16% <ø> (+0.46%) ⬆️
bridge-filesystem-async-aws 90.38% <ø> (ø)
bridge-filesystem-azure 89.92% <ø> (ø)
bridge-monolog-http 96.38% <ø> (ø)
symfony-http-foundation 74.41% <ø> (ø)
adapter-chartjs 86.45% <ø> (ø)
adapter-csv 89.57% <ø> (ø)
adapter-doctrine 89.14% <ø> (ø)
adapter-elasticsearch 97.19% <ø> (ø)
adapter-google-sheet 78.04% <ø> (ø)
adapter-http 59.15% <ø> (ø)
adapter-json 90.62% <ø> (ø)
adapter-logger 53.84% <ø> (ø)
adapter-meilisearch 97.75% <ø> (ø)
adapter-parquet 80.85% <ø> (ø)
adapter-text 84.44% <ø> (ø)
adapter-xml 83.15% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@norberttech norberttech force-pushed the 1579-replacing-bcmath-with-brick-math branch from 7c8895e to 03e176a Compare April 7, 2025 12:35
@norberttech norberttech merged commit 8313fe6 into 1.x Apr 7, 2025
22 of 23 checks passed
@norberttech norberttech deleted the 1579-replacing-bcmath-with-brick-math branch April 7, 2025 14:08
This was referenced May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants