Skip to content

Conversation

@norberttech
Copy link
Member

Change Log

Added

Fixed

Changed

  • Dont truncate ascii table output schema

Removed

Deprecated

Security


Description

@norberttech norberttech linked an issue May 8, 2025 that may be closed by this pull request
@norberttech norberttech enabled auto-merge (squash) May 8, 2025 13:21
@codecov
Copy link

codecov bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.18%. Comparing base (b91a22c) to head (d5e6b3e).
Report is 2 commits behind head on 1.x.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##              1.x    #1639   +/-   ##
=======================================
  Coverage   83.17%   83.18%           
=======================================
  Files         706      706           
  Lines       19101    19103    +2     
=======================================
+ Hits        15887    15890    +3     
+ Misses       3214     3213    -1     
Components Coverage Δ
etl 86.13% <100.00%> (+<0.01%) ⬆️
cli 84.59% <ø> (ø)
lib-array-dot 94.53% <ø> (ø)
lib-azure-sdk 62.56% <ø> (ø)
lib-doctrine-dbal-bulk 90.11% <ø> (ø)
lib-filesystem 78.02% <ø> (ø)
lib-parquet 84.36% <ø> (ø)
lib-parquet-viewer 82.02% <ø> (ø)
lib-snappy 91.16% <ø> (+0.46%) ⬆️
bridge-filesystem-async-aws 90.38% <ø> (ø)
bridge-filesystem-azure 89.92% <ø> (ø)
bridge-monolog-http 96.38% <ø> (ø)
symfony-http-foundation 74.41% <ø> (ø)
adapter-chartjs 86.45% <ø> (ø)
adapter-csv 89.57% <ø> (ø)
adapter-doctrine 89.73% <ø> (ø)
adapter-elasticsearch 97.19% <ø> (ø)
adapter-google-sheet 80.00% <ø> (ø)
adapter-http 59.15% <ø> (ø)
adapter-json 90.62% <ø> (ø)
adapter-logger 53.84% <ø> (ø)
adapter-meilisearch 97.75% <ø> (ø)
adapter-parquet 80.85% <ø> (ø)
adapter-text 84.44% <ø> (ø)
adapter-xml 83.15% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2025

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak        | mode             | rstdev          |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.888mb +0.01%  | 619.581ms -0.49% | ±2.45% +164.11% |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 5.468mb +0.03%  | 1.350s +1.30%    | ±2.97% +476.93% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 86.485mb +0.00% | 931.490ms -1.55% | ±0.32% -84.30%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.612mb +0.01%  | 38.871ms -1.02%  | ±0.23% -6.20%   |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.587mb +0.01%  | 596.831ms -2.51% | ±1.37% +73.16%  |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 127.410mb +0.00% | 69.833ms -0.30% | ±0.66% -19.54% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev         |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 64.055mb +0.00%  | 104.892ms -1.60% | ±0.53% -81.54% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 84.087mb +0.00%  | 96.292ms -5.69%  | ±0.69% -59.75% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 166.569mb +0.00% | 20.626s -4.24%   | ±0.21% -67.67% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 18.145mb +0.00%  | 31.345ms +0.89%  | ±0.69% +28.57% |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
Building Blocks
+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark         | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| TypeDetectorBench | bench_type_detector        | 1    | 3   | 44.053mb +0.00%  | 460.634ms -0.14% | ±0.33% -53.85%  |
| TypeDetectorBench | bench_type_detector        | 1    | 3   | 11.862mb +0.00%  | 93.583ms -1.30%  | ±1.05% -50.74%  |
| RowsBench         | bench_chunk_10_on_10k      | 2    | 3   | 97.072mb +0.00%  | 3.323ms -25.41%  | ±1.50% -48.85%  |
| RowsBench         | bench_diff_left_1k_on_10k  | 2    | 3   | 114.428mb +0.00% | 181.201ms -1.32% | ±0.53% -55.72%  |
| RowsBench         | bench_diff_right_1k_on_10k | 2    | 3   | 97.148mb +0.00%  | 18.329ms -2.32%  | ±0.24% -20.51%  |
| RowsBench         | bench_drop_1k_on_10k       | 2    | 3   | 97.946mb +0.00%  | 1.550ms -22.42%  | ±1.66% -49.01%  |
| RowsBench         | bench_drop_right_1k_on_10k | 2    | 3   | 97.946mb +0.00%  | 1.533ms -29.47%  | ±0.21% -92.81%  |
| RowsBench         | bench_entries_on_10k       | 2    | 3   | 96.107mb +0.00%  | 4.309ms -30.95%  | ±3.62% +3.72%   |
| RowsBench         | bench_filter_on_10k        | 2    | 3   | 96.636mb +0.00%  | 16.345ms -4.64%  | ±1.57% +304.90% |
| RowsBench         | bench_find_on_10k          | 2    | 3   | 96.636mb +0.00%  | 16.468ms -2.08%  | ±0.70% -41.20%  |
| RowsBench         | bench_find_one_on_10k      | 10   | 3   | 95.328mb +0.00%  | 1.806μs -9.97%   | ±2.57% +10.91%  |
| RowsBench         | bench_first_on_10k         | 10   | 3   | 95.328mb +0.00%  | 0.400μs 0.00%    | ±0.00% 0.00%    |
| RowsBench         | bench_flat_map_on_1k       | 2    | 3   | 104.546mb +0.00% | 14.772ms -16.90% | ±0.94% -58.69%  |
| RowsBench         | bench_map_on_10k           | 2    | 3   | 134.613mb +0.00% | 73.745ms -0.36%  | ±2.42% +423.90% |
| RowsBench         | bench_merge_1k_on_10k      | 2    | 3   | 97.156mb +0.00%  | 1.390ms -27.13%  | ±1.60% -12.25%  |
| RowsBench         | bench_partition_by_on_10k  | 2    | 3   | 100.527mb +0.00% | 64.748ms +1.61%  | ±0.96% +58.22%  |
| RowsBench         | bench_remove_on_10k        | 2    | 3   | 98.209mb +0.00%  | 4.038ms -1.24%   | ±2.24% -31.54%  |
| RowsBench         | bench_sort_asc_on_1k       | 2    | 3   | 95.690mb +0.00%  | 39.571ms -6.83%  | ±1.56% +5.93%   |
| RowsBench         | bench_sort_by_on_1k        | 2    | 3   | 95.690mb +0.00%  | 41.502ms -3.37%  | ±2.46% +116.68% |
| RowsBench         | bench_sort_desc_on_1k      | 2    | 3   | 95.690mb +0.00%  | 39.540ms -5.84%  | ±0.88% -36.12%  |
| RowsBench         | bench_sort_entries_on_1k   | 2    | 3   | 97.768mb +0.00%  | 8.144ms -4.98%   | ±1.30% +42.14%  |
| RowsBench         | bench_sort_on_1k           | 2    | 3   | 95.518mb +0.00%  | 29.553ms -2.45%  | ±1.67% +12.87%  |
| RowsBench         | bench_take_1k_on_10k       | 10   | 3   | 95.328mb +0.00%  | 14.257μs -3.01%  | ±2.33% +110.17% |
| RowsBench         | bench_take_right_1k_on_10k | 10   | 3   | 95.328mb +0.00%  | 16.399μs -5.98%  | ±2.49% +33.02%  |
| RowsBench         | bench_unique_on_1k         | 2    | 3   | 114.429mb +0.00% | 187.331ms +0.14% | ±0.53% -68.43%  |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 105.518mb +0.00% | 726.886ms -0.64% | ±0.80% +10.89%  |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 55.028mb +0.00%  | 358.652ms -3.38% | ±0.50% +40.28%  |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.806mb +0.00%  | 77.531ms -3.88%  | ±1.76% -5.48%   |
+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@norberttech norberttech merged commit 5111751 into 1.x May 8, 2025
20 checks passed
@norberttech norberttech deleted the 1638-dont-truncate-table-ascii-schema-output branch May 8, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dont truncate table ascii schema output

2 participants