Skip to content

Conversation

@norberttech
Copy link
Member

Change Log

Added

Fixed

  • pipelines optimization that was traversing through collection of pipelines

Changed

Removed

Deprecated

Security


Description

@norberttech norberttech linked an issue May 15, 2025 that may be closed by this pull request
@norberttech norberttech enabled auto-merge (squash) May 15, 2025 09:57
@github-actions
Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak        | mode             | rstdev          |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.887mb +0.02%  | 615.718ms -4.66% | ±0.07% -82.54%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 5.473mb +0.02%  | 1.375s +2.57%    | ±0.93% +154.85% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 86.484mb +0.00% | 951.922ms +1.16% | ±0.44% -31.69%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.611mb +0.02%  | 39.978ms +2.60%  | ±0.71% -46.91%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.585mb +0.03%  | 610.666ms +0.97% | ±0.47% -83.81%  |
+-----------------------+-------------------+------+-----+-----------------+------------------+-----------------+
Transformers
+---------------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                       | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+---------------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench     | bench_transform_10k_rows | 1    | 3   | 127.408mb +0.00% | 70.919ms -9.85% | ±3.51% +30.48% |
| RenameEachEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 19.155mb +0.01%  | 75.073ms -0.41% | ±0.38% -67.43% |
+---------------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 64.054mb +0.00%  | 105.175ms -1.73% | ±0.40% +165.37% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 84.086mb +0.00%  | 98.442ms -1.36%  | ±0.55% -12.49%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 166.569mb +0.00% | 21.920s +5.94%   | ±0.57% +88.06%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 18.143mb +0.01%  | 31.015ms +4.26%  | ±0.26% -76.39%  |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark         | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 105.520mb +0.00% | 735.023ms +0.67% | ±0.67% -10.45%  |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 55.030mb +0.00%  | 368.579ms +0.87% | ±1.16% -12.03%  |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.808mb +0.00%  | 80.866ms +2.68%  | ±0.52% -50.23%  |
| RowsBench         | bench_chunk_10_on_10k      | 2    | 3   | 97.073mb +0.00%  | 4.196ms +13.94%  | ±1.80% -35.99%  |
| RowsBench         | bench_diff_left_1k_on_10k  | 2    | 3   | 114.430mb +0.00% | 179.526ms -1.32% | ±1.25% -17.38%  |
| RowsBench         | bench_diff_right_1k_on_10k | 2    | 3   | 97.150mb +0.00%  | 18.281ms -0.56%  | ±0.46% -35.78%  |
| RowsBench         | bench_drop_1k_on_10k       | 2    | 3   | 97.948mb +0.00%  | 2.008ms -6.09%   | ±3.82% +37.07%  |
| RowsBench         | bench_drop_right_1k_on_10k | 2    | 3   | 97.948mb +0.00%  | 2.064ms -13.56%  | ±1.10% -19.64%  |
| RowsBench         | bench_entries_on_10k       | 2    | 3   | 96.109mb +0.00%  | 5.681ms +7.08%   | ±0.41% -84.07%  |
| RowsBench         | bench_filter_on_10k        | 2    | 3   | 96.638mb +0.00%  | 17.141ms -2.46%  | ±0.33% -52.51%  |
| RowsBench         | bench_find_on_10k          | 2    | 3   | 96.638mb +0.00%  | 16.969ms +1.79%  | ±1.33% +34.63%  |
| RowsBench         | bench_find_one_on_10k      | 10   | 3   | 95.329mb +0.00%  | 2.000μs 0.00%    | ±0.00% 0.00%    |
| RowsBench         | bench_first_on_10k         | 10   | 3   | 95.329mb +0.00%  | 0.500μs +25.00%  | ±0.00% -100.00% |
| RowsBench         | bench_flat_map_on_1k       | 2    | 3   | 104.547mb +0.00% | 17.728ms +3.80%  | ±2.97% +420.34% |
| RowsBench         | bench_map_on_10k           | 2    | 3   | 134.614mb +0.00% | 76.239ms -6.63%  | ±1.08% -36.58%  |
| RowsBench         | bench_merge_1k_on_10k      | 2    | 3   | 97.158mb +0.00%  | 2.023ms -8.78%   | ±2.50% -15.02%  |
| RowsBench         | bench_partition_by_on_10k  | 2    | 3   | 100.529mb +0.00% | 65.120ms -6.40%  | ±0.61% +42.74%  |
| RowsBench         | bench_remove_on_10k        | 2    | 3   | 98.210mb +0.00%  | 4.522ms -9.66%   | ±3.23% +83.94%  |
| RowsBench         | bench_sort_asc_on_1k       | 2    | 3   | 95.692mb +0.00%  | 43.570ms -5.17%  | ±1.02% -54.65%  |
| RowsBench         | bench_sort_by_on_1k        | 2    | 3   | 95.692mb +0.00%  | 43.200ms -3.37%  | ±1.09% -48.50%  |
| RowsBench         | bench_sort_desc_on_1k      | 2    | 3   | 95.692mb +0.00%  | 43.600ms +2.51%  | ±0.46% -43.65%  |
| RowsBench         | bench_sort_entries_on_1k   | 2    | 3   | 97.770mb +0.00%  | 9.412ms +2.44%   | ±2.46% -19.97%  |
| RowsBench         | bench_sort_on_1k           | 2    | 3   | 95.520mb +0.00%  | 32.569ms +4.84%  | ±0.17% -93.90%  |
| RowsBench         | bench_take_1k_on_10k       | 10   | 3   | 95.329mb +0.00%  | 14.894μs -28.55% | ±0.32% -85.36%  |
| RowsBench         | bench_take_right_1k_on_10k | 10   | 3   | 95.329mb +0.00%  | 17.193μs -29.59% | ±1.78% -30.58%  |
| RowsBench         | bench_unique_on_1k         | 2    | 3   | 114.431mb +0.00% | 185.203ms -2.69% | ±0.40% -59.47%  |
| TypeDetectorBench | bench_type_detector        | 1    | 3   | 44.055mb +0.00%  | 468.728ms -0.29% | ±1.04% -1.52%   |
| TypeDetectorBench | bench_type_detector        | 1    | 3   | 11.864mb +0.00%  | 94.669ms -2.08%  | ±0.88% +82.09%  |
+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@norberttech norberttech merged commit 069a3e8 into 1.x May 15, 2025
20 checks passed
@norberttech norberttech deleted the 1649-performance-issue-with-0161 branch May 15, 2025 10:01
@codecov
Copy link

codecov bot commented May 15, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.28%. Comparing base (e301707) to head (0283b83).
Report is 2 commits behind head on 1.x.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##              1.x    #1652      +/-   ##
==========================================
+ Coverage   83.26%   83.28%   +0.01%     
==========================================
  Files         707      706       -1     
  Lines       19139    19127      -12     
==========================================
- Hits        15937    15930       -7     
+ Misses       3202     3197       -5     
Components Coverage Δ
etl 86.37% <85.71%> (+0.04%) ⬆️
cli 84.59% <ø> (ø)
lib-array-dot 94.53% <ø> (ø)
lib-azure-sdk 62.56% <ø> (ø)
lib-doctrine-dbal-bulk 90.11% <ø> (ø)
lib-filesystem 78.02% <ø> (ø)
lib-parquet 84.37% <ø> (ø)
lib-parquet-viewer 82.02% <ø> (ø)
lib-snappy 90.69% <ø> (ø)
bridge-filesystem-async-aws 90.38% <ø> (ø)
bridge-filesystem-azure 89.92% <ø> (ø)
bridge-monolog-http 96.38% <ø> (ø)
symfony-http-foundation 74.41% <ø> (ø)
adapter-chartjs 86.45% <ø> (ø)
adapter-csv 89.57% <ø> (ø)
adapter-doctrine 89.73% <ø> (ø)
adapter-elasticsearch 97.19% <ø> (ø)
adapter-google-sheet 80.00% <ø> (ø)
adapter-http 59.15% <ø> (ø)
adapter-json 90.62% <ø> (ø)
adapter-logger 53.84% <ø> (ø)
adapter-meilisearch 97.75% <ø> (ø)
adapter-parquet 80.85% <ø> (ø)
adapter-text 84.44% <ø> (ø)
adapter-xml 83.20% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Performance issue with 0.16.1

2 participants