Skip to content

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented May 20, 2025

Change Log

Added

  • Add a benchmark for Excel Extractor with an ODS file

Fixed

Changed

Removed

Deprecated

Security


Description

@stloyd stloyd requested a review from norberttech as a code owner May 20, 2025 15:25
@github-actions
Copy link
Contributor

github-actions bot commented May 20, 2025

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+------------------------+------+-----+-----------------+------------------+------------------+
| benchmark             | subject                | revs | its | mem_peak        | mode             | rstdev           |
+-----------------------+------------------------+------+-----+-----------------+------------------+------------------+
| CSVExtractorBench     | bench_extract_10k      | 1    | 3   | 4.775mb +0.01%  | 603.442ms +0.73% | ±3.18% +2928.03% |
| ExcelExtractorBench   | bench_extract_10k_ods  | 1    | 3   | ERR             | 1.048s +0.00%    | ±1.06% +0.00%    |
| ExcelExtractorBench   | bench_extract_10k_xlsx | 1    | 3   | ERR             | 1.693s +0.00%    | ±0.81% +0.00%    |
| JsonExtractorBench    | bench_extract_10k      | 1    | 3   | 5.018mb +0.01%  | 1.283s -0.00%    | ±1.49% +56.49%   |
| ParquetExtractorBench | bench_extract_10k      | 1    | 3   | 86.321mb +0.00% | 932.333ms +1.79% | ±0.43% +340.59%  |
| TextExtractorBench    | bench_extract_10k      | 1    | 3   | 4.499mb +0.01%  | 38.881ms +1.03%  | ±1.15% +7.99%    |
| XmlExtractorBench     | bench_extract_10k      | 1    | 3   | 4.494mb +0.01%  | 608.353ms -1.14% | ±1.95% +56.82%   |
+-----------------------+------------------------+------+-----+-----------------+------------------+------------------+
Transformers
+---------------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                       | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+---------------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench     | bench_transform_10k_rows | 1    | 3   | 123.236mb +0.00% | 69.778ms +5.77% | ±1.07% -14.55% |
| RenameEachEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 18.498mb +0.00%  | 74.434ms +4.37% | ±1.05% -21.12% |
+---------------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+------------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev           |
+--------------------+----------------+------+-----+------------------+------------------+------------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 62.435mb +0.00%  | 90.317ms +4.49%  | ±0.71% -31.00%   |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 79.706mb +0.00%  | 101.375ms +3.94% | ±1.00% -40.56%   |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 165.387mb +0.00% | 20.846s +0.82%   | ±0.36% +2056.05% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.805mb +0.00%  | 31.189ms -0.09%  | ±0.40% -11.21%   |
+--------------------+----------------+------+-----+------------------+------------------+------------------+
Building Blocks
+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark         | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 101.784mb +0.00% | 651.580ms +1.48% | ±1.45% +149.99% |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 53.134mb +0.00%  | 327.596ms -1.06% | ±0.65% -29.14%  |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.384mb +0.00%  | 70.676ms +0.96%  | ±1.37% +32.00%  |
| RowsBench         | bench_chunk_10_on_10k      | 2    | 3   | 93.389mb +0.00%  | 3.743ms +12.69%  | ±3.20% +89.20%  |
| RowsBench         | bench_diff_left_1k_on_10k  | 2    | 3   | 110.758mb +0.00% | 242.375ms +0.92% | ±0.57% +166.77% |
| RowsBench         | bench_diff_right_1k_on_10k | 2    | 3   | 93.478mb +0.00%  | 25.219ms +5.59%  | ±2.59% +52.19%  |
| RowsBench         | bench_drop_1k_on_10k       | 2    | 3   | 94.264mb +0.00%  | 1.522ms +12.38%  | ±2.39% -5.53%   |
| RowsBench         | bench_drop_right_1k_on_10k | 2    | 3   | 94.264mb +0.00%  | 1.762ms +25.25%  | ±2.96% +219.15% |
| RowsBench         | bench_entries_on_10k       | 2    | 3   | 92.424mb +0.00%  | 3.639ms +8.42%   | ±1.41% +563.50% |
| RowsBench         | bench_filter_on_10k        | 2    | 3   | 92.953mb +0.00%  | 17.335ms +9.37%  | ±1.38% +10.07%  |
| RowsBench         | bench_find_on_10k          | 2    | 3   | 92.953mb +0.00%  | 17.512ms +11.20% | ±3.25% +225.59% |
| RowsBench         | bench_find_one_on_10k      | 10   | 3   | 91.642mb +0.00%  | 1.906μs 0.00%    | ±2.44% 0.00%    |
| RowsBench         | bench_first_on_10k         | 10   | 3   | 91.642mb +0.00%  | 0.400μs +33.33%  | ±0.00% +0.00%   |
| RowsBench         | bench_flat_map_on_1k       | 2    | 3   | 100.703mb +0.00% | 14.579ms -0.61%  | ±1.06% -21.82%  |
| RowsBench         | bench_map_on_10k           | 2    | 3   | 130.130mb +0.00% | 68.831ms +1.21%  | ±2.18% +42.00%  |
| RowsBench         | bench_merge_1k_on_10k      | 2    | 3   | 93.473mb +0.00%  | 1.624ms +24.43%  | ±3.41% +159.96% |
| RowsBench         | bench_partition_by_on_10k  | 2    | 3   | 96.841mb +0.00%  | 65.990ms +5.49%  | ±0.83% -0.76%   |
| RowsBench         | bench_remove_on_10k        | 2    | 3   | 94.526mb +0.00%  | 4.557ms +31.10%  | ±3.44% +639.47% |
| RowsBench         | bench_sort_asc_on_1k       | 2    | 3   | 92.003mb +0.00%  | 40.473ms +0.78%  | ±1.51% -21.64%  |
| RowsBench         | bench_sort_by_on_1k        | 2    | 3   | 92.004mb +0.00%  | 40.020ms -1.22%  | ±3.38% +198.29% |
| RowsBench         | bench_sort_desc_on_1k      | 2    | 3   | 92.003mb +0.00%  | 41.846ms +2.94%  | ±2.04% +28.78%  |
| RowsBench         | bench_sort_entries_on_1k   | 2    | 3   | 94.085mb +0.00%  | 8.336ms +2.22%   | ±0.53% -67.49%  |
| RowsBench         | bench_sort_on_1k           | 2    | 3   | 91.835mb +0.00%  | 32.530ms +8.38%  | ±3.02% +252.42% |
| RowsBench         | bench_take_1k_on_10k       | 10   | 3   | 91.642mb +0.00%  | 14.493μs +4.22%  | ±2.11% +522.96% |
| RowsBench         | bench_take_right_1k_on_10k | 10   | 3   | 91.642mb +0.00%  | 16.337μs +4.86%  | ±2.80% +251.28% |
| RowsBench         | bench_unique_on_1k         | 2    | 3   | 110.759mb +0.00% | 249.180ms +2.72% | ±0.72% +17.52%  |
| TypeDetectorBench | bench_type_detector        | 1    | 3   | 42.070mb +0.00%  | 428.529ms +0.10% | ±0.78% +81.67%  |
| TypeDetectorBench | bench_type_detector        | 1    | 3   | 11.448mb +0.00%  | 87.289ms +1.58%  | ±1.50% +28.74%  |
+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@codecov
Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.08%. Comparing base (0a74411) to head (6d67f68).
Report is 2 commits behind head on 1.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              1.x    #1663      +/-   ##
==========================================
+ Coverage   82.07%   82.08%   +0.01%     
==========================================
  Files         703      703              
  Lines       19053    19053              
==========================================
+ Hits        15637    15639       +2     
+ Misses       3416     3414       -2     
Components Coverage Δ
etl 88.27% <ø> (ø)
cli 84.42% <ø> (ø)
lib-array-dot 94.53% <ø> (ø)
lib-azure-sdk 62.56% <ø> (ø)
lib-doctrine-dbal-bulk 90.11% <ø> (ø)
lib-filesystem 78.02% <ø> (ø)
lib-parquet 84.37% <ø> (ø)
lib-parquet-viewer 82.02% <ø> (ø)
lib-snappy 91.62% <ø> (+0.93%) ⬆️
bridge-filesystem-async-aws 90.38% <ø> (ø)
bridge-filesystem-azure 89.92% <ø> (ø)
bridge-monolog-http 96.38% <ø> (ø)
symfony-http-foundation 74.41% <ø> (ø)
adapter-chartjs 86.45% <ø> (ø)
adapter-csv 89.57% <ø> (ø)
adapter-doctrine 89.69% <ø> (ø)
adapter-elasticsearch 97.19% <ø> (ø)
adapter-google-sheet 83.87% <ø> (ø)
adapter-http 59.15% <ø> (ø)
adapter-json 90.62% <ø> (ø)
adapter-logger 53.84% <ø> (ø)
adapter-meilisearch 97.75% <ø> (ø)
adapter-parquet 78.42% <ø> (ø)
adapter-text 84.44% <ø> (ø)
adapter-xml 83.15% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@norberttech norberttech merged commit 60072b2 into flow-php:1.x May 20, 2025
21 checks passed
@stloyd stloyd deleted the excel-extractor-ods-bench branch May 20, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants