Skip to content

Conversation

@norberttech
Copy link
Member

Resolves: #1686

Change Log


Added

  • Dbal Bulk::delete()
  • to_dbal_table_delete()
  • Tested dbal adapter elements at all supported db engines

Fixed

Changed

Removed

Deprecated

Security

@norberttech norberttech linked an issue May 27, 2025 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented May 27, 2025

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+------------------------+------+-----+-----------------+------------------+-----------------+
| benchmark             | subject                | revs | its | mem_peak        | mode             | rstdev          |
+-----------------------+------------------------+------+-----+-----------------+------------------+-----------------+
| CSVExtractorBench     | bench_extract_10k      | 1    | 3   | 4.781mb +0.15%  | 414.070ms +0.28% | ±0.22% +69.22%  |
| ExcelExtractorBench   | bench_extract_10k_ods  | 1    | 3   | 65.492mb +0.01% | 1.047s -1.28%    | ±0.31% -58.59%  |
| ExcelExtractorBench   | bench_extract_10k_xlsx | 1    | 3   | 67.538mb +0.01% | 1.672s -2.10%    | ±0.63% +9.32%   |
| JsonExtractorBench    | bench_extract_10k      | 1    | 3   | 5.025mb +0.15%  | 1.279s -0.42%    | ±0.71% +433.04% |
| ParquetExtractorBench | bench_extract_10k      | 1    | 3   | 86.327mb +0.01% | 909.443ms -0.63% | ±0.30% -66.47%  |
| TextExtractorBench    | bench_extract_10k      | 1    | 3   | 4.505mb +0.16%  | 38.550ms +0.11%  | ±1.00% -24.08%  |
| XmlExtractorBench     | bench_extract_10k      | 1    | 3   | 4.500mb +0.16%  | 594.876ms -1.77% | ±0.72% -33.88%  |
+-----------------------+------------------------+------+-----+-----------------+------------------+-----------------+
Transformers
+---------------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| benchmark                       | subject                  | revs | its | mem_peak         | mode            | rstdev          |
+---------------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| RenameEntryTransformerBench     | bench_transform_10k_rows | 1    | 3   | 123.241mb +0.01% | 64.857ms -4.42% | ±1.23% +186.56% |
| RenameEachEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 18.503mb +0.04%  | 71.858ms -2.19% | ±0.27% -51.39%  |
+---------------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
Loaders
+--------------------+----------------+------+-----+------------------+-----------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode            | rstdev          |
+--------------------+----------------+------+-----+------------------+-----------------+-----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 62.441mb +0.01%  | 84.297ms +0.51% | ±2.87% +540.05% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 79.712mb +0.01%  | 97.099ms -0.13% | ±0.42% -8.94%   |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 166.217mb +0.01% | 20.619s -1.71%  | ±0.50% +50.11%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.811mb +0.04%  | 30.148ms -1.95% | ±0.79% -5.26%   |
+--------------------+----------------+------+-----+------------------+-----------------+-----------------+
Building Blocks
+-------------------+----------------------------+------+-----+------------------+------------------+------------------+
| benchmark         | subject                    | revs | its | mem_peak         | mode             | rstdev           |
+-------------------+----------------------------+------+-----+------------------+------------------+------------------+
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 101.790mb +0.01% | 645.520ms +0.00% | ±0.42% +111.90%  |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 53.141mb +0.01%  | 324.708ms -0.84% | ±1.68% +3603.52% |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.391mb +0.05%  | 69.106ms -2.54%  | ±0.40% +11.38%   |
| RowsBench         | bench_chunk_10_on_10k      | 2    | 3   | 93.395mb +0.01%  | 3.244ms -11.47%  | ±0.51% -66.49%   |
| RowsBench         | bench_diff_left_1k_on_10k  | 2    | 3   | 110.764mb +0.01% | 236.573ms -0.17% | ±1.11% +108.34%  |
| RowsBench         | bench_diff_right_1k_on_10k | 2    | 3   | 93.484mb +0.01%  | 23.824ms -0.28%  | ±1.11% +24.87%   |
| RowsBench         | bench_drop_1k_on_10k       | 2    | 3   | 94.269mb +0.01%  | 1.232ms -33.16%  | ±3.18% +11.67%   |
| RowsBench         | bench_drop_right_1k_on_10k | 2    | 3   | 94.269mb +0.01%  | 1.322ms -27.37%  | ±3.46% +62.02%   |
| RowsBench         | bench_entries_on_10k       | 2    | 3   | 92.430mb +0.01%  | 3.410ms -6.40%   | ±0.68% +36.26%   |
| RowsBench         | bench_filter_on_10k        | 2    | 3   | 92.959mb +0.01%  | 15.311ms -5.01%  | ±1.76% +87.68%   |
| RowsBench         | bench_find_on_10k          | 2    | 3   | 92.959mb +0.01%  | 15.375ms -4.72%  | ±0.35% -70.94%   |
| RowsBench         | bench_find_one_on_10k      | 10   | 3   | 91.648mb +0.01%  | 1.894μs -5.02%   | ±2.53% +5.36%    |
| RowsBench         | bench_first_on_10k         | 10   | 3   | 91.648mb +0.01%  | 0.400μs +33.33%  | ±0.00% +0.00%    |
| RowsBench         | bench_flat_map_on_1k       | 2    | 3   | 100.708mb +0.01% | 14.071ms -0.49%  | ±0.54% -79.45%   |
| RowsBench         | bench_map_on_10k           | 2    | 3   | 130.135mb +0.01% | 65.953ms -2.89%  | ±0.31% -74.62%   |
| RowsBench         | bench_merge_1k_on_10k      | 2    | 3   | 93.479mb +0.01%  | 1.156ms -27.89%  | ±2.19% -19.25%   |
| RowsBench         | bench_partition_by_on_10k  | 2    | 3   | 96.847mb +0.01%  | 61.093ms -3.60%  | ±1.19% +75.81%   |
| RowsBench         | bench_remove_on_10k        | 2    | 3   | 94.532mb +0.01%  | 3.387ms -8.93%   | ±0.91% +20.51%   |
| RowsBench         | bench_sort_asc_on_1k       | 2    | 3   | 92.009mb +0.01%  | 40.141ms +1.01%  | ±1.46% -6.93%    |
| RowsBench         | bench_sort_by_on_1k        | 2    | 3   | 92.009mb +0.01%  | 39.924ms -3.50%  | ±1.26% -44.14%   |
| RowsBench         | bench_sort_desc_on_1k      | 2    | 3   | 92.009mb +0.01%  | 39.857ms -0.82%  | ±2.79% +197.47%  |
| RowsBench         | bench_sort_entries_on_1k   | 2    | 3   | 94.091mb +0.01%  | 8.129ms +1.20%   | ±0.10% -79.19%   |
| RowsBench         | bench_sort_on_1k           | 2    | 3   | 91.841mb +0.01%  | 29.295ms -3.76%  | ±0.89% -69.16%   |
| RowsBench         | bench_take_1k_on_10k       | 10   | 3   | 91.648mb +0.01%  | 13.900μs -10.11% | ±1.17% -61.45%   |
| RowsBench         | bench_take_right_1k_on_10k | 10   | 3   | 91.648mb +0.01%  | 15.500μs -6.06%  | ±0.53% +6.45%    |
| RowsBench         | bench_unique_on_1k         | 2    | 3   | 110.765mb +0.01% | 242.527ms +1.19% | ±0.13% -86.57%   |
| TypeDetectorBench | bench_type_detector        | 1    | 3   | 42.076mb +0.02%  | 423.470ms -1.01% | ±0.85% +169.70%  |
| TypeDetectorBench | bench_type_detector        | 1    | 3   | 11.454mb +0.06%  | 84.750ms -1.78%  | ±0.54% +85.83%   |
+-------------------+----------------------------+------+-----+------------------+------------------+------------------+

@codecov
Copy link

codecov bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.93%. Comparing base (e8d7de6) to head (a862f45).
Report is 3 commits behind head on 1.x.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##              1.x    #1687      +/-   ##
==========================================
+ Coverage   81.79%   81.93%   +0.14%     
==========================================
  Files         705      705              
  Lines       19144    19204      +60     
==========================================
+ Hits        15658    15734      +76     
+ Misses       3486     3470      -16     
Components Coverage Δ
etl 88.35% <ø> (ø)
cli 84.42% <ø> (ø)
lib-array-dot 94.53% <ø> (ø)
lib-azure-sdk 62.56% <ø> (ø)
lib-doctrine-dbal-bulk 93.49% <100.00%> (+3.38%) ⬆️
lib-filesystem 78.02% <ø> (ø)
lib-types 55.76% <ø> (+0.22%) ⬆️
lib-parquet 84.37% <ø> (ø)
lib-parquet-viewer 82.02% <ø> (ø)
lib-snappy 91.16% <ø> (+0.46%) ⬆️
bridge-filesystem-async-aws 90.38% <ø> (ø)
bridge-filesystem-azure 89.92% <ø> (ø)
bridge-monolog-http 96.38% <ø> (ø)
symfony-http-foundation 74.41% <ø> (ø)
adapter-chartjs 86.45% <ø> (ø)
adapter-csv 90.18% <ø> (ø)
adapter-doctrine 89.95% <100.00%> (+0.26%) ⬆️
adapter-elasticsearch 97.19% <ø> (ø)
adapter-google-sheet 83.87% <ø> (ø)
adapter-http 59.15% <ø> (ø)
adapter-json 90.62% <ø> (ø)
adapter-logger 53.84% <ø> (ø)
adapter-meilisearch 97.75% <ø> (ø)
adapter-parquet 78.64% <ø> (ø)
adapter-text 84.44% <ø> (ø)
adapter-xml 83.15% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@norberttech norberttech merged commit 02ff323 into 1.x May 28, 2025
22 checks passed
@norberttech norberttech deleted the 1686-proposal-dbal-deleting-loader branch May 28, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Proposal]: Dbal Deleting Loader

2 participants