Skip to content

Conversation

@norberttech
Copy link
Member

Resolves: #xxx

Change Log


Added

Fixed

  • length of auto generate aliases in dbal key set extractor

Changed

Removed

Deprecated

Security

@norberttech norberttech added this to the 0.19.0 milestone Jun 21, 2025
@norberttech norberttech moved this from Todo to In Progress in Roadmap Jun 21, 2025
@github-actions
Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+------------------------+------+-----+-----------------+------------------+-----------------+
| benchmark             | subject                | revs | its | mem_peak        | mode             | rstdev          |
+-----------------------+------------------------+------+-----+-----------------+------------------+-----------------+
| CSVExtractorBench     | bench_extract_10k      | 1    | 3   | 4.795mb +0.01%  | 419.110ms +0.45% | ±1.54% +106.40% |
| ExcelExtractorBench   | bench_extract_10k_ods  | 1    | 3   | 65.506mb +0.00% | 1.042s -1.30%    | ±0.42% -11.86%  |
| ExcelExtractorBench   | bench_extract_10k_xlsx | 1    | 3   | 67.552mb +0.00% | 1.666s -1.16%    | ±0.51% -19.83%  |
| JsonExtractorBench    | bench_extract_10k      | 1    | 3   | 5.080mb +0.01%  | 1.160s -0.11%    | ±0.22% -86.04%  |
| ParquetExtractorBench | bench_extract_10k      | 1    | 3   | 86.350mb +0.00% | 907.025ms -1.35% | ±0.69% -68.16%  |
| TextExtractorBench    | bench_extract_10k      | 1    | 3   | 4.526mb +0.01%  | 38.778ms +1.64%  | ±0.20% -82.85%  |
| XmlExtractorBench     | bench_extract_10k      | 1    | 3   | 4.521mb +0.01%  | 605.468ms +0.57% | ±1.28% +128.20% |
+-----------------------+------------------------+------+-----+-----------------+------------------+-----------------+
Transformers
+---------------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                       | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+---------------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEachEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 18.525mb +0.00%  | 74.372ms +3.62% | ±1.34% +68.42% |
| RenameEntryTransformerBench     | bench_transform_10k_rows | 1    | 3   | 123.263mb +0.00% | 63.803ms -1.26% | ±0.74% +3.58%  |
+---------------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev         |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 62.455mb +0.00%  | 83.422ms -1.31%  | ±0.61% -76.34% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 79.757mb +0.00%  | 101.371ms +2.06% | ±0.61% -5.03%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 166.232mb +0.00% | 20.676s +0.37%   | ±0.36% +58.89% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.833mb +0.00%  | 30.609ms -0.18%  | ±0.13% -92.29% |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
Building Blocks
+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark         | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| TypeDetectorBench | bench_type_detector        | 1    | 3   | 42.098mb +0.00%  | 424.931ms -0.45% | ±0.20% -69.00%  |
| TypeDetectorBench | bench_type_detector        | 1    | 3   | 11.476mb +0.00%  | 85.465ms +1.00%  | ±0.60% +116.13% |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 101.804mb +0.00% | 646.038ms -0.04% | ±0.31% -69.86%  |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 53.155mb +0.00%  | 323.337ms -2.62% | ±1.61% +61.97%  |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.405mb +0.00%  | 68.827ms -2.76%  | ±2.05% +58.89%  |
| RowsBench         | bench_chunk_10_on_10k      | 2    | 3   | 93.416mb +0.00%  | 3.385ms +5.32%   | ±3.33% +139.39% |
| RowsBench         | bench_diff_left_1k_on_10k  | 2    | 3   | 110.787mb +0.00% | 237.813ms +0.62% | ±0.31% -62.11%  |
| RowsBench         | bench_diff_right_1k_on_10k | 2    | 3   | 93.507mb +0.00%  | 23.777ms +0.68%  | ±0.12% -67.38%  |
| RowsBench         | bench_drop_1k_on_10k       | 2    | 3   | 94.291mb +0.00%  | 1.458ms +15.42%  | ±2.29% -30.29%  |
| RowsBench         | bench_drop_right_1k_on_10k | 2    | 3   | 94.291mb +0.00%  | 1.449ms +13.60%  | ±2.63% +11.03%  |
| RowsBench         | bench_entries_on_10k       | 2    | 3   | 92.452mb +0.00%  | 3.506ms +0.64%   | ±1.05% +10.62%  |
| RowsBench         | bench_filter_on_10k        | 2    | 3   | 92.981mb +0.00%  | 15.651ms +0.67%  | ±0.36% -74.34%  |
| RowsBench         | bench_find_on_10k          | 2    | 3   | 92.981mb +0.00%  | 15.360ms -0.81%  | ±0.64% +72.27%  |
| RowsBench         | bench_find_one_on_10k      | 10   | 3   | 91.670mb +0.00%  | 1.800μs -9.73%   | ±0.00% -100.00% |
| RowsBench         | bench_first_on_10k         | 10   | 3   | 91.670mb +0.00%  | 0.300μs -25.00%  | ±0.00% -100.00% |
| RowsBench         | bench_flat_map_on_1k       | 2    | 3   | 100.730mb +0.00% | 13.919ms -1.76%  | ±1.17% -62.87%  |
| RowsBench         | bench_map_on_10k           | 2    | 3   | 130.157mb +0.00% | 64.669ms -3.19%  | ±0.16% -92.79%  |
| RowsBench         | bench_merge_1k_on_10k      | 2    | 3   | 93.501mb +0.00%  | 1.397ms +24.29%  | ±0.94% -6.62%   |
| RowsBench         | bench_partition_by_on_10k  | 2    | 3   | 96.870mb +0.00%  | 62.105ms +0.21%  | ±0.28% -63.24%  |
| RowsBench         | bench_remove_on_10k        | 2    | 3   | 94.553mb +0.00%  | 3.424ms -2.64%   | ±0.66% -61.17%  |
| RowsBench         | bench_sort_asc_on_1k       | 2    | 3   | 92.032mb +0.00%  | 39.613ms +0.16%  | ±0.82% -52.29%  |
| RowsBench         | bench_sort_by_on_1k        | 2    | 3   | 92.032mb +0.00%  | 39.796ms -0.47%  | ±1.05% -21.06%  |
| RowsBench         | bench_sort_desc_on_1k      | 2    | 3   | 92.032mb +0.00%  | 39.868ms +0.36%  | ±1.12% +99.85%  |
| RowsBench         | bench_sort_entries_on_1k   | 2    | 3   | 94.113mb +0.00%  | 8.105ms +1.98%   | ±0.76% -39.53%  |
| RowsBench         | bench_sort_on_1k           | 2    | 3   | 91.862mb +0.00%  | 29.863ms -0.68%  | ±2.03% +224.37% |
| RowsBench         | bench_take_1k_on_10k       | 10   | 3   | 91.670mb +0.00%  | 13.688μs +1.60%  | ±0.69% -80.15%  |
| RowsBench         | bench_take_right_1k_on_10k | 10   | 3   | 91.670mb +0.00%  | 15.388μs -2.11%  | ±0.61% -43.44%  |
| RowsBench         | bench_unique_on_1k         | 2    | 3   | 110.788mb +0.00% | 243.262ms +1.10% | ±0.68% +43.24%  |
+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@codecov
Copy link

codecov bot commented Jun 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.91%. Comparing base (d827489) to head (7e0ffa2).
Report is 1 commits behind head on 1.x.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##              1.x    #1724   +/-   ##
=======================================
  Coverage   81.91%   81.91%           
=======================================
  Files         710      710           
  Lines       19325    19325           
=======================================
  Hits        15830    15830           
  Misses       3495     3495           
Components Coverage Δ
etl 88.36% <ø> (ø)
cli 84.42% <ø> (ø)
lib-array-dot 94.53% <ø> (ø)
lib-azure-sdk 62.56% <ø> (ø)
lib-doctrine-dbal-bulk 93.49% <ø> (ø)
lib-filesystem 78.02% <ø> (ø)
lib-types 54.82% <ø> (ø)
lib-parquet 84.37% <ø> (ø)
lib-parquet-viewer 82.02% <ø> (ø)
lib-snappy 90.69% <ø> (ø)
bridge-filesystem-async-aws 90.38% <ø> (ø)
bridge-filesystem-azure 89.92% <ø> (ø)
bridge-monolog-http 98.11% <ø> (ø)
symfony-http-foundation 74.41% <ø> (ø)
adapter-chartjs 86.45% <ø> (ø)
adapter-csv 90.37% <ø> (ø)
adapter-doctrine 89.95% <100.00%> (ø)
adapter-elasticsearch 97.19% <ø> (ø)
adapter-google-sheet 83.87% <ø> (ø)
adapter-http 59.15% <ø> (ø)
adapter-json 90.62% <ø> (ø)
adapter-logger 53.84% <ø> (ø)
adapter-meilisearch 97.75% <ø> (ø)
adapter-parquet 78.64% <ø> (ø)
adapter-text 84.44% <ø> (ø)
adapter-xml 83.15% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@norberttech norberttech merged commit 4bd62a7 into 1.x Jun 21, 2025
20 checks passed
@norberttech norberttech deleted the bug/key-set-pagination-alias-length branch June 21, 2025 14:41
@github-project-automation github-project-automation bot moved this from In Progress to Done in Roadmap Jun 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants