Skip to content

Conversation

@norberttech
Copy link
Member

Resolves: #1728

Change Log


Added

  • class-string type to types library

Fixed

Changed

Removed

Deprecated

Security

@norberttech norberttech linked an issue Jun 24, 2025 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2025

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+------------------------+------+-----+-----------------+------------------+-----------------+
| benchmark             | subject                | revs | its | mem_peak        | mode             | rstdev          |
+-----------------------+------------------------+------+-----+-----------------+------------------+-----------------+
| CSVExtractorBench     | bench_extract_10k      | 1    | 3   | 4.799mb +0.09%  | 417.123ms +0.23% | ±0.69% +80.59%  |
| ExcelExtractorBench   | bench_extract_10k_ods  | 1    | 3   | 65.510mb +0.01% | 1.045s -0.23%    | ±0.64% +165.95% |
| ExcelExtractorBench   | bench_extract_10k_xlsx | 1    | 3   | 67.555mb +0.01% | 1.709s +1.68%    | ±1.88% +152.90% |
| JsonExtractorBench    | bench_extract_10k      | 1    | 3   | 5.083mb +0.08%  | 1.149s -1.14%    | ±0.92% +15.38%  |
| ParquetExtractorBench | bench_extract_10k      | 1    | 3   | 86.353mb +0.00% | 915.366ms -0.31% | ±1.46% +216.70% |
| TextExtractorBench    | bench_extract_10k      | 1    | 3   | 4.530mb +0.09%  | 38.786ms +0.94%  | ±1.33% +224.71% |
| XmlExtractorBench     | bench_extract_10k      | 1    | 3   | 4.525mb +0.09%  | 596.248ms -1.92% | ±1.23% -11.19%  |
+-----------------------+------------------------+------+-----+-----------------+------------------+-----------------+
Transformers
+---------------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| benchmark                       | subject                  | revs | its | mem_peak         | mode            | rstdev          |
+---------------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
| RenameEachEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 18.529mb +0.02%  | 74.081ms +0.48% | ±1.36% +24.40%  |
| RenameEntryTransformerBench     | bench_transform_10k_rows | 1    | 3   | 123.267mb +0.00% | 65.629ms -0.18% | ±1.99% +147.93% |
+---------------------------------+--------------------------+------+-----+------------------+-----------------+-----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 62.459mb +0.01%  | 86.024ms +0.18%  | ±1.74% -4.75%   |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 79.760mb +0.01%  | 102.124ms -1.47% | ±0.95% -29.27%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 166.236mb +0.00% | 21.005s +1.73%   | ±0.53% +35.12%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.836mb +0.02%  | 30.686ms -0.76%  | ±2.83% +276.65% |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark         | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| TypeDetectorBench | bench_type_detector        | 1    | 3   | 42.102mb +0.01%  | 425.506ms -0.33% | ±0.25% -52.26%  |
| TypeDetectorBench | bench_type_detector        | 1    | 3   | 11.479mb +0.04%  | 85.896ms -0.59%  | ±0.22% -30.22%  |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 101.808mb +0.00% | 658.560ms +0.95% | ±1.25% +213.16% |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 53.159mb +0.01%  | 329.265ms +0.91% | ±0.39% -25.47%  |
| EntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.409mb +0.03%  | 70.365ms -1.80%  | ±0.95% -32.63%  |
| RowsBench         | bench_chunk_10_on_10k      | 2    | 3   | 93.420mb +0.00%  | 3.924ms +2.35%   | ±1.72% -36.58%  |
| RowsBench         | bench_diff_left_1k_on_10k  | 2    | 3   | 110.791mb +0.00% | 238.443ms -0.72% | ±0.64% +17.96%  |
| RowsBench         | bench_diff_right_1k_on_10k | 2    | 3   | 93.511mb +0.00%  | 24.102ms +0.86%  | ±0.43% -61.65%  |
| RowsBench         | bench_drop_1k_on_10k       | 2    | 3   | 94.295mb +0.00%  | 2.079ms +11.42%  | ±1.98% -13.23%  |
| RowsBench         | bench_drop_right_1k_on_10k | 2    | 3   | 94.295mb +0.00%  | 1.793ms -1.29%   | ±2.55% +6.86%   |
| RowsBench         | bench_entries_on_10k       | 2    | 3   | 92.456mb +0.00%  | 3.761ms +3.02%   | ±1.77% +368.25% |
| RowsBench         | bench_filter_on_10k        | 2    | 3   | 92.985mb +0.00%  | 15.860ms -2.68%  | ±0.60% +46.33%  |
| RowsBench         | bench_find_on_10k          | 2    | 3   | 92.985mb +0.00%  | 16.176ms -0.30%  | ±0.24% -70.80%  |
| RowsBench         | bench_find_one_on_10k      | 10   | 3   | 91.673mb +0.00%  | 2.100μs +5.00%   | ±0.00% 0.00%    |
| RowsBench         | bench_first_on_10k         | 10   | 3   | 91.673mb +0.00%  | 0.500μs +25.00%  | ±0.00% -100.00% |
| RowsBench         | bench_flat_map_on_1k       | 2    | 3   | 100.734mb +0.00% | 14.572ms -0.37%  | ±1.95% +17.31%  |
| RowsBench         | bench_map_on_10k           | 2    | 3   | 130.161mb +0.00% | 70.268ms +3.92%  | ±0.22% -79.29%  |
| RowsBench         | bench_merge_1k_on_10k      | 2    | 3   | 93.504mb +0.00%  | 1.747ms +0.88%   | ±0.48% -74.95%  |
| RowsBench         | bench_partition_by_on_10k  | 2    | 3   | 96.873mb +0.00%  | 64.912ms +1.72%  | ±1.09% +185.11% |
| RowsBench         | bench_remove_on_10k        | 2    | 3   | 94.557mb +0.00%  | 4.095ms -1.74%   | ±3.40% +535.20% |
| RowsBench         | bench_sort_asc_on_1k       | 2    | 3   | 92.036mb +0.00%  | 40.622ms +1.50%  | ±2.79% +151.83% |
| RowsBench         | bench_sort_by_on_1k        | 2    | 3   | 92.036mb +0.00%  | 41.165ms +2.08%  | ±1.03% -5.71%   |
| RowsBench         | bench_sort_desc_on_1k      | 2    | 3   | 92.036mb +0.00%  | 40.309ms -1.23%  | ±1.31% +79.65%  |
| RowsBench         | bench_sort_entries_on_1k   | 2    | 3   | 94.116mb +0.00%  | 8.311ms +0.75%   | ±1.07% +305.79% |
| RowsBench         | bench_sort_on_1k           | 2    | 3   | 91.866mb +0.00%  | 30.161ms +1.30%  | ±1.00% +24.58%  |
| RowsBench         | bench_take_1k_on_10k       | 10   | 3   | 91.673mb +0.00%  | 14.706μs -0.61%  | ±0.32% -88.43%  |
| RowsBench         | bench_take_right_1k_on_10k | 10   | 3   | 91.673mb +0.00%  | 17.400μs +5.56%  | ±0.00% -100.00% |
| RowsBench         | bench_unique_on_1k         | 2    | 3   | 110.792mb +0.00% | 241.995ms -0.29% | ±0.08% -80.34%  |
+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@codecov
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 38 lines in your changes missing coverage. Please review.

Project coverage is 81.62%. Comparing base (52096ec) to head (a59bf99).
Report is 5 commits behind head on 1.x.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##              1.x    #1730      +/-   ##
==========================================
- Coverage   81.93%   81.62%   -0.31%     
==========================================
  Files         712      714       +2     
  Lines       19343    19416      +73     
==========================================
+ Hits        15848    15849       +1     
- Misses       3495     3567      +72     
Components Coverage Δ
etl 88.39% <ø> (ø)
cli 84.42% <ø> (ø)
lib-array-dot 94.53% <ø> (ø)
lib-azure-sdk 62.56% <ø> (ø)
lib-doctrine-dbal-bulk 93.49% <ø> (ø)
lib-filesystem 78.02% <ø> (ø)
lib-types 52.04% <0.00%> (-2.78%) ⬇️
lib-parquet 84.37% <ø> (ø)
lib-parquet-viewer 82.02% <ø> (ø)
lib-snappy 91.16% <ø> (+0.46%) ⬆️
bridge-filesystem-async-aws 90.38% <ø> (ø)
bridge-filesystem-azure 89.92% <ø> (ø)
bridge-monolog-http 98.11% <ø> (ø)
symfony-http-foundation 74.41% <ø> (ø)
adapter-chartjs 86.45% <ø> (ø)
adapter-csv 90.37% <ø> (ø)
adapter-doctrine 89.95% <ø> (ø)
adapter-elasticsearch 97.19% <ø> (ø)
adapter-google-sheet 83.87% <ø> (ø)
adapter-http 59.15% <ø> (ø)
adapter-json 90.62% <ø> (ø)
adapter-logger 53.84% <ø> (ø)
adapter-meilisearch 97.75% <ø> (ø)
adapter-parquet 78.64% <ø> (ø)
adapter-text 84.44% <ø> (ø)
adapter-xml 83.15% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@norberttech norberttech enabled auto-merge (squash) June 24, 2025 15:01
@norberttech norberttech force-pushed the 1728-proposal-classstringtype branch from 06db0d9 to a59bf99 Compare June 24, 2025 15:04
@norberttech norberttech disabled auto-merge June 24, 2025 15:07
@norberttech norberttech merged commit 1f010ce into 1.x Jun 24, 2025
20 checks passed
@norberttech norberttech deleted the 1728-proposal-classstringtype branch June 24, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Proposal]: ClassStringType

2 participants