Skip to content

Conversation

@norberttech
Copy link
Member

Resolves: #1905

Change Log


Added

  • support for php 8.5

Fixed

Changed

Removed

Deprecated

Security

@norberttech norberttech added the dependencies Pull requests that update a dependency file label Oct 24, 2025
@norberttech
Copy link
Member Author

norberttech commented Oct 24, 2025

it seems that not all of our dependencies are ready for 8.5 support:

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.66%. Comparing base (ca8d0e9) to head (e1d0e02).
⚠️ Report is 7 commits behind head on 1.x.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##              1.x    #1906      +/-   ##
==========================================
+ Coverage   83.39%   83.66%   +0.26%     
==========================================
  Files        1041     1017      -24     
  Lines       37842    37268     -574     
==========================================
- Hits        31560    31181     -379     
+ Misses       6282     6087     -195     
Components Coverage Δ
etl 88.50% <ø> (+1.08%) ⬆️
cli 85.76% <ø> (-0.20%) ⬇️
lib-array-dot 95.00% <ø> (ø)
lib-azure-sdk 60.01% <ø> (-0.38%) ⬇️
lib-doctrine-dbal-bulk 95.14% <ø> (ø)
lib-filesystem 80.44% <ø> (-0.25%) ⬇️
lib-types 89.17% <ø> (+1.42%) ⬆️
lib-parquet 68.25% <ø> (-0.11%) ⬇️
lib-parquet-viewer 83.04% <100.00%> (ø)
lib-snappy 90.18% <ø> (+0.46%) ⬆️
bridge-filesystem-async-aws 90.95% <ø> (-0.05%) ⬇️
bridge-filesystem-azure 89.38% <ø> (-0.09%) ⬇️
bridge-monolog-http 96.89% <ø> (-0.02%) ⬇️
bridge-openapi-specification 94.50% <ø> (-0.06%) ⬇️
symfony-http-foundation 72.32% <ø> (-0.85%) ⬇️
adapter-chartjs 86.33% <ø> (-0.04%) ⬇️
adapter-csv 89.30% <ø> (+0.22%) ⬆️
adapter-doctrine 91.50% <ø> (+0.53%) ⬆️
adapter-elasticsearch 97.02% <ø> (-0.16%) ⬇️
adapter-google-sheet 97.05% <ø> (+5.65%) ⬆️
adapter-http 65.94% <ø> (-1.42%) ⬇️
adapter-json 89.69% <ø> (-0.12%) ⬇️
adapter-logger 83.33% <ø> (ø)
adapter-meilisearch 97.77% <ø> (-0.10%) ⬇️
adapter-parquet 79.63% <ø> (+1.33%) ⬆️
adapter-text 86.84% <ø> (-1.26%) ⬇️
adapter-xml 82.66% <ø> (-0.41%) ⬇️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@norberttech norberttech marked this pull request as draft November 10, 2025 13:16
@norberttech
Copy link
Member Author

Once halaxa/json-machine#127 is merged we can move forward with this one!

@Buffele
Copy link

Buffele commented Dec 8, 2025

https://github.com/halaxa/json-machine/blob/1.2.6/CHANGELOG.md

Has been released with 8.5 support.

Could you merge this please and publish a new release? This dependency is blocking me from upgrading my stack to 8.5.

@norberttech
Copy link
Member Author

Hey @Buffele I'm thinking about brining basic support for 8.5 (meaning that composer wont block it) in next few days.
But Full migration, I'm afraid this will take a bit longer, I need also to upgrade whole codebase to 8.3, go through all github workflows (make sure they also work on 8.3 only)

So in other words those are still blockers:

  • upgrade codebase to 8.3
  • drop support for 8.2
  • compile WASM on 8.5
  • update Dockerfile and (need to move installation to pie)
  • update our nix shell

@drupol how far is your PR bringing 8.5 from being merged to nixpgs?

@drupol
Copy link
Contributor

drupol commented Dec 8, 2025

@drupol how far is your PR bringing 8.5 from being merged to nixpgs?

The PR is made since quite a while now... waiting for people to review it. Feel free to test it and provide some feedback.

@norberttech
Copy link
Member Author

@drupol how far is your PR bringing 8.5 from being merged to nixpgs?

The PR is made since quite a while now... waiting for people to review it. Feel free to test it and provide some feedback.

I'm more than happy to help in any way that is needed to get this one merged!

To test this PR I just need to point my nix shell towards your fork and commit that brings 8.5?

@drupol
Copy link
Contributor

drupol commented Dec 8, 2025

To test this PR I just need to point my nix shell towards your fork and commit that brings 8.5?

There are many ways to do that and this is a valid way to achieve this indeed.

@Buffele
Copy link

Buffele commented Dec 8, 2025

Hey @Buffele I'm thinking about brining basic support for 8.5 (meaning that composer wont block it) in next few days.

Thanks for your quick reply.

Basic support is completely fine with me. As long as I can run composer install and bump the minimum php version without worries.

Thanks!

@norberttech norberttech force-pushed the 1905-task-add-support-for-php-85 branch from ed0c8df to 7465a19 Compare December 11, 2025 21:33
@norberttech norberttech force-pushed the 1905-task-add-support-for-php-85 branch from 756fa88 to aeae651 Compare December 11, 2025 22:15
- drop 8.2 from nix shell
- added 8.5 from nixpkgs PR
- updated php extension in nix pkgs
- added composer build:docker script
- added missing extensions to Dockerfile installation
@norberttech
Copy link
Member Author

@drupol everything seems to be working fine, at last on my MacBook 😅🎉

@Buffele I managed to get it all work, 0.29.0 will be released on Monday and it will drop support for PHP 8.2 adding support for 8.5 at the same time

@norberttech norberttech marked this pull request as ready for review December 12, 2025 00:10
@norberttech norberttech merged commit 1d4c142 into 1.x Dec 12, 2025
22 checks passed
@norberttech norberttech deleted the 1905-task-add-support-for-php-85 branch December 12, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file size: M size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Add support for PHP 8.5

4 participants