Skip to content

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented Nov 5, 2025

Resolves: #1952

Change Log


Added

Fixed

Changed

  • Move JSON & Uuid validation out of `StringTypeNarrower`

Removed

Deprecated

Security

@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

❌ Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.78%. Comparing base (29efaa1) to head (e13532d).
⚠️ Report is 3 commits behind head on 1.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              1.x    #1958      +/-   ##
==========================================
- Coverage   79.78%   79.78%   -0.01%     
==========================================
  Files         834      834              
  Lines       24779    24774       -5     
==========================================
- Hits        19771    19767       -4     
+ Misses       5008     5007       -1     
Components Coverage Δ
etl 88.90% <ø> (ø)
cli 85.96% <ø> (ø)
lib-array-dot 95.00% <ø> (ø)
lib-azure-sdk 60.39% <ø> (ø)
lib-doctrine-dbal-bulk 95.14% <ø> (ø)
lib-filesystem 80.68% <ø> (ø)
lib-types 89.53% <90.00%> (+0.02%) ⬆️
lib-parquet 68.35% <ø> (ø)
lib-parquet-viewer 83.04% <ø> (ø)
lib-snappy 90.18% <ø> (ø)
bridge-filesystem-async-aws 91.00% <ø> (ø)
bridge-filesystem-azure 89.47% <ø> (ø)
bridge-monolog-http 96.91% <ø> (ø)
bridge-openapi-specification 94.50% <ø> (ø)
symfony-http-foundation 73.17% <ø> (ø)
adapter-chartjs 86.36% <ø> (ø)
adapter-csv 89.08% <ø> (ø)
adapter-doctrine 90.97% <ø> (ø)
adapter-elasticsearch 97.17% <ø> (ø)
adapter-google-sheet 91.40% <ø> (ø)
adapter-http 60.56% <ø> (ø)
adapter-json 89.80% <ø> (ø)
adapter-logger 83.33% <ø> (ø)
adapter-meilisearch 97.87% <ø> (ø)
adapter-parquet 78.91% <ø> (ø)
adapter-text 88.09% <ø> (ø)
adapter-xml 83.07% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@norberttech norberttech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not whole json validation is covered with unit tests (that's why CI/CD complains)

Also please look at who is assigned to a task/issue 😅 this one was actually assigned to @MrHDOLEK

@stloyd stloyd requested a review from norberttech November 5, 2025 19:21
@norberttech norberttech merged commit d519b9f into flow-php:1.x Nov 5, 2025
17 checks passed
@norberttech
Copy link
Member

Sweet <3

@stloyd stloyd deleted the task/1952 branch November 5, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Proposal]: Move type validation into types from other places

2 participants