Skip to content

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented Nov 6, 2025

Resolves: #1915

Change Log


Added

  • Add `HTMLQuerySelectorAll` & `HTMLQuerySelector` scalar functions

Fixed

Changed

  • `HTMLType & `HTMLEntry` require now `\Dom\HTMLDocument`

Removed

Deprecated

Security

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 63.26531% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.09%. Comparing base (4ee6990) to head (70a947f).
⚠️ Report is 2 commits behind head on 1.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              1.x    #1960      +/-   ##
==========================================
- Coverage   79.37%   79.09%   -0.29%     
==========================================
  Files         837      839       +2     
  Lines       24959    24952       -7     
==========================================
- Hits        19812    19735      -77     
- Misses       5147     5217      +70     
Components Coverage Δ
etl 88.24% <26.31%> (-0.68%) ⬇️
cli 85.96% <ø> (ø)
lib-array-dot 95.00% <ø> (ø)
lib-azure-sdk 60.39% <ø> (ø)
lib-doctrine-dbal-bulk 95.14% <ø> (ø)
lib-filesystem 80.68% <ø> (ø)
lib-types 88.23% <86.66%> (-1.31%) ⬇️
lib-parquet 68.35% <ø> (ø)
lib-parquet-viewer 83.04% <ø> (ø)
lib-snappy 89.71% <ø> (-0.47%) ⬇️
bridge-filesystem-async-aws 91.00% <ø> (ø)
bridge-filesystem-azure 89.47% <ø> (ø)
bridge-monolog-http 96.91% <ø> (ø)
bridge-openapi-specification 94.50% <ø> (ø)
symfony-http-foundation 73.17% <ø> (ø)
adapter-chartjs 86.36% <ø> (ø)
adapter-csv 89.08% <ø> (ø)
adapter-doctrine 90.97% <ø> (ø)
adapter-elasticsearch 97.17% <ø> (ø)
adapter-google-sheet 91.40% <ø> (ø)
adapter-http 60.56% <ø> (ø)
adapter-json 89.80% <ø> (ø)
adapter-logger 83.33% <ø> (ø)
adapter-meilisearch 97.87% <ø> (ø)
adapter-parquet 78.91% <ø> (ø)
adapter-text 88.09% <ø> (ø)
adapter-xml 83.07% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stloyd
Copy link
Member Author

stloyd commented Nov 6, 2025

Coverage is a lie, as it runs on 8.2, but only part of the test is run on 8.4.

@norberttech
Copy link
Member

Both scalar functions must come with integration tests (like all other scalar functions) that shows how this works with a full pipeline

@stloyd stloyd force-pushed the task/1915-html-fn branch 2 times, most recently from 192ba6d to 709d414 Compare November 8, 2025 15:29
@stloyd stloyd requested a review from norberttech November 8, 2025 17:27
@stloyd stloyd force-pushed the task/1915-html-fn branch from e985ea8 to 5f3407e Compare November 9, 2025 08:27
@stloyd stloyd requested a review from norberttech November 9, 2025 08:33
@stloyd stloyd force-pushed the task/1915-html-fn branch from 5f3407e to 54625ff Compare November 9, 2025 11:14
@stloyd stloyd removed the size: L label Nov 9, 2025
@norberttech norberttech merged commit 528121b into flow-php:1.x Nov 9, 2025
16 of 18 checks passed
@stloyd stloyd deleted the task/1915-html-fn branch November 9, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: HTML Scalar Functions

2 participants