-
-
Notifications
You must be signed in to change notification settings - Fork 48
Add HTMLQuerySelectorAll & HTMLQuerySelector scalar functions
#1960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1.x #1960 +/- ##
==========================================
- Coverage 79.37% 79.09% -0.29%
==========================================
Files 837 839 +2
Lines 24959 24952 -7
==========================================
- Hits 19812 19735 -77
- Misses 5147 5217 +70
🚀 New features to boost your workflow:
|
|
Coverage is a lie, as it runs on 8.2, but only part of the test is run on 8.4. |
|
Both scalar functions must come with integration tests (like all other scalar functions) that shows how this works with a full pipeline |
src/core/etl/tests/Flow/ETL/Tests/Integration/Function/HTMLQuerySelectorAllTest.php
Show resolved
Hide resolved
6de9723 to
92e7c14
Compare
d5b2eb9 to
9b89271
Compare
f9bf415 to
0156e72
Compare
192ba6d to
709d414
Compare
e985ea8 to
5f3407e
Compare
5f3407e to
54625ff
Compare
Resolves: #1915
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security