Skip to content

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented Apr 8, 2023

Change Log

Added

  • Added `HashIdFactory` into Elastic adapter
  • Added `ext-hash` PHP extension as required for Flow

Fixed

Changed

  • Replaced usage of `md5()` with `xxh128` hash algorithm

Removed

Deprecated

  • Deprecated `Sha1IdFactory` in favor of `HashIdFactory`

Security


Description

According to: https://php.watch/articles/php-hash-benchmark, xxh128 algorithm is way more efficient compared to md5 or sha1 ones.

@norberttech norberttech merged commit e218ee9 into flow-php:1.x Apr 9, 2023
@norberttech
Copy link
Member

Nice one!! Thanks 🙏

@stloyd stloyd deleted the hashid branch April 9, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants