Skip to content

Adjust string value extraction in ASCIIValue #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
norberttech merged 2 commits into from
May 3, 2023
Merged

Adjust string value extraction in ASCIIValue #418

norberttech merged 2 commits into from
May 3, 2023

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented May 3, 2023 •
edited
Loading

Change Log

Added

Fixed

Changed

  • Adjust string value extraction in ASCIIValue to match PHP docs

Removed

Deprecated

Security

Description

According to PHP docs about gettype(), it will never return a false value, but it will be double instead.

@stloyd
Copy link
Member Author

stloyd commented May 3, 2023

In future, it may be useful to consider using get_debug_type() instead of gettype().

@norberttech norberttech merged commit 9cf7bcb into flow-php:1.x May 3, 2023
@stloyd stloyd deleted the patch-1 branch May 3, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size: XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stloyd @norberttech