-
-
Notifications
You must be signed in to change notification settings - Fork 48
Added better support for XML types into Flow #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
stloyd
reviewed
Sep 5, 2023
src/core/etl/src/Flow/ETL/Row/Reference/Expression/Cast/XMLConverter.php
Outdated
Show resolved
Hide resolved
stloyd
reviewed
Sep 5, 2023
stloyd
reviewed
Sep 5, 2023
src/core/etl/src/Flow/ETL/Row/Reference/Expression/Cast/XMLConverter.php
Show resolved
Hide resolved
src/core/etl/src/Flow/ETL/Row/Reference/Expression/Cast/XMLConverter.php
Outdated
Show resolved
Hide resolved
Contributor
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Member
Author
|
@stloyd @JacekPolanski thanks for review 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security
Description
The goal of this PR is to make XMLReaderExtractor consistent with Extractors architecture.
Originally it was reading XML and transforming NodeElements into arrays, this was heavily inspired by Spark however it was adding transformation responsibility to the Extractor.
This PR changes that (which is a minor BC break) and from now XMLReaderExtractor is throwing XMLEntry which can be later transformer using dedicated XML transformers.
Following code explains how this can be done:
XML
Code:
Output: