Skip to content

Conversation

@szepeviktor
Copy link
Contributor

Change Log

Added

Fixed

  • Corrected misspellings

Changed

Removed

Deprecated

Security


Description

Found some misspellings.

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Oct 7, 2023

Please consider running typos in CI.
Here is the configuration used.

.typos.toml

[files]
extend-exclude = [
    ".git/",
    "CHANGELOG.md",
]
ignore-hidden = false

[default]
extend-ignore-re = [
    '"nam |',
    '"country_code": "[A-Z]{2}",',
    "\\['nam.e'\\],",
    "- \\[[0-9a-z]{6}\\]\\(https://github\\.com/flow-php/flow",
    "'BA', 'AB',",
    "range `BA`",
    "Mata-Utu",
]

@norberttech
Copy link
Member

Thanks! However, could you please revert the changes on the changelog? CHANGELOG.md is auto-generated from pull requests/commits. Correcting it won't give us much since it will be replaced the next time we regenerate it.

@szepeviktor
Copy link
Contributor Author

please revert the changes on the changelog

Done.

@norberttech norberttech enabled auto-merge (squash) October 7, 2023 11:54
@norberttech norberttech merged commit f7cb798 into flow-php:1.x Oct 7, 2023
@szepeviktor szepeviktor deleted the fix-typos branch October 7, 2023 12:01
@szepeviktor
Copy link
Contributor Author

szepeviktor commented Oct 7, 2023

@norberttech Please consider changing a few PR's typos.
e.g. #153

@norberttech
Copy link
Member

Yup, it's on my todo list 👍 A GitHub workflow action that would go through PR changelog section looking for typos would be nice to have

@szepeviktor
Copy link
Contributor Author

that would go through PR changelog section looking for typos

You can see those typos in the last commit here.

@norberttech
Copy link
Member

yeah, but that won't prevent people (and me) from making more typos in the future, it's a one-time cleanup that I will do (eventually) but would be nice to not have to go through this again

@szepeviktor
Copy link
Contributor Author

What fields should be checked in a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants