Skip to content

Funky oz bugfix/xml adapter deep handler #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
norberttech merged 3 commits into from
Oct 16, 2023
Merged

Funky oz bugfix/xml adapter deep handler #593

norberttech merged 3 commits into from
Oct 16, 2023

Conversation

@norberttech
Copy link
Member

@norberttech norberttech commented Oct 16, 2023 •
edited
Loading

Change Log

Added

Fixed

  • Change behavior of xml adapter when xml->deep > 1 and previousDeep > xml->deep

Changed

Removed

Deprecated

Security

Description

Resolves #590

@norberttech norberttech mentioned this pull request Oct 16, 2023
Closed
@norberttech norberttech enabled auto-merge (squash) October 16, 2023 12:46
@norberttech norberttech disabled auto-merge October 16, 2023 12:47
@norberttech norberttech merged commit f030fe3 into flow-php:1.x Oct 16, 2023
@norberttech
Copy link
Member Author

norberttech commented Oct 16, 2023

Thanks again @FunkyOz! 🙌
For your static analyze issues, you might want check if you are executing this task with PHP 8.1.
Our approach is to execute static analyze/mutation tests and benchmarks on lowest supported PHP version and this is the version you should have installed locally.

@norberttech norberttech deleted the FunkyOz-bugfix/xml-adapter-deep-handler branch December 5, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size: XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

XML depth/previousDepth are not correctly handled

2 participants

@norberttech @FunkyOz