Skip to content

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented Oct 27, 2023

Change Log

Added

Fixed

Changed

  • Adjust Rows::chunk() to work on generators instead of arrays

Removed

Deprecated

Security


Description

Old:

+-----------------------------+--------------------------+------+-----+-----------+-----------+
| benchmark                   | subject                  | revs | its | mem_peak  | mode      |
+-----------------------------+--------------------------+------+-----+-----------+-----------+
| RowsBench                   | bench_chunk_10           | 5    | 5   | 60.408mb  | 3.335ms   |
+-----------------------------+--------------------------+------+-----+-----------+-----------+

New:

+-----------------------------+--------------------------+------+-----+-----------+-----------+
| benchmark                   | subject                  | revs | its | mem_peak  | mode      |
+-----------------------------+--------------------------+------+-----+-----------+-----------+
| RowsBench                   | bench_chunk_10           | 5    | 5   | 57.885mb  | 1.600μs   |
+-----------------------------+--------------------------+------+-----+-----------+-----------+

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2023

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+-----------+-----------+
| benchmark             | subject           | revs | its | mem_peak  | mode      |
+-----------------------+-------------------+------+-----+-----------+-----------+
| AvroExtractorBench    | bench_extract_10k | 5    | 3   | 44.122mb  | 394.641ms |
| CSVExtractorBench     | bench_extract_10k | 5    | 3   | 14.006mb  | 319.053ms |
| JsonExtractorBench    | bench_extract_10k | 5    | 3   | 18.668mb  | 619.898ms |
| ParquetExtractorBench | bench_extract_10k | 5    | 3   | 237.792mb | 895.615ms |
| TextExtractorBench    | bench_extract_10k | 5    | 3   | 7.276mb   | 12.985ms  |
| XmlExtractorBench     | bench_extract_10k | 5    | 3   | 7.624mb   | 552.191ms |
+-----------------------+-------------------+------+-----+-----------+-----------+
Transformers
+-----------------------------+--------------------------+------+-----+----------+----------+
| benchmark                   | subject                  | revs | its | mem_peak | mode     |
+-----------------------------+--------------------------+------+-----+----------+----------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 5    | 5   | 87.063mb | 55.140ms |
+-----------------------------+--------------------------+------+-----+----------+----------+
Loaders
+--------------------+----------------+------+-----+-----------+-----------+
| benchmark          | subject        | revs | its | mem_peak  | mode      |
+--------------------+----------------+------+-----+-----------+-----------+
| AvroLoaderBench    | bench_load_10k | 5    | 3   | 219.957mb | 621.365ms |
| CSVLoaderBench     | bench_load_10k | 5    | 3   | 47.141mb  | 62.529ms  |
| JsonLoaderBench    | bench_load_10k | 5    | 3   | 88.581mb  | 64.133ms  |
| ParquetLoaderBench | bench_load_10k | 5    | 3   | 281.202mb | 880.645ms |
| TextLoaderBench    | bench_load_10k | 5    | 3   | 16.568mb  | 32.246ms  |
+--------------------+----------------+------+-----+-----------+-----------+
Building Blocks
+-------------------------+----------------+------+-----+----------+-----------+
| benchmark               | subject        | revs | its | mem_peak | mode      |
+-------------------------+----------------+------+-----+----------+-----------+
| RowsBench               | bench_chunk_10 | 5    | 5   | 57.617mb | 3.380ms   |
| NativeEntryFactoryBench | bench_10k_rows | 5    | 5   | 83.909mb | 130.132ms |
| NativeEntryFactoryBench | bench_1k_rows  | 5    | 5   | 45.440mb | 13.523ms  |
| NativeEntryFactoryBench | bench_5k_rows  | 5    | 5   | 62.718mb | 67.424ms  |
+-------------------------+----------------+------+-----+----------+-----------+

@stloyd stloyd force-pushed the feature/rows-chunk branch from 3bff6e1 to 9fa5945 Compare October 29, 2023 16:28
@stloyd stloyd force-pushed the feature/rows-chunk branch from 5a86209 to e37e7ba Compare October 29, 2023 17:09
@github-actions github-actions bot added the ci/cd label Oct 29, 2023
@stloyd stloyd force-pushed the feature/rows-chunk branch from 132f096 to 7c26cde Compare October 29, 2023 17:35
@norberttech norberttech merged commit 6241e8a into flow-php:1.x Oct 29, 2023
@stloyd stloyd deleted the feature/rows-chunk branch October 29, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants