Skip to content

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented Oct 29, 2023

Change Log

Added

Fixed

Changed

  • Simplify `Rows::drop()` method
  • Rework benchmark scripts in composer.json

Removed

Deprecated

Security


Description

Old:

+-------------------------+----------------+------+-----+----------+-----------+
| benchmark               | subject        | revs | its | mem_peak | mode      |
+-------------------------+----------------+------+-----+----------+-----------+
| RowsBench               | bench_chunk_10 | 5    | 5   | 57.886mb | 2.538ms   |
| RowsBench               | bench_drop_100 | 5    | 5   | 57.886mb | 12.008ms  |
| NativeEntryFactoryBench | bench_10k_rows | 5    | 5   | 84.180mb | 130.308ms |
| NativeEntryFactoryBench | bench_1k_rows  | 5    | 5   | 45.708mb | 13.086ms  |
| NativeEntryFactoryBench | bench_5k_rows  | 5    | 5   | 62.981mb | 65.004ms  |
+-------------------------+----------------+------+-----+----------+-----------+

New:

+-------------------------+----------------+------+-----+----------+-----------+
| benchmark               | subject        | revs | its | mem_peak | mode      |
+-------------------------+----------------+------+-----+----------+-----------+
| RowsBench               | bench_chunk_10 | 5    | 5   | 57.886mb | 2.558ms   |
| RowsBench               | bench_drop_100 | 5    | 5   | 57.886mb | 4.639ms   |
| NativeEntryFactoryBench | bench_10k_rows | 5    | 5   | 84.180mb | 130.317ms |
| NativeEntryFactoryBench | bench_1k_rows  | 5    | 5   | 45.699mb | 12.981ms  |
| NativeEntryFactoryBench | bench_5k_rows  | 5    | 5   | 62.991mb | 63.155ms  |
+-------------------------+----------------+------+-----+----------+-----------+

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2023

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+-------------------+
| benchmark             | subject           | revs | its | mem_peak         | mode              |
+-----------------------+-------------------+------+-----+------------------+-------------------+
| AvroExtractorBench    | bench_extract_10k | 5    | 3   | 44.123mb -0.00%  | 557.564ms +32.80% |
| CSVExtractorBench     | bench_extract_10k | 5    | 3   | 14.007mb -0.00%  | 486.956ms +32.83% |
| JsonExtractorBench    | bench_extract_10k | 5    | 3   | 18.669mb -0.00%  | 913.543ms +22.70% |
| ParquetExtractorBench | bench_extract_10k | 5    | 3   | 237.793mb -0.00% | 1.281s +28.77%    |
| TextExtractorBench    | bench_extract_10k | 5    | 3   | 7.277mb -0.00%   | 17.952ms +27.71%  |
| XmlExtractorBench     | bench_extract_10k | 5    | 3   | 7.624mb -0.00%   | 771.951ms +26.30% |
+-----------------------+-------------------+------+-----+------------------+-------------------+
Transformers
+-----------------------------+--------------------------+------+-----+-----------------+------------------+
| benchmark                   | subject                  | revs | its | mem_peak        | mode             |
+-----------------------------+--------------------------+------+-----+-----------------+------------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 5    | 5   | 87.062mb -0.00% | 77.282ms +27.88% |
+-----------------------------+--------------------------+------+-----+-----------------+------------------+
Loaders
+--------------------+----------------+------+-----+------------------+-------------------+
| benchmark          | subject        | revs | its | mem_peak         | mode              |
+--------------------+----------------+------+-----+------------------+-------------------+
| AvroLoaderBench    | bench_load_10k | 5    | 3   | 219.956mb -0.00% | 900.790ms +31.63% |
| CSVLoaderBench     | bench_load_10k | 5    | 3   | 47.140mb -0.00%  | 95.144ms +36.22%  |
| JsonLoaderBench    | bench_load_10k | 5    | 3   | 88.580mb -0.00%  | 89.354ms +23.30%  |
| ParquetLoaderBench | bench_load_10k | 5    | 3   | 281.201mb -0.00% | 1.227s +26.33%    |
| TextLoaderBench    | bench_load_10k | 5    | 3   | 16.567mb -0.00%  | 45.128ms +24.19%  |
+--------------------+----------------+------+-----+------------------+-------------------+
Building Blocks
+-------------------------+-----------------------+------+-----+-----------------+-------------------+
| benchmark               | subject               | revs | its | mem_peak        | mode              |
+-------------------------+-----------------------+------+-----+-----------------+-------------------+
| RowsBench               | bench_chunk_10_on_10k | 5    | 5   | 57.617mb        | 4.067ms           |
| RowsBench               | bench_drop_100_on_10k | 5    | 5   | 57.617mb        | 6.220ms           |
| NativeEntryFactoryBench | bench_10k_rows        | 5    | 5   | 83.910mb -0.03% | 206.387ms +47.40% |
| NativeEntryFactoryBench | bench_1k_rows         | 5    | 5   | 45.422mb -0.01% | 18.512ms +31.01%  |
| NativeEntryFactoryBench | bench_5k_rows         | 5    | 5   | 62.711mb +0.00% | 101.744ms +45.50% |
+-------------------------+-----------------------+------+-----+-----------------+-------------------+

@norberttech norberttech merged commit a929620 into flow-php:1.x Oct 29, 2023
@stloyd stloyd deleted the chore/rows-drop branch October 29, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants