Skip to content

Conversation

@norberttech
Copy link
Member

@norberttech norberttech commented Oct 31, 2023

Change Log

Added

  • Added library version to parquet created_by metadata

Fixed

Changed

Removed

Deprecated

Security


Description

Closes: #691
Closes: #575

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2023

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+-------------------+----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode              | rstdev         |
+-----------------------+-------------------+------+-----+------------------+-------------------+----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 44.088mb +0.00%  | 430.844ms -19.97% | ±0.52% +51.52% |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 13.973mb +0.00%  | 348.323ms -22.10% | ±0.31% -83.74% |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 18.635mb +0.00%  | 710.577ms -13.23% | ±0.06% -88.60% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 237.735mb +0.00% | 993.246ms -18.01% | ±0.56% -78.32% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 7.242mb +0.01%   | 18.712ms -21.20%  | ±0.33% -90.06% |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 7.590mb +0.01%   | 618.634ms -19.63% | ±0.57% -75.86% |
+-----------------------+-------------------+------+-----+------------------+-------------------+----------------+
Transformers
+-----------------------------+--------------------------+------+-----+-----------------+------------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak        | mode             | rstdev         |
+-----------------------------+--------------------------+------+-----+-----------------+------------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 87.028mb +0.00% | 66.447ms -21.47% | ±0.48% -80.78% |
+-----------------------------+--------------------------+------+-----+-----------------+------------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+-------------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode              | rstdev         |
+--------------------+----------------+------+-----+------------------+-------------------+----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 93.190mb +0.00%  | 706.408ms -18.12% | ±0.76% -55.82% |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 47.106mb +0.00%  | 69.591ms -25.44%  | ±0.78% -70.16% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 88.540mb +0.00%  | 75.636ms -12.20%  | ±0.29% -87.13% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 281.635mb +0.00% | 1.659s -19.66%    | ±0.11% -94.14% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 16.527mb +0.00%  | 36.419ms -15.41%  | ±1.42% +21.30% |
+--------------------+----------------+------+-----+------------------+-------------------+----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+-----------------+-------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak        | mode              | rstdev          |
+-------------------------+----------------------------+------+-----+-----------------+-------------------+-----------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 60.653mb +0.00% | 4.629ms -6.91%    | ±2.66% +294.08% |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 80.443mb +0.00% | 176.694ms -20.64% | ±0.85% -67.86%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 58.969mb +0.00% | 17.786ms -19.32%  | ±0.38% -87.46%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 59.791mb +0.00% | 3.281ms -2.11%    | ±1.77% -8.39%   |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 59.791mb +0.00% | 3.286ms -0.88%    | ±0.89% -58.40%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 59.005mb +0.00% | 4.193ms -18.29%   | ±2.25% +30.02%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 59.534mb +0.00% | 23.064ms -1.83%   | ±0.31% -86.34%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 59.533mb +0.00% | 23.240ms -3.12%   | ±0.16% -87.13%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 57.604mb +0.00% | 2.406μs -3.52%    | ±1.94% +1.37%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 57.604mb +0.00% | 0.500μs 0.00%     | ±0.00% 0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 65.838mb +0.00% | 13.658ms -21.07%  | ±0.53% -82.42%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 91.358mb +0.00% | 62.155ms -21.17%  | ±0.58% -81.00%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 60.054mb +0.00% | 3.457ms +0.07%    | ±1.01% -70.89%  |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 62.322mb +0.00% | 47.218ms -10.60%  | ±1.34% -28.98%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 62.155mb +0.00% | 7.790ms -11.84%   | ±0.77% -52.20%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 57.604mb +0.00% | 51.005ms -19.71%  | ±0.33% -87.87%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 57.604mb +0.00% | 50.864ms -19.65%  | ±0.47% -84.58%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 57.604mb +0.00% | 51.124ms -17.54%  | ±0.34% -87.91%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 59.879mb +0.00% | 9.431ms -21.10%   | ±0.82% -76.75%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 57.604mb +0.00% | 37.442ms -19.43%  | ±1.62% +16.82%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 57.604mb +0.00% | 20.888μs -28.63%  | ±1.25% +78.14%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 57.604mb +0.00% | 26.261μs -29.94%  | ±1.78% +369.85% |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 80.444mb +0.00% | 178.487ms -20.60% | ±0.68% -57.79%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 91.718mb +0.01% | 146.539ms -20.37% | ±0.68% -71.74%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 47.594mb +0.00% | 75.198ms -22.84%  | ±0.40% -89.27%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 12.380mb +0.01% | 18.054ms -14.95%  | ±1.02% -33.55%  |
+-------------------------+----------------------------+------+-----+-----------------+-------------------+-----------------+

@norberttech norberttech force-pushed the feature/parquet-created_by branch from 7d44170 to 90aa692 Compare October 31, 2023 17:37
Comment on lines +17 to 20
"psr/log": "^2.0 || ^3.0",
"composer-runtime-api": "^2.1",
"flow-php/dremel": "1.x-dev",
"flow-php/snappy": "1.x-dev"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"psr/log": "^2.0 || ^3.0",
"composer-runtime-api": "^2.1",
"flow-php/dremel": "1.x-dev",
"flow-php/snappy": "1.x-dev"
"composer-runtime-api": "^2.1",
"flow-php/dremel": "1.x-dev",
"flow-php/snappy": "1.x-dev",
"psr/log": "^2.0 || ^3.0"

@norberttech norberttech merged commit 1356d23 into flow-php:1.x Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parquet - add library name/version to writer Parquet writer

2 participants