Skip to content

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented Nov 4, 2023

Change Log

Added

Fixed

Changed

  • Extract entry types into new namespace for further re-usage

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2023

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+-------------------+------------------+
| benchmark             | subject           | revs | its | mem_peak         | mode              | rstdev           |
+-----------------------+-------------------+------+-----+------------------+-------------------+------------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.132mb +0.00%  | 561.481ms +53.62% | ±2.04% +15.18%   |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.789mb +0.00%   | 456.157ms +69.59% | ±1.81% +1582.02% |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.937mb +0.00%   | 866.687ms +52.22% | ±1.53% +75.03%   |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 233.497mb +0.00% | 1.347s +62.39%    | ±1.03% -62.70%   |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.783mb +0.00%   | 27.974ms +42.25%  | ±1.61% +138.58%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.783mb +0.00%   | 693.846ms +73.52% | ±3.10% +98.34%   |
+-----------------------+-------------------+------+-----+------------------+-------------------+------------------+
Transformers
+-----------------------------+--------------------------+------+-----+-----------------+------------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak        | mode             | rstdev         |
+-----------------------------+--------------------------+------+-----+-----------------+------------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 87.050mb +0.00% | 89.812ms +84.94% | ±2.79% +95.21% |
+-----------------------------+--------------------------+------+-----+-----------------+------------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+-------------------+------------------+
| benchmark          | subject        | revs | its | mem_peak         | mode              | rstdev           |
+--------------------+----------------+------+-----+------------------+-------------------+------------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 93.290mb -0.00%  | 912.884ms +60.45% | ±2.66% +97.26%   |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 46.066mb +0.00%  | 88.408ms +26.49%  | ±1.72% +65.31%   |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 88.568mb +0.00%  | 96.406ms +57.73%  | ±0.65% -8.37%    |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 284.009mb +0.00% | 2.026s +72.17%    | ±1.94% +82.30%   |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 16.560mb +0.00%  | 48.402ms +21.18%  | ±2.46% +1160.73% |
+--------------------+----------------+------+-----+------------------+-------------------+------------------+
Building Blocks
+-------------------------+----------------------------+------+-----+-----------------+-------------------+------------------+
| benchmark               | subject                    | revs | its | mem_peak        | mode              | rstdev           |
+-------------------------+----------------------------+------+-----+-----------------+-------------------+------------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 60.659mb +0.00% | 4.847ms +114.11%  | ±2.13% -3.93%    |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 80.451mb +0.00% | 212.272ms +40.09% | ±1.95% +269.64%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 58.977mb +0.00% | 21.074ms +37.49%  | ±2.95% +579.65%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 59.798mb +0.00% | 3.355ms +86.71%   | ±0.97% +77.88%   |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 59.798mb +0.00% | 3.360ms +89.10%   | ±0.75% -10.20%   |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 59.011mb +0.00% | 4.618ms +75.38%   | ±2.28% +2487.06% |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 59.540mb +0.00% | 24.969ms +74.58%  | ±2.44% +775.15%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 59.539mb +0.00% | 26.066ms +81.36%  | ±1.51% +236.49%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 57.611mb +0.00% | 2.500μs +46.54%   | ±0.00% -100.00%  |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 57.611mb +0.00% | 0.400μs +33.33%   | ±0.00% +0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 65.844mb +0.00% | 16.066ms +50.30%  | ±2.89% +90.74%   |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 91.364mb +0.00% | 80.495ms +64.12%  | ±2.02% +306.46%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 60.061mb +0.00% | 4.117ms +110.21%  | ±1.31% -22.20%   |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 62.330mb +0.00% | 58.552ms +76.33%  | ±3.17% -3.56%    |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 62.161mb +0.00% | 9.381ms +94.96%   | ±2.61% +60.73%   |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 57.611mb +0.00% | 64.602ms +72.50%  | ±2.60% +501.30%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 57.611mb +0.00% | 63.373ms +68.91%  | ±3.57% +608.25%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 57.611mb +0.00% | 61.110ms +62.39%  | ±0.60% +53.14%   |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 59.885mb +0.00% | 11.858ms +63.01%  | ±1.69% +86.83%   |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 57.610mb +0.00% | 45.434ms +56.78%  | ±2.95% +142.03%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 57.611mb +0.00% | 33.103μs +159.04% | ±2.26% +132.79%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 57.611mb +0.00% | 39.473μs +150.88% | ±2.54% +94.03%   |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 80.452mb +0.00% | 252.936ms +59.83% | ±3.16% +175.94%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 91.719mb +0.00% | 206.731ms +75.28% | ±2.69% +106.10%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 47.595mb +0.02% | 108.097ms +86.33% | ±3.05% +518.97%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 12.391mb -0.00% | 26.491ms +95.48%  | ±2.12% +195.79%  |
+-------------------------+----------------------------+------+-----+-----------------+-------------------+------------------+

@stloyd stloyd force-pushed the feature/extract-entry-types branch from 463175e to 2582e5b Compare November 6, 2023 09:34
@github-actions github-actions bot added size: S and removed size: M labels Nov 6, 2023
@stloyd stloyd force-pushed the feature/extract-entry-types branch from 2582e5b to 445513e Compare November 6, 2023 09:35
@stloyd stloyd force-pushed the feature/extract-entry-types branch from 445513e to 4c6d282 Compare November 6, 2023 09:36
@norberttech
Copy link
Member

Awesome, this is a great starting point for Maps and improving Lists, but I think we might also want to use those types in Expressions later.

@norberttech norberttech merged commit d144af2 into flow-php:1.x Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants