Skip to content

Conversation

@norberttech
Copy link
Member

Change Log

Added

Fixed

Changed

  • Renamed threadSafe into appendSafe

Removed

Deprecated

  • DataFrame::threadSafe()

Security


Description

Additionally, DataFrame will automatically turn on appendSafe when SaveMode::APPEND is used.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2023

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+-------------------+----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode              | rstdev         |
+-----------------------+-------------------+------+-----+------------------+-------------------+----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.138mb -0.02%  | 434.898ms +18.89% | ±0.51% -1.50%  |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.789mb +0.01%   | 345.696ms +28.39% | ±0.21% -21.16% |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.937mb +0.01%   | 697.077ms +20.00% | ±0.15% -78.35% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 233.497mb +0.00% | 990.924ms +25.30% | ±0.05% -95.87% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.783mb +0.01%   | 23.145ms +17.35%  | ±1.79% -45.15% |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.783mb +0.01%   | 557.006ms +36.93% | ±0.32% -63.72% |
+-----------------------+-------------------+------+-----+------------------+-------------------+----------------+
Transformers
+-----------------------------+--------------------------+------+-----+-----------------+------------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak        | mode             | rstdev         |
+-----------------------------+--------------------------+------+-----+-----------------+------------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 87.050mb +0.00% | 66.183ms +34.49% | ±0.61% +38.38% |
+-----------------------------+--------------------------+------+-----+-----------------+------------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+-------------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode              | rstdev         |
+--------------------+----------------+------+-----+------------------+-------------------+----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 93.290mb +0.00%  | 700.635ms +20.56% | ±2.39% +65.01% |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 46.066mb +0.00%  | 69.431ms +1.06%   | ±0.36% -87.43% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 88.568mb +0.00%  | 75.963ms +20.93%  | ±0.79% -14.85% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 284.009mb +0.00% | 1.490s +24.55%    | ±0.75% +71.04% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 16.560mb +0.00%  | 36.008ms -12.60%  | ±0.45% -64.01% |
+--------------------+----------------+------+-----+------------------+-------------------+----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+-----------------+-------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak        | mode              | rstdev          |
+-------------------------+----------------------------+------+-----+-----------------+-------------------+-----------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 60.659mb +0.00% | 3.843ms +72.24%   | ±0.54% -7.40%   |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 80.451mb +0.00% | 176.905ms +16.68% | ±0.20% -16.92%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 58.977mb +0.00% | 17.832ms +17.90%  | ±0.12% -75.35%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 59.798mb +0.00% | 2.818ms +58.88%   | ±0.56% -16.34%  |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 59.798mb +0.00% | 2.830ms +58.58%   | ±1.07% +26.14%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 59.011mb +0.00% | 3.689ms +40.32%   | ±1.39% +208.57% |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 59.540mb +0.00% | 22.133ms +44.57%  | ±1.19% -46.25%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 59.539mb +0.00% | 21.751ms +35.60%  | ±0.97% -66.92%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 57.611mb +0.00% | 2.006μs +11.45%   | ±2.32% +0.00%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 57.611mb +0.00% | 0.400μs 0.00%     | ±0.00% 0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 65.844mb +0.00% | 13.482ms +28.41%  | ±0.01% -99.28%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 91.364mb +0.00% | 59.526ms +18.99%  | ±0.39% -41.45%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 60.060mb +0.00% | 2.979ms +42.21%   | ±0.40% -84.56%  |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 62.330mb +0.00% | 46.007ms +30.18%  | ±0.87% +122.70% |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 62.161mb +0.00% | 7.486ms +50.90%   | ±0.20% -86.11%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 57.611mb +0.00% | 49.937ms +33.55%  | ±0.05% -95.37%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 57.611mb +0.00% | 49.941ms +35.89%  | ±1.00% +47.14%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 57.611mb +0.00% | 50.319ms +35.58%  | ±0.06% -93.10%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 59.885mb +0.00% | 9.360ms +28.84%   | ±0.58% -2.42%   |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 57.610mb +0.00% | 37.225ms +30.95%  | ±0.92% +243.83% |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 57.611mb +0.00% | 20.900μs +57.67%  | ±0.39% -85.85%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 57.611mb +0.00% | 25.900μs +65.19%  | ±0.00% -100.00% |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 80.452mb +0.00% | 178.884ms +12.93% | ±0.54% -51.20%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 91.737mb -0.01% | 146.008ms +23.40% | ±0.55% -6.52%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 47.593mb +0.02% | 74.151ms +23.82%  | ±0.44% -53.51%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 12.391mb -0.03% | 17.461ms +26.82%  | ±0.62% -82.28%  |
+-------------------------+----------------------------+------+-----+-----------------+-------------------+-----------------+

@norberttech norberttech merged commit f8279e6 into flow-php:1.x Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant