Skip to content

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented Nov 8, 2023

Change Log

Added

Fixed

Changed

  • Rework `ScalarType` to hold optional value

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+-------------------+----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode              | rstdev         |
+-----------------------+-------------------+------+-----+------------------+-------------------+----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.273mb -0.01%  | 440.724ms +21.34% | ±0.28% -63.01% |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.834mb +0.01%   | 340.160ms +25.89% | ±0.49% -81.80% |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.995mb +0.08%   | 658.536ms +14.00% | ±0.49% -48.81% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 233.585mb +0.00% | 946.457ms +16.56% | ±0.22% -81.48% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.828mb +0.01%   | 24.663ms +26.24%  | ±0.41% -61.94% |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.828mb +0.01%   | 517.548ms +27.32% | ±0.37% +28.44% |
+-----------------------+-------------------+------+-----+------------------+-------------------+----------------+
Transformers
+-----------------------------+--------------------------+------+-----+-----------------+------------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak        | mode             | rstdev         |
+-----------------------------+--------------------------+------+-----+-----------------+------------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 87.094mb +0.00% | 62.120ms +26.52% | ±0.39% -79.54% |
+-----------------------------+--------------------------+------+-----+-----------------+------------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+-------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode              | rstdev          |
+--------------------+----------------+------+-----+------------------+-------------------+-----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 94.469mb +0.85%  | 665.923ms +11.75% | ±0.49% -77.22%  |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 46.111mb +0.00%  | 69.967ms +1.16%   | ±0.54% +41.74%  |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 89.746mb +0.90%  | 69.157ms +10.16%  | ±0.62% +166.07% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 285.218mb +0.28% | 1.554s +18.30%    | ±0.21% -37.57%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 16.605mb +0.00%  | 35.723ms -10.96%  | ±0.23% -79.37%  |
+--------------------+----------------+------+-----+------------------+-------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+-----------------+-------------------+------------------+
| benchmark               | subject                    | revs | its | mem_peak        | mode              | rstdev           |
+-------------------------+----------------------------+------+-----+-----------------+-------------------+------------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 60.704mb +0.00% | 3.343ms +40.34%   | ±1.84% -41.88%   |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 80.496mb +0.00% | 176.025ms +14.61% | ±0.37% +3.69%    |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 59.022mb +0.00% | 17.766ms +17.08%  | ±0.46% -10.69%   |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 59.842mb +0.00% | 2.673ms +32.54%   | ±1.33% +77.89%   |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 59.842mb +0.00% | 2.816ms +40.41%   | ±1.89% +384.80%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 59.056mb +0.00% | 3.585ms +26.80%   | ±1.14% +12.84%   |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 59.585mb +0.00% | 17.440ms +13.92%  | ±0.39% +87.09%   |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 59.584mb +0.00% | 17.666ms +15.86%  | ±0.83% -59.19%   |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 57.656mb +0.00% | 2.200μs +16.16%   | ±0.00% -100.00%  |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 57.656mb +0.00% | 0.500μs +25.00%   | ±0.00% -100.00%  |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 65.889mb +0.00% | 14.320ms +36.98%  | ±1.55% +124.86%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 91.409mb +0.00% | 57.544ms +18.11%  | ±0.71% +20.68%   |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 60.105mb +0.00% | 2.996ms +33.52%   | ±2.22% +132.47%  |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 62.375mb +0.00% | 41.543ms +21.25%  | ±0.13% -71.11%   |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 62.206mb +0.00% | 6.664ms +28.96%   | ±1.52% +134.35%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 57.656mb +0.00% | 45.724ms +23.35%  | ±0.15% -74.73%   |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 57.656mb +0.00% | 45.843ms +25.41%  | ±0.15% -63.32%   |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 57.656mb +0.00% | 45.925ms +21.97%  | ±0.10% -89.68%   |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 59.930mb +0.00% | 9.953ms +35.40%   | ±1.36% +5.36%    |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 57.655mb +0.00% | 35.744ms +26.94%  | ±0.53% +1254.98% |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 57.656mb +0.00% | 20.686μs +61.49%  | ±2.94% -14.59%   |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 57.656mb +0.00% | 26.212μs +62.36%  | ±0.36% -84.34%   |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 80.497mb +0.00% | 178.239ms +12.90% | ±0.43% -14.54%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 92.912mb +0.87% | 150.214ms +20.56% | ±0.12% -89.62%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 48.224mb +0.82% | 76.442ms +23.57%  | ±0.52% -75.98%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 12.556mb +0.71% | 18.199ms +25.32%  | ±0.19% -90.66%   |
+-------------------------+----------------------------+------+-----+-----------------+-------------------+------------------+

@stloyd stloyd force-pushed the feature/optional-scalar branch from c60df24 to 37fbc76 Compare November 8, 2023 10:54
@stloyd stloyd merged commit 638e215 into flow-php:1.x Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants