Skip to content

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented Nov 10, 2023

Change Log

Added

Fixed

Changed

Removed

  • Remove `CollectionEntry`

Deprecated

Security


Description

Closes #774

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2023

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+-------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode              | rstdev          |
+-----------------------+-------------------+------+-----+------------------+-------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 34.754mb -0.00%  | 1.741s +50.90%    | ±1.44% +242.78% |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.610mb -0.00%   | 511.653ms +68.44% | ±2.33% +314.26% |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.777mb -0.00%   | 2.079s +47.82%    | ±1.17% +65.56%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.482mb -0.00% | 2.393s +48.26%    | ±0.68% -42.35%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.564mb -0.00%   | 35.097ms +44.13%  | ±0.29% -74.61%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.565mb -0.00%   | 651.912ms +58.88% | ±1.65% +20.20%  |
+-----------------------+-------------------+------+-----+------------------+-------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-------------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode              | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-------------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.254mb -0.00% | 108.283ms +65.91% | ±3.30% +78.78% |
+-----------------------------+--------------------------+------+-----+------------------+-------------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+-------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode              | rstdev          |
+--------------------+----------------+------+-----+------------------+-------------------+-----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 94.734mb -0.00%  | 664.791ms +51.30% | ±2.42% +512.44% |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.650mb -0.00%  | 91.055ms +28.66%  | ±2.91% +436.78% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 105.317mb -0.00% | 75.321ms +32.96%  | ±0.54% -41.10%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 320.790mb -0.00% | 2.206s +54.46%    | ±2.58% +191.41% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.594mb -0.00%  | 45.398ms +10.61%  | ±1.22% +161.12% |
+--------------------+----------------+------+-----+------------------+-------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+-------------------+-------------------------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode              | rstdev                        |
+-------------------------+----------------------------+------+-----+------------------+-------------------+-------------------------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.300mb -0.00%  | 4.593ms +75.76%   | ±2.46% +900.98%               |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.092mb -0.00%  | 256.226ms +42.89% | ±1.54% +469.00%               |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.618mb -0.00%  | 26.024ms +42.63%  | ±2.90% +73.77%                |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 75.439mb -0.00%  | 2.841ms +59.23%   | ±1.92% -4.51%                 |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 75.439mb -0.00%  | 2.883ms +63.60%   | ±2.19% -26.01%                |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 74.652mb -0.00%  | 4.004ms +38.11%   | ±2.82% +369.22%               |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.181mb -0.00%  | 26.059ms +78.17%  | ±1.50% +19.34%                |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.181mb -0.00%  | 25.173ms +72.43%  | ±1.74% -53.94%                |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.084mb -0.00%  | 2.506μs +31.90%   | ±1.86% +15922629181314000.00% |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.084mb -0.00%  | 0.500μs +25.00%   | ±0.00% -100.00%               |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 86.643mb -0.00%  | 22.059ms +49.72%  | ±1.54% -9.54%                 |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 116.000mb -0.00% | 105.245ms +58.87% | ±0.74% -67.39%                |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 75.702mb -0.00%  | 3.294ms +61.97%   | ±2.68% +18.88%                |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 77.972mb -0.00%  | 54.175ms +58.82%  | ±3.54% +527.54%               |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 77.802mb -0.00%  | 8.237ms +68.39%   | ±0.82% -64.30%                |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.229mb -0.00%  | 62.335ms +64.18%  | ±1.33% +320.88%               |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.229mb -0.00%  | 61.316ms +57.87%  | ±1.87% +106.42%               |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.229mb -0.00%  | 60.405ms +56.20%  | ±1.07% +9.27%                 |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.526mb -0.00%  | 12.164ms +57.55%  | ±2.23% +139.84%               |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.083mb -0.00%  | 46.990ms +61.32%  | ±1.84% +51.32%                |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.084mb -0.00%  | 29.800μs +124.34% | ±0.00% -100.00%               |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.084mb -0.00%  | 37.053μs +127.04% | ±2.32% +121.19%               |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.093mb -0.00%  | 247.475ms +31.20% | ±2.29% +362.01%               |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 109.044mb -0.00% | 1.338s +56.78%    | ±1.38% -14.27%                |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 56.182mb -0.02%  | 658.436ms +52.24% | ±0.55% -51.59%                |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.037mb -0.01%  | 140.009ms +56.63% | ±1.30% -1.42%                 |
+-------------------------+----------------------------+------+-----+------------------+-------------------+-------------------------------+

@stloyd stloyd requested a review from norberttech November 10, 2023 18:58
@stloyd stloyd force-pushed the issue/774-collection branch from 05c76b3 to a960b9f Compare November 14, 2023 18:20
@stloyd stloyd requested a review from norberttech November 14, 2023 18:21
@stloyd stloyd merged commit cf3ca87 into flow-php:1.x Nov 14, 2023
@stloyd stloyd deleted the issue/774-collection branch November 14, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove CollectionEntry in favor of native & logical types

2 participants