Skip to content

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented Nov 12, 2023

Change Log

Added

Fixed

  • Fix hardcoded entry name for enum entry with schema

Changed

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+-------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode              | rstdev          |
+-----------------------+-------------------+------+-----+------------------+-------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.274mb +0.00%  | 364.834ms -17.72% | ±0.58% +135.77% |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.838mb +0.09%   | 263.532ms -22.38% | ±0.09% -79.12%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 5.008mb +0.09%   | 589.235ms -16.33% | ±1.47% +566.01% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.705mb +0.00% | 758.844ms -25.05% | ±0.65% +41.39%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.832mb +0.09%   | 19.486ms -15.13%  | ±0.91% +11.23%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.832mb +0.09%   | 402.999ms -28.20% | ±0.17% -94.61%  |
+-----------------------+-------------------+------+-----+------------------+-------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+-----------------+------------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak        | mode             | rstdev         |
+-----------------------------+--------------------------+------+-----+-----------------+------------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 87.098mb +0.00% | 49.922ms -28.78% | ±0.42% -33.55% |
+-----------------------------+--------------------------+------+-----+-----------------+------------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+-------------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode              | rstdev         |
+--------------------+----------------+------+-----+------------------+-------------------+----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 95.281mb +0.00%  | 574.209ms -20.84% | ±0.28% -79.65% |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 46.114mb +0.01%  | 69.908ms -0.31%   | ±1.10% -10.25% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 90.559mb +0.00%  | 62.940ms -23.14%  | ±0.30% -81.90% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 292.401mb +0.00% | 1.542s -29.11%    | ±0.59% +33.19% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 16.608mb +0.03%  | 41.012ms +11.99%  | ±0.31% -70.38% |
+--------------------+----------------+------+-----+------------------+-------------------+----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+-----------------+-------------------+------------------+
| benchmark               | subject                    | revs | its | mem_peak        | mode              | rstdev           |
+-------------------------+----------------------------+------+-----+-----------------+-------------------+------------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 60.708mb +0.01% | 2.306ms -43.99%   | ±2.80% +8.33%    |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 80.500mb +0.01% | 154.935ms -12.52% | ±0.24% -53.39%   |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 59.026mb +0.01% | 15.426ms -13.95%  | ±0.59% -14.79%   |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 59.846mb +0.01% | 2.113ms -34.67%   | ±2.11% -27.49%   |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 59.846mb +0.01% | 1.956ms -41.28%   | ±0.49% -77.04%   |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 59.060mb +0.01% | 3.016ms -31.33%   | ±2.20% +20.88%   |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 59.589mb +0.01% | 16.671ms -35.38%  | ±1.46% -9.68%    |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 59.588mb +0.01% | 17.018ms -32.91%  | ±1.62% +57.48%   |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 57.659mb +0.01% | 2.000μs -20.19%   | ±0.00% -100.00%  |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 57.659mb +0.01% | 0.400μs -33.33%   | ±0.00% +0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 65.893mb +0.01% | 10.797ms -22.27%  | ±1.13% +60.81%   |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 91.412mb +0.00% | 49.716ms -21.80%  | ±1.03% +51.64%   |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 60.109mb +0.01% | 2.407ms -32.12%   | ±1.99% +42.13%   |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 62.379mb +0.01% | 38.850ms -23.79%  | ±2.21% +183.16%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 62.210mb +0.01% | 5.154ms -36.94%   | ±2.20% +67.62%   |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 57.659mb +0.01% | 37.056ms -27.22%  | ±0.82% +44.47%   |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 57.659mb +0.01% | 36.932ms -26.55%  | ±1.34% +274.31%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 57.659mb +0.01% | 37.565ms -26.61%  | ±1.16% +38.39%   |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 59.934mb +0.01% | 7.351ms -21.99%   | ±1.78% +1075.17% |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 57.659mb +0.01% | 28.315ms -25.13%  | ±0.90% +61.38%   |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 57.659mb +0.01% | 13.282μs -39.81%  | ±1.07% -42.82%   |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 57.659mb +0.01% | 15.999μs -41.37%  | ±2.04% +3.32%    |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 80.500mb +0.01% | 159.464ms -12.21% | ±0.52% -47.75%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 93.715mb +0.01% | 125.294ms -19.55% | ±2.37% +523.62%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 48.630mb +0.01% | 65.499ms -18.62%  | ±2.50% +424.55%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 12.653mb -0.00% | 14.706ms -23.84%  | ±0.67% -31.15%   |
+-------------------------+----------------------------+------+-----+-----------------+-------------------+------------------+

@stloyd stloyd merged commit f6ad17e into flow-php:1.x Nov 12, 2023
@stloyd stloyd deleted the bugfix/enum-def-entry branch November 12, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants