Skip to content

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented Nov 21, 2023

Change Log

Added

Fixed

  • Add missing `EnumType` detection in `NativeEntryFactory`

Changed

Removed

Deprecated

Security


Description

@github-actions
Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 34.753mb +0.01%  | 709.008ms -0.66% | ±0.43% -77.66%  |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.617mb +0.10%   | 296.445ms -0.62% | ±2.63% +231.59% |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.777mb +0.09%   | 946.056ms +0.46% | ±0.26% -46.66%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.487mb +0.00% | 1.139s +0.46%    | ±1.48% +114.77% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.556mb +0.10%   | 24.039ms +0.20%  | ±1.57% -13.34%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.556mb +0.10%   | 403.068ms -3.66% | ±0.44% -63.47%  |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.242mb +0.00% | 63.430ms +0.46% | ±1.50% -25.29% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev         |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 94.414mb +0.00%  | 444.129ms +0.23% | ±0.50% +32.00% |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.723mb +0.01%  | 72.293ms -0.14%  | ±0.34% -79.00% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 104.996mb +0.00% | 57.217ms +2.73%  | ±2.34% +57.40% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 320.474mb +0.00% | 1.471s -1.21%    | ±1.30% +88.79% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.597mb +0.03%  | 41.260ms -1.27%  | ±0.49% -51.72% |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.296mb +0.01%  | 2.656ms -0.16%   | ±0.95% -40.65%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.087mb +0.00%  | 175.649ms +0.49% | ±1.51% +194.52% |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.613mb +0.01%  | 17.572ms +0.21%  | ±0.54% +44.63%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 77.536mb +0.01%  | 1.685ms -11.48%  | ±1.85% -46.64%  |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 77.536mb +0.01%  | 1.730ms -14.31%  | ±0.64% -73.11%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 74.648mb +0.01%  | 2.560ms -11.31%  | ±1.12% -61.06%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.177mb +0.01%  | 16.051ms +11.97% | ±1.14% -30.63%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.177mb +0.01%  | 15.907ms +6.71%  | ±1.32% +4.01%   |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.080mb +0.01%  | 1.806μs -4.64%   | ±2.57% +1.82%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.080mb +0.01%  | 0.400μs 0.00%    | ±0.00% 0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 86.637mb +0.01%  | 12.625ms +1.54%  | ±1.76% +207.71% |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 115.996mb +0.00% | 64.203ms -2.46%  | ±0.44% -77.52%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 75.698mb +0.01%  | 1.978ms -16.98%  | ±1.77% -29.28%  |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 77.964mb +0.01%  | 36.681ms +0.41%  | ±2.51% +25.27%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 77.798mb +0.01%  | 3.825ms -19.17%  | ±0.17% -87.42%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.223mb +0.01%  | 38.078ms -4.24%  | ±0.84% +48.12%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.224mb +0.01%  | 38.192ms -4.66%  | ±0.82% +651.13% |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.223mb +0.01%  | 38.660ms -1.78%  | ±0.58% -35.52%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.522mb +0.01%  | 7.287ms -4.09%   | ±0.57% -51.96%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.080mb +0.01%  | 29.082ms -3.21%  | ±1.72% -24.60%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.080mb +0.01%  | 13.279μs -4.17%  | ±0.94% -55.52%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.080mb +0.01%  | 16.493μs -3.24%  | ±1.85% -30.02%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.088mb +0.00%  | 180.761ms +0.47% | ±0.76% +40.88%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.174mb +0.00%  | 354.213ms -3.41% | ±0.37% -73.28%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.097mb +0.00%  | 70.325ms -1.51%  | ±1.16% +106.02% |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 115.840mb +0.00% | 398.813ms -0.56% | ±0.13% -89.97%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 59.558mb +0.01%  | 201.556ms +1.30% | ±1.15% +78.38%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.683mb +0.03%  | 41.922ms -4.25%  | ±2.82% +203.84% |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@norberttech norberttech merged commit f59a980 into flow-php:1.x Nov 21, 2023
@stloyd stloyd deleted the bugfix/enum-entry-missing branch November 21, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants