Skip to content

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented Nov 22, 2023

Change Log

Added

  • Add testing of PHP 8.3 into the pipeline

Fixed

Changed

Removed

Deprecated

Security


Description

@stloyd stloyd requested a review from norberttech November 22, 2023 10:33
@stloyd stloyd marked this pull request as ready for review November 22, 2023 10:33
@github-actions
Copy link
Contributor

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 34.757mb +0.01%  | 684.300ms +2.01% | ±0.83% +23.55%  |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.621mb +0.05%   | 297.185ms +0.10% | ±0.56% +30.18%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.781mb +0.05%   | 918.597ms +0.22% | ±1.88% -18.25%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.490mb +0.00% | 1.095s +1.35%    | ±0.57% +19.30%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.560mb +0.05%   | 24.624ms +4.33%  | ±1.72% +140.83% |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.560mb +0.05%   | 411.881ms +1.75% | ±0.88% -73.63%  |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.246mb +0.00% | 62.932ms -0.10% | ±2.60% +28.64% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev         |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 94.417mb +0.00%  | 443.026ms -0.47% | ±1.05% +36.18% |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.727mb +0.00%  | 73.167ms +3.64%  | ±0.70% -49.96% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 104.999mb +0.00% | 56.899ms +4.04%  | ±0.97% -51.62% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 320.477mb +0.00% | 1.496s +2.02%    | ±0.39% -30.69% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.601mb +0.01%  | 41.547ms -0.38%  | ±0.81% -19.66% |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev           |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.300mb +0.00%  | 3.284ms +28.33%  | ±3.68% +484.70%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.091mb +0.00%  | 177.172ms -0.66% | ±0.13% -90.38%   |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.617mb +0.00%  | 18.080ms +0.71%  | ±3.35% +391.61%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 77.540mb +0.00%  | 1.834ms +7.56%   | ±1.71% +14.83%   |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 77.540mb +0.00%  | 1.764ms +3.77%   | ±1.74% +1056.20% |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 74.653mb +0.00%  | 3.078ms +22.50%  | ±3.32% +70.50%   |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.181mb +0.00%  | 14.853ms +4.74%  | ±0.62% -35.30%   |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.181mb +0.00%  | 14.979ms +7.72%  | ±0.74% -45.08%   |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.084mb +0.00%  | 2.000μs +17.23%  | ±0.00% -100.00%  |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.084mb +0.00%  | 0.400μs +33.33%  | ±0.00% +0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 86.641mb +0.00%  | 13.039ms +2.84%  | ±1.59% +99.75%   |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 116.001mb +0.00% | 64.295ms +3.02%  | ±3.49% +33.76%   |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 75.702mb +0.00%  | 1.982ms +4.89%   | ±3.27% +2.77%    |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 77.968mb +0.00%  | 36.516ms +10.46% | ±1.18% +29.08%   |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 77.802mb +0.00%  | 4.422ms +15.86%  | ±1.15% -65.26%   |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.227mb +0.00%  | 41.845ms +8.50%  | ±1.75% +575.20%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.228mb +0.00%  | 40.799ms +5.19%  | ±1.00% +54.84%   |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.227mb +0.00%  | 40.192ms +3.69%  | ±0.63% -62.39%   |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.527mb +0.00%  | 7.626ms +1.57%   | ±3.35% +0.03%    |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.084mb +0.00%  | 29.137ms +2.18%  | ±2.48% +84.13%   |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.084mb +0.00%  | 14.106μs +7.78%  | ±0.33% -53.89%   |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.084mb +0.00%  | 16.510μs +4.08%  | ±2.68% +11.68%   |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.092mb +0.00%  | 180.664ms -2.41% | ±0.15% -79.22%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.173mb +0.00%  | 329.205ms +0.70% | ±0.67% -7.83%    |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.096mb +0.00%  | 65.697ms +2.62%  | ±0.22% -75.62%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 115.843mb +0.00% | 374.535ms +0.65% | ±0.25% -53.63%   |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 59.561mb +0.00%  | 190.782ms +1.53% | ±0.86% +102.55%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.686mb +0.00%  | 41.080ms +4.47%  | ±0.47% -59.32%   |
+-------------------------+----------------------------+------+-----+------------------+------------------+------------------+

@stloyd stloyd merged commit 181f332 into flow-php:1.x Nov 22, 2023
@stloyd stloyd deleted the chore/php83 branch November 22, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants