Skip to content

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented Nov 22, 2023

Change Log

Added

Fixed

Changed

  • Simplify PHPUnit configuration

Removed

Deprecated

Security


Description

Declaring every adapter or library in the PHPUnit configuration increases maintenance costs for maintainers while introducing potential issues with missing some tests. While we reworked the test structure to be the same between adapters (excluding Doctrine) we can use glob patterns in the configuration of PHPUnit.

Seems like we missed over 100 tests (1677 vs 1798):

composer run-script test
> tools/phpunit/vendor/bin/phpunit
PHPUnit 10.4.2 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.1.25 with PCOV 1.0.11
Configuration: /Users/stloyd/Documents/flow/phpunit.xml
Random Seed:   1700652801

.............................................................   61 / 1798 (  3%)
.............................................................  122 / 1798 (  6%)
.............................................................  183 / 1798 ( 10%)
.............................................................  244 / 1798 ( 13%)
.............................................................  305 / 1798 ( 16%)
.............................................................  366 / 1798 ( 20%)
.............................................................  427 / 1798 ( 23%)
.............................................................  488 / 1798 ( 27%)
.............................................................  549 / 1798 ( 30%)
.............................................................  610 / 1798 ( 33%)
.............................................................  671 / 1798 ( 37%)
.............................................................  732 / 1798 ( 40%)
.............................................................  793 / 1798 ( 44%)
.............................................................  854 / 1798 ( 47%)
.............................................................  915 / 1798 ( 50%)
.............................................................  976 / 1798 ( 54%)
............................................................. 1037 / 1798 ( 57%)
............................................................. 1098 / 1798 ( 61%)
............................................................. 1159 / 1798 ( 64%)
............................................................. 1220 / 1798 ( 67%)
............................................................. 1281 / 1798 ( 71%)
............................................................. 1342 / 1798 ( 74%)
............................................................. 1403 / 1798 ( 78%)
............................................................. 1464 / 1798 ( 81%)
............................................................. 1525 / 1798 ( 84%)
............................................................. 1586 / 1798 ( 88%)
............................................................. 1647 / 1798 ( 91%)
............................................................. 1708 / 1798 ( 94%)
............................................................. 1769 / 1798 ( 98%)
.............................                                 1798 / 1798 (100%)

Time: 00:43.928, Memory: 214.50 MB

OK (1798 tests, 283983 assertions)

@stloyd stloyd merged commit 986b735 into flow-php:1.x Nov 22, 2023
@stloyd stloyd deleted the chore/php-unit-groups branch November 22, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants