Skip to content

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented Nov 23, 2023

Change Log

Added

  • Allow to change hash algorithm in `HashIdFactory`

Fixed

Changed

Removed

  • Remove `Sha1IdFactory`

Deprecated

Security


Description

@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2023

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev         |
+-----------------------+-------------------+------+-----+------------------+------------------+----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 34.765mb +0.00%  | 689.733ms +0.95% | ±0.61% -19.25% |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.629mb +0.00%   | 298.558ms +0.58% | ±0.06% -90.37% |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.788mb +0.00%   | 921.064ms +0.63% | ±0.88% +14.34% |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.498mb +0.00% | 1.102s +1.23%    | ±0.60% -28.12% |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.568mb +0.00%   | 24.518ms +1.22%  | ±1.89% +49.54% |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.568mb +0.00%   | 406.904ms -0.11% | ±0.97% +22.27% |
+-----------------------+-------------------+------+-----+------------------+------------------+----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.252mb +0.00% | 62.404ms +0.01% | ±2.03% -14.87% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 94.425mb +0.00%  | 446.136ms -0.77% | ±1.28% +115.94% |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.734mb +0.00%  | 71.287ms -0.06%  | ±0.47% -5.36%   |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 105.007mb +0.00% | 55.882ms +1.42%  | ±0.76% -28.50%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 320.485mb +0.00% | 1.475s -0.12%    | ±1.23% -47.40%  |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.609mb +0.00%  | 41.071ms -1.58%  | ±0.74% +36.15%  |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.302mb +0.00%  | 2.638ms +0.47%   | ±1.34% -9.27%   |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.093mb +0.00%  | 177.890ms +0.92% | ±0.72% -29.21%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.618mb +0.00%  | 17.667ms +0.75%  | ±0.42% +6.13%   |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 77.542mb +0.00%  | 1.648ms -4.22%   | ±2.38% +233.53% |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 77.542mb +0.00%  | 1.671ms -4.33%   | ±1.41% -51.45%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 74.654mb +0.00%  | 2.584ms -0.86%   | ±3.47% +67.11%  |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.183mb +0.00%  | 14.589ms +0.96%  | ±1.38% +88.73%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.183mb +0.00%  | 14.659ms +2.23%  | ±0.34% -81.40%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.086mb +0.00%  | 1.706μs -5.22%   | ±2.72% +0.00%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.086mb +0.00%  | 0.400μs 0.00%    | ±0.00% 0.00%    |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 86.643mb +0.00%  | 13.745ms +11.80% | ±2.76% +183.23% |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 116.002mb +0.00% | 66.303ms +7.01%  | ±2.69% +255.59% |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 75.703mb +0.00%  | 1.783ms -0.47%   | ±3.74% +327.77% |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 77.974mb +0.00%  | 33.628ms +0.84%  | ±2.03% +39.87%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 77.804mb +0.00%  | 4.000ms +5.15%   | ±0.82% +162.44% |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.229mb +0.00%  | 38.355ms -0.91%  | ±1.09% -63.04%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.229mb +0.00%  | 38.605ms -0.41%  | ±0.48% -51.94%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.229mb +0.00%  | 39.428ms +1.71%  | ±1.39% +150.67% |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.528mb +0.00%  | 7.587ms +2.46%   | ±3.28% +726.24% |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.086mb +0.00%  | 29.182ms +2.75%  | ±1.67% +94.58%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.086mb +0.00%  | 13.621μs +2.32%  | ±0.92% +30.34%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.086mb +0.00%  | 16.334μs +2.73%  | ±1.26% +0.00%   |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.094mb +0.00%  | 182.887ms +1.83% | ±0.92% +176.70% |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.174mb +0.00%  | 328.742ms -0.26% | ±0.68% -34.92%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.097mb +0.00%  | 64.928ms +0.47%  | ±0.29% -51.13%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 115.845mb +0.00% | 374.531ms -1.01% | ±0.62% +92.06%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 59.563mb +0.00%  | 188.941ms +2.86% | ±0.57% -35.45%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.688mb +0.00%  | 40.131ms +3.82%  | ±0.63% -60.73%  |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@norberttech norberttech merged commit 4cd1ccb into flow-php:1.x Nov 25, 2023
@stloyd stloyd deleted the feature/hash-algo branch November 25, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants