Skip to content

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented Nov 28, 2023

Change Log

Added

Fixed

  • Use platform for column escaping in bulk insert

Changed

Removed

Deprecated

Security


Description

Ensure that column names in generated queries are escaped to match the default behavior done in Doctrine.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2023

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 34.765mb +0.00%  | 682.805ms +1.69% | ±1.96% +266.18% |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.630mb +0.00%   | 295.476ms -0.66% | ±0.24% -59.93%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.789mb +0.00%   | 914.443ms -0.03% | ±0.21% -90.37%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.499mb +0.00% | 1.097s +0.31%    | ±0.54% -11.37%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.570mb +0.00%   | 23.967ms +0.35%  | ±0.50% -23.11%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.571mb +0.00%   | 407.012ms -0.22% | ±2.83% +654.94% |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.254mb +0.00% | 62.581ms -1.14% | ±0.58% -53.09% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev          |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 94.426mb +0.00%  | 455.250ms +3.32% | ±2.07% +8.11%   |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.736mb +0.00%  | 71.465ms +0.08%  | ±0.60% +63.20%  |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 105.008mb +0.00% | 53.799ms -0.29%  | ±1.27% +96.45%  |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 320.486mb +0.00% | 1.514s +4.65%    | ±1.26% +328.92% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.610mb +0.00%  | 41.559ms +2.01%  | ±1.23% +47.88%  |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.303mb +0.00%  | 2.666ms +1.68%   | ±1.12% +37.62%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.096mb +0.00%  | 178.927ms +0.62% | ±0.37% -48.98%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.622mb +0.00%  | 17.905ms +1.12%  | ±0.45% -46.25%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 77.543mb +0.00%  | 1.643ms +3.76%   | ±0.87% -45.23%  |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 77.543mb +0.00%  | 1.703ms +8.96%   | ±0.95% -43.30%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 74.655mb +0.00%  | 2.666ms +6.33%   | ±3.06% +163.80% |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.184mb +0.00%  | 14.396ms -0.10%  | ±0.89% +8.80%   |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.184mb +0.00%  | 15.147ms +4.35%  | ±1.33% +227.24% |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.087mb +0.00%  | 1.806μs +0.34%   | ±2.57% +0.00%   |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.087mb +0.00%  | 0.400μs +33.33%  | ±0.00% +0.00%   |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 86.644mb +0.00%  | 12.335ms +0.69%  | ±3.39% +53.10%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 116.003mb +0.00% | 65.342ms +8.19%  | ±0.83% -37.17%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 75.705mb +0.00%  | 1.763ms +1.05%   | ±2.49% +735.30% |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 77.978mb +0.00%  | 33.820ms +0.76%  | ±0.59% -65.05%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 77.805mb +0.00%  | 3.847ms -3.31%   | ±1.93% -25.93%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.232mb +0.00%  | 39.770ms -0.22%  | ±0.24% -4.61%   |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.233mb +0.00%  | 40.575ms +2.21%  | ±0.73% +59.65%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.232mb +0.00%  | 40.467ms +1.46%  | ±1.37% +155.72% |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.529mb +0.00%  | 7.434ms +1.64%   | ±0.41% +494.52% |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.087mb +0.00%  | 28.826ms -1.22%  | ±0.35% -52.14%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.087mb +0.00%  | 13.676μs +0.18%  | ±1.39% -50.49%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.087mb +0.00%  | 15.899μs +1.15%  | ±1.54% +72.12%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.097mb +0.00%  | 181.984ms +0.36% | ±0.61% +18.31%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.175mb +0.00%  | 321.697ms +1.09% | ±0.53% +9.09%   |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.098mb +0.00%  | 62.625ms +0.81%  | ±1.12% +19.90%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 115.846mb +0.00% | 363.562ms +0.19% | ±1.76% +31.12%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 59.564mb +0.00%  | 183.820ms -1.79% | ±1.33% -56.23%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.689mb +0.00%  | 38.785ms +1.36%  | ±2.47% +190.42% |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@stloyd stloyd merged commit 9b90eb1 into flow-php:1.x Nov 28, 2023
@stloyd stloyd deleted the issue/768 branch November 28, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants