Skip to content

Conversation

@stloyd
Copy link
Member

@stloyd stloyd commented Dec 1, 2023

Change Log

Added

Fixed

  • Fix wrong namespace of `HashIdFactoryTest` test

Changed

Removed

Deprecated

Security


Description

Reported by Composer:

Class Flow\ETL\Adapter\Elasticsearch\Tests\Unit\HashIdFactoryTest located in ./src/adapter/etl-adapter-elasticsearch/tests/Flow/ETL/Adapter/Elasticsearch/Tests/Unit/EntryIdFactory/HashIdFactoryTest.php does not comply with psr-4 autoloading standard. Skipping.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023

Flow PHP - Benchmarks

Results of the benchmarks from this PR are compared with the results from 1.x branch.

Extractors
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| benchmark             | subject           | revs | its | mem_peak         | mode             | rstdev          |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
| AvroExtractorBench    | bench_extract_10k | 1    | 3   | 35.122mb +0.00%  | 714.761ms +2.05% | ±1.45% +367.89% |
| CSVExtractorBench     | bench_extract_10k | 1    | 3   | 4.820mb +0.01%   | 302.364ms +0.03% | ±0.16% -41.54%  |
| JsonExtractorBench    | bench_extract_10k | 1    | 3   | 4.919mb +0.01%   | 939.485ms +1.73% | ±0.12% -85.49%  |
| ParquetExtractorBench | bench_extract_10k | 1    | 3   | 239.625mb +0.00% | 1.108s -0.64%    | ±1.47% +55.01%  |
| TextExtractorBench    | bench_extract_10k | 1    | 3   | 4.698mb +0.01%   | 24.789ms -3.47%  | ±1.59% +12.97%  |
| XmlExtractorBench     | bench_extract_10k | 1    | 3   | 4.699mb +0.01%   | 408.808ms +0.13% | ±0.63% -6.47%   |
+-----------------------+-------------------+------+-----+------------------+------------------+-----------------+
Transformers
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark                   | subject                  | revs | its | mem_peak         | mode            | rstdev         |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEntryTransformerBench | bench_transform_10k_rows | 1    | 3   | 110.385mb +0.00% | 64.590ms -1.51% | ±0.55% -66.45% |
+-----------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| benchmark          | subject        | revs | its | mem_peak         | mode             | rstdev         |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
| AvroLoaderBench    | bench_load_10k | 1    | 3   | 94.783mb +0.00%  | 462.801ms -2.18% | ±3.39% -1.26%  |
| CSVLoaderBench     | bench_load_10k | 1    | 3   | 54.860mb +0.00%  | 71.556ms -1.78%  | ±0.87% -26.81% |
| JsonLoaderBench    | bench_load_10k | 1    | 3   | 105.443mb +0.00% | 56.276ms +0.52%  | ±0.96% +30.02% |
| ParquetLoaderBench | bench_load_10k | 1    | 3   | 320.653mb +0.00% | 1.487s +0.90%    | ±0.64% -10.75% |
| TextLoaderBench    | bench_load_10k | 1    | 3   | 17.737mb +0.00%  | 42.017ms -0.09%  | ±0.78% -21.77% |
+--------------------+----------------+------+-----+------------------+------------------+----------------+
Building Blocks
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark               | subject                    | revs | its | mem_peak         | mode             | rstdev          |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| RowsBench               | bench_chunk_10_on_10k      | 2    | 3   | 76.435mb +0.00%  | 2.777ms -0.31%   | ±0.78% -49.67%  |
| RowsBench               | bench_diff_left_1k_on_10k  | 2    | 3   | 96.228mb +0.00%  | 185.284ms +1.12% | ±0.78% +42.06%  |
| RowsBench               | bench_diff_right_1k_on_10k | 2    | 3   | 74.754mb +0.00%  | 18.566ms +0.49%  | ±0.66% +63.35%  |
| RowsBench               | bench_drop_1k_on_10k       | 2    | 3   | 77.675mb +0.00%  | 1.864ms +2.97%   | ±3.40% +45.43%  |
| RowsBench               | bench_drop_right_1k_on_10k | 2    | 3   | 77.675mb +0.00%  | 1.819ms +0.39%   | ±0.72% -71.96%  |
| RowsBench               | bench_entries_on_10k       | 2    | 3   | 74.787mb +0.00%  | 2.676ms -8.20%   | ±2.47% +469.85% |
| RowsBench               | bench_filter_on_10k        | 2    | 3   | 75.316mb +0.00%  | 14.688ms -13.41% | ±1.69% +90.57%  |
| RowsBench               | bench_find_on_10k          | 2    | 3   | 75.316mb +0.00%  | 14.516ms -13.43% | ±1.25% -34.13%  |
| RowsBench               | bench_find_one_on_10k      | 10   | 3   | 73.219mb +0.00%  | 1.800μs -10.00%  | ±0.00% 0.00%    |
| RowsBench               | bench_first_on_10k         | 10   | 3   | 73.219mb +0.00%  | 0.300μs -25.00%  | ±0.00% -100.00% |
| RowsBench               | bench_flat_map_on_1k       | 2    | 3   | 86.776mb +0.00%  | 12.558ms -8.53%  | ±2.59% -13.04%  |
| RowsBench               | bench_map_on_10k           | 2    | 3   | 116.135mb +0.00% | 64.290ms -2.18%  | ±1.13% -13.50%  |
| RowsBench               | bench_merge_1k_on_10k      | 2    | 3   | 75.837mb +0.00%  | 1.979ms +0.35%   | ±2.82% +8.69%   |
| RowsBench               | bench_partition_by_on_10k  | 2    | 3   | 78.110mb +0.00%  | 33.913ms -13.05% | ±0.41% -28.43%  |
| RowsBench               | bench_remove_on_10k        | 2    | 3   | 77.937mb +0.00%  | 3.949ms -4.23%   | ±0.13% -91.31%  |
| RowsBench               | bench_sort_asc_on_1k       | 2    | 3   | 73.364mb +0.00%  | 39.319ms -0.69%  | ±1.05% -61.34%  |
| RowsBench               | bench_sort_by_on_1k        | 2    | 3   | 73.365mb +0.00%  | 39.751ms -0.18%  | ±0.12% -46.58%  |
| RowsBench               | bench_sort_desc_on_1k      | 2    | 3   | 73.364mb +0.00%  | 39.672ms -1.32%  | ±2.13% +23.60%  |
| RowsBench               | bench_sort_entries_on_1k   | 2    | 3   | 75.661mb +0.00%  | 7.447ms -0.77%   | ±1.69% +22.65%  |
| RowsBench               | bench_sort_on_1k           | 2    | 3   | 73.219mb +0.00%  | 28.809ms +0.21%  | ±0.21% -86.18%  |
| RowsBench               | bench_take_1k_on_10k       | 10   | 3   | 73.219mb +0.00%  | 13.782μs +4.54%  | ±1.03% -36.45%  |
| RowsBench               | bench_take_right_1k_on_10k | 10   | 3   | 73.219mb +0.00%  | 16.088μs +1.07%  | ±0.59% -33.47%  |
| RowsBench               | bench_unique_on_1k         | 2    | 3   | 96.229mb +0.00%  | 182.041ms +0.30% | ±0.56% -46.05%  |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 59.380mb +0.00%  | 365.124ms +9.10% | ±3.04% +511.58% |
| TypeDetectorBench       | bench_type_detector        | 1    | 3   | 14.303mb +0.00%  | 66.874ms +0.52%  | ±1.25% -30.92%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 115.978mb +0.00% | 385.258ms -2.66% | ±0.66% -69.63%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 59.696mb +0.00%  | 191.857ms -0.58% | ±1.02% +36.95%  |
| NativeEntryFactoryBench | bench_entry_factory        | 1    | 3   | 14.821mb +0.00%  | 40.172ms +1.22%  | ±1.20% +148.95% |
+-------------------------+----------------------------+------+-----+------------------+------------------+-----------------+

@norberttech norberttech merged commit b869ea2 into flow-php:1.x Dec 1, 2023
@stloyd stloyd deleted the hash-elastic-test-typo branch December 1, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants