-
-
Notifications
You must be signed in to change notification settings - Fork 48
Add documentation about installation using Homebrew #861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
719d777 to
6f44eba
Compare
07d96e3 to
52a8e6a
Compare
52a8e6a to
aa4a5fd
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
218e560 to
ec36e21
Compare
|
Ok, so here is my position on this. As much as I would love to keep it like that, there is one serious problem with the approach of keeping brew formula outside of the monorepo. Outside repo means another step in the release process, which I would prefer to keep as simple as possible. We have the following options here:
The official distro also means manually opening PR's after every release, but at least users wont need to add custom taps to brew. |
30c2252 to
fe0dc06
Compare
f02ec47 to
78b5193
Compare
78b5193 to
8e9db5e
Compare
|
Could you, just one last time, on your fork, mark a new release and test this whole build-release workflow before I merge this and release new version? |
|
@norberttech Here:
On my fork the main difference was old comment + usage of my fork in all URLs. When you approve this PR I will rebase and remove the commit from the PR. |
|
Looks good, any idea why on hour 0.5.6 version there is no signed phar? |
|
32c9bc5 to
8e9db5e
Compare
|
yeah, but what about the version of the tap repo? Could you maybe explain step by step what will happen once release is published? I mean which workflows will |
The only consideration here can be changelog update being triggered on commit to update formula. Probably we should add that path to ignore, like: Subject: [PATCH] Add homebrew formula into monorepo
---
Index: .github/workflows/automation-changelog-update.yml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/.github/workflows/automation-changelog-update.yml b/.github/workflows/automation-changelog-update.yml
--- a/.github/workflows/automation-changelog-update.yml (revision 8e9db5ec94ef1f2262485104d3160eec2f0282d4)
+++ b/.github/workflows/automation-changelog-update.yml (date 1701802523024)
@@ -4,6 +4,9 @@
workflow_dispatch:
push:
branches: [ 1.x ]
+ paths-ignore:
+ # Ignore updates of Homebrew formula in CHANGELOG
+ - 'src/tools/homebrew/Formula/flow-php.rb'
jobs:
automation: |
I think that's fine. It will be a single entry after each release. |
|
Ping me when it's ready to merge, will push another release after |
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security
Description
Example (commit message adjusted in PR):
