Skip to content

Conversation

@owsiakl
Copy link
Member

@owsiakl owsiakl commented Jan 4, 2024

Change Log

Added

  • Base symfony skeleton for a landing page

Fixed

Changed

Removed

Deprecated

Security


Description

@norberttech
Copy link
Member

Looks great! 🚀

@owsiakl owsiakl marked this pull request as ready for review January 4, 2024 14:34
Copy link
Member

@norberttech norberttech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The only tiny thing I would change is default namespace of that app.
This App should be configurable, not sure why Symfony is enforcing something so generic. Here you can find how to do it

I would go with Flow\Website

@norberttech norberttech merged commit 8cffb6f into flow-php:1.x Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants